History

lavf/tls_mbedtls: restrict TLSv1.3 verification workaround to affected version

Now that mbedTLS 3.6.1 is released we know that only 3.6.0 contains this regression.

sfan5 committed 2 years ago

Commit e66f9771 parent 5c66a3a1 file · +2 −2Browse files

Unified · Split

libavformat/tls_mbedtls.c+2−2
@@ -270,8 +270,8 @@ static int tls_open(URLContext *h, const char *uri, int flags, AVDictionary **op · 269 unmodified lines
270270 }
271271
272272 #ifdef MBEDTLS_SSL_PROTO_TLS1_3
273− // mbedTLS does not allow disabling certificate verification with TLSv1.3 (yes, really).
274− if (!shr->verify) {
273+ // this version does not allow disabling certificate verification with TLSv1.3 (yes, really).
274+ if (mbedtls_version_get_number() == 0x03060000 && !shr->verify) {
275275 av_log(h, AV_LOG_INFO, "Forcing TLSv1.2 because certificate verification is disabled\n");
276276 mbedtls_ssl_conf_max_tls_version(&tls_ctx->ssl_config, MBEDTLS_SSL_VERSION_TLS1_2);
277277 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t