History

avformat/iamf: remove duplicated function

James Almer committed 2 years ago

Commit ec7937f1 parent 4a134eb3 files · +15 −31Browse files

Unified · Split

3 files
  1. libavformat/iamf.h +14 −0
  2. libavformat/iamf_reader.c +1 −17
  3. libavformat/iamf_writer.h +0 −14
libavformat/iamf.h+14−0
@@ -165,6 +165,20 @@ struct IAMFSoundSystemMap { · 164 unmodified lines
165165 extern const AVChannelLayout ff_iamf_scalable_ch_layouts[10];
166166 extern const struct IAMFSoundSystemMap ff_iamf_sound_system_map[13];
167167
168+static inline IAMFParamDefinition *ff_iamf_get_param_definition(const IAMFContext *iamf,
169+ unsigned int parameter_id)
170+{
171+ IAMFParamDefinition *param_definition = NULL;
172+
173+ for (int i = 0; i < iamf->nb_param_definitions; i++)
174+ if (iamf->param_definitions[i]->param->parameter_id == parameter_id) {
175+ param_definition = iamf->param_definitions[i];
176+ break;
177+ }
178+
179+ return param_definition;
180+}
181+
168182 void ff_iamf_free_audio_element(IAMFAudioElement **paudio_element);
169183 void ff_iamf_free_mix_presentation(IAMFMixPresentation **pmix_presentation);
170184 void ff_iamf_uninit_context(IAMFContext *c);
libavformat/iamf_reader.c+1−17
@@ -98,22 +98,6 @@ static int audio_frame_obu(AVFormatContext *s, const IAMFDemuxContext *c, · 97 unmodified lines
9898 return 0;
9999 }
100100
101−static const IAMFParamDefinition *get_param_definition(AVFormatContext *s,
102− const IAMFDemuxContext *c,
103− unsigned int parameter_id)
104−{
105− const IAMFContext *const iamf = &c->iamf;
106− const IAMFParamDefinition *param_definition = NULL;
107−
108− for (int i = 0; i < iamf->nb_param_definitions; i++)
109− if (iamf->param_definitions[i]->param->parameter_id == parameter_id) {
110− param_definition = iamf->param_definitions[i];
111− break;
112− }
113−
114− return param_definition;
115−}
116−
117101 static int parameter_block_obu(AVFormatContext *s, IAMFDemuxContext *c,
118102 AVIOContext *pbc, int len)
119103 {
@@ -144,7 +128,7 @@ static int parameter_block_obu(AVFormatContext *s, IAMFDemuxContext *c, · 24 unmodified lines
144128 pb = &b.pub;
145129
146130 parameter_id = ffio_read_leb(pb);
147− param_definition = get_param_definition(s, c, parameter_id);
131+ param_definition = ff_iamf_get_param_definition(&c->iamf, parameter_id);
148132 if (!param_definition) {
149133 av_log(s, AV_LOG_VERBOSE, "Non existant parameter_id %d referenced in a parameter block. Ignoring\n",
150134 parameter_id);
libavformat/iamf_writer.h+0−14
@@ -29,20 +29,6 @@ · 28 unmodified lines
2929 #include "avio.h"
3030 #include "iamf.h"
3131
32−static inline IAMFParamDefinition *ff_iamf_get_param_definition(const IAMFContext *iamf,
33− unsigned int parameter_id)
34−{
35− IAMFParamDefinition *param_definition = NULL;
36−
37− for (int i = 0; i < iamf->nb_param_definitions; i++)
38− if (iamf->param_definitions[i]->param->parameter_id == parameter_id) {
39− param_definition = iamf->param_definitions[i];
40− break;
41− }
42−
43− return param_definition;
44−}
45−
4632 int ff_iamf_add_audio_element(IAMFContext *iamf, const AVStreamGroup *stg, void *log_ctx);
4733 int ff_iamf_add_mix_presentation(IAMFContext *iamf, const AVStreamGroup *stg, void *log_ctx);
4834

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t