History

avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer.

James Almer committed 1 year ago

Commit efbcd311 parent 49e52ca1 file · +5 −1Browse files

Unified · Split

libavcodec/ac3_parser.c+5−1
@@ -202,9 +202,13 @@ int av_ac3_parse_header(const uint8_t *buf, size_t size, · 201 unmodified lines
202202 {
203203 GetBitContext gb;
204204 AC3HeaderInfo hdr;
205+ uint8_t tmp[32 + AV_INPUT_BUFFER_PADDING_SIZE];
205206 int err;
206207
207− err = init_get_bits8(&gb, buf, size);
208+ size = FFMIN(32, size);
209+ memcpy(tmp, buf, size);
210+ memset(tmp + size, 0, AV_INPUT_BUFFER_PADDING_SIZE);
211+ err = init_get_bits8(&gb, tmp, size);
208212 if (err < 0)
209213 return AVERROR_INVALIDDATA;
210214 err = ff_ac3_parse_header(&gb, &hdr);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t