History

avcodec/mjpegdec: fix variable shadowing

Marvin Scholz committed 2 years ago

Commit fd4f7d01 parent 3ebc68d2 files · +13 −15Browse files

Showing the changes to libavcodec (2 of 2 files). Show all

Unified · Split

2 files
  1. libavcodec/mjpegdec.c +7 −8
  2. libavcodec/mjpegenc_common.c +6 −7
libavcodec/mjpegdec.c+7−8
@@ -2377,7 +2377,7 @@ int ff_mjpeg_decode_frame_from_buf(AVCodecContext *avctx, AVFrame *frame, · 2376 unmodified lines
23772377 int hshift, vshift;
23782378 int unescaped_buf_size;
23792379 int start_code;
2380− int i, index;
2380+ int index;
23812381 int ret = 0;
23822382 int is16bit;
23832383 AVDictionaryEntry *e = NULL;
@@ -2657,7 +2657,7 @@ the_end: · 273 unmodified lines
26572657 if (s->upscale_v[p] == 1)
26582658 h = (h+1)>>1;
26592659 av_assert0(w > 0);
2660− for (i = 0; i < h; i++) {
2660+ for (int i = 0; i < h; i++) {
26612661 if (s->upscale_h[p] == 1) {
26622662 if (is16bit) ((uint16_t*)line)[w - 1] = ((uint16_t*)line)[(w - 1) / 2];
26632663 else line[w - 1] = line[(w - 1) / 2];
@@ -2735,7 +2735,7 @@ the_end: · 71 unmodified lines
27352735 h = AV_CEIL_RSHIFT(h, vshift);
27362736 }
27372737 dst = &((uint8_t *)s->picture_ptr->data[p])[(h - 1) * s->linesize[p]];
2738− for (i = h - 1; i; i--) {
2738+ for (int i = h - 1; i; i--) {
27392739 uint8_t *src1 = &((uint8_t *)s->picture_ptr->data[p])[i * s->upscale_v[p] / (s->upscale_v[p] + 1) * s->linesize[p]];
27402740 uint8_t *src2 = &((uint8_t *)s->picture_ptr->data[p])[(i + 1) * s->upscale_v[p] / (s->upscale_v[p] + 1) * s->linesize[p]];
27412741 if (s->upscale_v[p] != 2 && (src1 == src2 || i == h - 1)) {
@@ -2777,7 +2777,7 @@ the_end: · 35 unmodified lines
27772777 int w = s->picture_ptr->width;
27782778 int h = s->picture_ptr->height;
27792779 av_assert0(s->nb_components == 4);
2780− for (i=0; i<h; i++) {
2780+ for (int i = 0; i < h; i++) {
27812781 int j;
27822782 uint8_t *dst[4];
27832783 for (index=0; index<4; index++) {
@@ -2800,7 +2800,7 @@ the_end: · 16 unmodified lines
28002800 int w = s->picture_ptr->width;
28012801 int h = s->picture_ptr->height;
28022802 av_assert0(s->nb_components == 4);
2803− for (i=0; i<h; i++) {
2803+ for (int i = 0; i < h; i++) {
28042804 int j;
28052805 uint8_t *dst[4];
28062806 for (index=0; index<4; index++) {
@@ -2833,10 +2833,9 @@ the_end: · 26 unmodified lines
28332833 AVFrameSideData *sd;
28342834 size_t offset = 0;
28352835 int total_size = 0;
2836− int i;
28372836
28382837 /* Sum size of all parts. */
2839− for (i = 0; i < s->iccnum; i++)
2838+ for (int i = 0; i < s->iccnum; i++)
28402839 total_size += s->iccentries[i].length;
28412840
28422841 ret = ff_frame_new_side_data(avctx, frame, AV_FRAME_DATA_ICC_PROFILE, total_size, &sd);
@@ -2847,7 +2846,7 @@ the_end: · 4 unmodified lines
28472846
28482847 if (sd) {
28492848 /* Reassemble the parts, which are now in-order. */
2850− for (i = 0; i < s->iccnum; i++) {
2849+ for (int i = 0; i < s->iccnum; i++) {
28512850 memcpy(sd->data + offset, s->iccentries[i].data, s->iccentries[i].length);
28522851 offset += s->iccentries[i].length;
28532852 }
libavcodec/mjpegenc_common.c+6−7
@@ -39,18 +39,17 @@ · 38 unmodified lines
3939 static int put_huffman_table(PutBitContext *p, int table_class, int table_id,
4040 const uint8_t *bits_table, const uint8_t *value_table)
4141 {
42− int n, i;
42+ int n = 0;
4343
4444 put_bits(p, 4, table_class);
4545 put_bits(p, 4, table_id);
4646
47− n = 0;
48− for(i=1;i<=16;i++) {
47+ for (int i = 1; i <= 16; i++) {
4948 n += bits_table[i];
5049 put_bits(p, 8, bits_table[i]);
5150 }
5251
53− for(i=0;i<n;i++)
52+ for (int i = 0; i < n; i++)
5453 put_bits(p, 8, value_table[i]);
5554
5655 return n + 17;
@@ -63,7 +62,7 @@ static void jpeg_table_header(AVCodecContext *avctx, PutBitContext *p, · 6 unmodified lines
6362 uint16_t chroma_intra_matrix[64],
6463 int hsample[3], int use_slices, int matrices_differ)
6564 {
66− int i, j, size;
65+ int size;
6766 uint8_t *ptr;
6867
6968 if (m) {
@@ -83,8 +82,8 @@ static void jpeg_table_header(AVCodecContext *avctx, PutBitContext *p, · 13 unmodified lines
8382 if (matrix_count > 1) {
8483 put_bits(p, 4, 0); /* 8 bit precision */
8584 put_bits(p, 4, 1); /* table 1 */
86− for(i=0;i<64;i++) {
87− j = intra_matrix_permutation[i];
85+ for (int i = 0; i < 64; i++) {
86+ uint8_t j = intra_matrix_permutation[i];
8887 put_bits(p, 8, chroma_intra_matrix[j]);
8988 }
9089 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t