History

avcodec/takdsp: Fix integer overflows

Fixes: avcodec/takdsp.c:44:23: runtime error: signed integer overflow: -2097158 - 2147012608 cannot be represented in type 'int' Fixes: 58417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-5268919664640000

Michael Niedermayer committed 3 years ago

Commit ff8a4961 parent adfe0031 file · +6 −6Browse files

Unified · Split

libavcodec/takdsp.c+6−6
@@ -28,8 +28,8 @@ static void decorrelate_ls(int32_t *p1, int32_t *p2, int length) · 27 unmodified lines
2828 int i;
2929
3030 for (i = 0; i < length; i++) {
31− int32_t a = p1[i];
32− int32_t b = p2[i];
31+ uint32_t a = p1[i];
32+ uint32_t b = p2[i];
3333 p2[i] = a + b;
3434 }
3535 }
@@ -39,8 +39,8 @@ static void decorrelate_sr(int32_t *p1, int32_t *p2, int length) · 3 unmodified lines
3939 int i;
4040
4141 for (i = 0; i < length; i++) {
42− int32_t a = p1[i];
43− int32_t b = p2[i];
42+ uint32_t a = p1[i];
43+ uint32_t b = p2[i];
4444 p1[i] = b - a;
4545 }
4646 }
@@ -50,7 +50,7 @@ static void decorrelate_sm(int32_t *p1, int32_t *p2, int length) · 3 unmodified lines
5050 int i;
5151
5252 for (i = 0; i < length; i++) {
53− int32_t a = p1[i];
53+ uint32_t a = p1[i];
5454 int32_t b = p2[i];
5555 a -= b >> 1;
5656 p1[i] = a;
@@ -63,7 +63,7 @@ static void decorrelate_sf(int32_t *p1, int32_t *p2, int length, int dshift, int · 6 unmodified lines
6363 int i;
6464
6565 for (i = 0; i < length; i++) {
66− int32_t a = p1[i];
66+ uint32_t a = p1[i];
6767 int32_t b = p2[i];
6868 b = (unsigned)((int)(dfactor * (unsigned)(b >> dshift) + 128) >> 8) << dshift;
6969 p1[i] = b - a;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t