History

TimeSeriesPlatformLibrary: Added default swap order flag to ParseGuid operation based run-time endianness and fixed a logic error in ParseBoolean function.

J. Ritchie Carroll committed 7 years ago

Commit 02880e21 parent dac6f5a2 files · +3 −2Browse files

Unified · Split

2 files
  1. Source/Libraries/TimeSeriesPlatformLibrary/Common/Convert.cpp +1 −1
  2. Source/Libraries/TimeSeriesPlatformLibrary/Common/Convert.h +2 −1
Source/Libraries/TimeSeriesPlatformLibrary/Common/Convert.cpp+1−1
@@ -281,7 +281,7 @@ bool GSF::ParseBoolean(const string& value) · 280 unmodified lines
281281
282282 const string result = Trim(value);
283283
284− if (result.empty())
284+ if (!result.empty())
285285 {
286286 if (IsEqual(result, "true"))
287287 return true;
Source/Libraries/TimeSeriesPlatformLibrary/Common/Convert.h+2−1
@@ -25,6 +25,7 @@ · 24 unmodified lines
2525 #define __COMMON_CONVERT_H
2626
2727 #include "CommonTypes.h"
28+#include "EndianConverter.h"
2829
2930 namespace GSF
3031 {
@@ -77,7 +78,7 @@ namespace GSF · 46 unmodified lines
7778 std::string RegExEncode(char value);
7879
7980 // Converts 16 contiguous bytes of character data into a globally unique identifier
80− Guid ParseGuid(const uint8_t* data, bool swapBytes);
81+ Guid ParseGuid(const uint8_t* data, bool swapBytes = EndianConverter::Default.NativeOrder() == EndianConverter::LittleEndian);
8182 Guid ParseGuid(const char* data);
8283
8384 // Returns a non-empty nor null value

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t