History

TimeSeriesPlatformLibrary: Minor code optimizations and cleanup per PVS-Studio analysis.

J. Ritchie Carroll committed 7 years ago

Commit c36ddbf1 parent 4a5df8a14 files · +391 −93Browse files

Showing the changes to Source/Libraries/TimeSeriesPlatformLibrary/Common/Convert.cpp (1 of 14 files). Show all

Unified · Split

Source/Libraries/TimeSeriesPlatformLibrary/Common/Convert.cpp+4−4
@@ -100,7 +100,7 @@ string PreparseTimestamp(const string& timestamp, time_duration& utcOffset) · 99 unmodified lines
100100 timeParts = Split(timePart, ":", false);
101101
102102 if (timeParts.size() == 2)
103− timeParts.push_back("00");
103+ timeParts.emplace_back("00");
104104
105105 if (timeParts.size() != 3)
106106 return timestamp;
@@ -227,12 +227,12 @@ uint32_t GSF::TicksToString(char* ptr, uint32_t maxsize, string format, int64_t · 120 unmodified lines
227227 return strftime(ptr, maxsize, formatStream.str().data(), &timeinfo);
228228 }
229229
230−std::string GSF::ToString(Guid value)
230+std::string GSF::ToString(const Guid& value)
231231 {
232232 return boost::uuids::to_string(value);
233233 }
234234
235−std::string GSF::ToString(DateTime value, const char* format)
235+std::string GSF::ToString(const DateTime& value, const char* format)
236236 {
237237 using namespace boost::gregorian;
238238
@@ -301,7 +301,7 @@ const char* GSF::Coalesce(const char* data, const char* nonEmptyValue) · 62 unmodified lines
301301 if (data == nullptr)
302302 return nonEmptyValue;
303303
304− if (strlen(data) == 0)
304+ if (data[0] == '\0')
305305 return nonEmptyValue;
306306
307307 return data;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t