History

TimeSeriesPlatformLibrary: Minor code optimizations and cleanup per PVS-Studio analysis.

J. Ritchie Carroll committed 7 years ago

Commit c36ddbf1 parent 4a5df8a14 files · +391 −93Browse files

Showing the changes to Source/Libraries/TimeSeriesPlatformLibrary/Samples (1 of 14 files). Show all

Unified · Split

Source/Libraries/TimeSeriesPlatformLibrary/Samples/FilterExpressionTests.cpp+7−6
@@ -640,17 +640,19 @@ int main(int argc, char* argv[]) · 639 unmodified lines
640640 cout << "Test " << ++test << " succeeded..." << endl;
641641
642642 // Test 36 - validate data load
643+ dataRow = dataSet->Table("DeviceDetail")->Row(0);
644+
643645 assert(IsEqual(
644− dataSet->Table("DeviceDetail")->Row(0)->ValueAsString("Acronym").GetValueOrDefault(),
645− dataSet->Table("DeviceDetail")->Row(0)->ValueAsString("Name").GetValueOrDefault()
646+ dataRow->ValueAsString("Acronym").GetValueOrDefault(),
647+ dataRow->ValueAsString("Name").GetValueOrDefault()
646648 ));
647649
648650 // In test data set, DeviceDetail.OriginalSource is null
649− assert(!dataSet->Table("DeviceDetail")->Row(0)->ValueAsString("OriginalSource").HasValue());
651+ assert(!dataRow->ValueAsString("OriginalSource").HasValue());
650652
651653 // In test data set, DeviceDetail.ParentAcronym is not null, but is an empty string
652− assert(dataSet->Table("DeviceDetail")->Row(0)->ValueAsString("ParentAcronym").HasValue());
653− assert(static_cast<string>(dataSet->Table("DeviceDetail")->Row(0)->ValueAsString("ParentAcronym").Value).empty());
654+ assert(dataRow->ValueAsString("ParentAcronym").HasValue());
655+ assert(static_cast<string>(dataRow->ValueAsString("ParentAcronym").Value).empty());
654656 cout << "Test " << ++test << " succeeded..." << endl;
655657
656658 TableIDFieldsPtr measurementDetailIDFields = NewSharedPtr<TableIDFields>();
@@ -876,7 +878,6 @@ int main(int argc, char* argv[]) · 219 unmodified lines
876878 cout << "Test " << ++test << " succeeded..." << endl;
877879
878880 // Test 74
879− dataRow = dataSet->Table("DeviceDetail")->Row(0);
880881 valueExpression = FilterExpressionParser::Evaluate(dataRow, "AccessID % 2 = 0 AND FramesPerSecond % 4 <> 2 OR AccessID % 1 = 0");
881882
882883 assert(valueExpression->ValueType == ExpressionValueType::Boolean);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t