History

src/src_*.c : Fix a potential memory leak.

Erik de Castro Lopo committed 17 years ago

Commit 94966fc1 parent beed7b14 files · +10 −15Browse files

Unified · Split

4 files
  1. ChangeLog +4 −0
  2. src/src_linear.c +2 −5
  3. src/src_sinc.c +2 −5
  4. src/src_zoh.c +2 −5
ChangeLog+4−0
@@ -4,6 +4,10 @@ · 3 unmodified lines
4 Fix a couple of very minor warnings uncovered by Erik Hovland using a4 Fix a couple of very minor warnings uncovered by Erik Hovland using a
5 static analysis tool.5 static analysis tool.
6 6
7 * src/src_*.c
8 Fix a potential memory leak. Thanks to Peter G. Vavaroutsos for point this
9 out.
10
72008-12-11 Erik de Castro Lopo <erikd AT mega-nerd DOT com>112008-12-11 Erik de Castro Lopo <erikd AT mega-nerd DOT com>
8 12
9 * reconfigure.mk autogen.sh13 * reconfigure.mk autogen.sh
src/src_linear.c+2−5
@@ -174,11 +174,8 @@ linear_set_converter (SRC_PRIVATE *psrc, int src_enum) · 173 unmodified lines
174 return SRC_ERR_BAD_CONVERTER ;174 return SRC_ERR_BAD_CONVERTER ;
175 175
176 if (psrc->private_data != NULL)176 if (psrc->private_data != NULL)
177 { priv = (LINEAR_DATA*) psrc->private_data ;177 { free (psrc->private_data) ;
178 if (priv->linear_magic_marker != LINEAR_MAGIC_MARKER)178 psrc->private_data = NULL ;
179 { free (psrc->private_data) ;
180 psrc->private_data = NULL ;
181 } ;
182 } ;179 } ;
183 180
184 if (psrc->private_data == NULL)181 if (psrc->private_data == NULL)
src/src_sinc.c+2−5
@@ -154,11 +154,8 @@ sinc_set_converter (SRC_PRIVATE *psrc, int src_enum) · 153 unmodified lines
154 return SRC_ERR_SHIFT_BITS ;154 return SRC_ERR_SHIFT_BITS ;
155 155
156 if (psrc->private_data != NULL)156 if (psrc->private_data != NULL)
157 { filter = (SINC_FILTER*) psrc->private_data ;157 { free (psrc->private_data) ;
158 if (filter->sinc_magic_marker != SINC_MAGIC_MARKER)158 psrc->private_data = NULL ;
159 { free (psrc->private_data) ;
160 psrc->private_data = NULL ;
161 } ;
162 } ;159 } ;
163 160
164 memset (&temp_filter, 0, sizeof (temp_filter)) ;161 memset (&temp_filter, 0, sizeof (temp_filter)) ;
src/src_zoh.c+2−5
@@ -165,11 +165,8 @@ zoh_set_converter (SRC_PRIVATE *psrc, int src_enum) · 164 unmodified lines
165 return SRC_ERR_BAD_CONVERTER ;165 return SRC_ERR_BAD_CONVERTER ;
166 166
167 if (psrc->private_data != NULL)167 if (psrc->private_data != NULL)
168 { priv = (ZOH_DATA*) psrc->private_data ;168 { free (psrc->private_data) ;
169 if (priv->zoh_magic_marker != ZOH_MAGIC_MARKER)169 psrc->private_data = NULL ;
170 { free (psrc->private_data) ;
171 psrc->private_data = NULL ;
172 } ;
173 } ;170 } ;
174 171
175 if (psrc->private_data == NULL)172 if (psrc->private_data == NULL)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t