Add --show-program-output option to shell tests.

When used --show-program-output shows the output from the programs run during testing.

Tom Finegan committed 12 years ago

Commit 1d29ce51 parent 66537695 files · +30 −20Browse files

Unified · Split

5 files

test/decode_to_md5.sh +9 −8
test/decode_with_drops.sh +1 −1
test/simple_decoder.sh +1 −1
test/simple_encoder.sh +3 −2
test/tools_common.sh +16 −8

   fi
 }
-# Runs decode_to_md5 on $1 and echoes the MD5 sum for the final frame. $2 is
+# Runs decode_to_md5 on $1 and captures the md5 sum for the final frame. $2 is
-# interpreted as codec name and used solely to name the output file.
+# interpreted as codec name and used solely to name the output file. $3 is the
+# expected md5 sum: It must match that of the final frame.
 decode_to_md5() {
   local decoder="${LIBVPX_BIN_PATH}/decode_to_md5${VPX_TEST_EXE_SUFFIX}"
   local input_file="$1"
   local codec="$2"
+  local expected_md5="$3"
   local output_file="${VPX_TEST_OUTPUT_DIR}/decode_to_md5_${codec}"
   [ -x "${decoder}" ] || return 1
-  "${decoder}" "${input_file}" "${output_file}" > /dev/null 2>&1
+  eval "${decoder}" "${input_file}" "${output_file}" ${devnull}
   [ -e "${output_file}" ] || return 1
   local md5_last_frame=$(tail -n1 "${output_file}")
-  echo "${md5_last_frame% *}" | tr -d [:space:]
+  local actual_md5=$(echo "${md5_last_frame% *}" | tr -d [:space:])
+  [ "${actual_md5}" = "${expected_md5}" ] || return 1
 }
 decode_to_md5_vp8() {
   local expected_md5="56794d911b02190212bca92f88ad60c6"
   if [ "$(vp8_decode_available)" = "yes" ]; then
-    local actual_md5="$(decode_to_md5 "${VP8_IVF_FILE}" vp8)" || return 1
+    decode_to_md5 "${VP8_IVF_FILE}" "vp8" "${expected_md5}"
-    [ "${actual_md5}" = "${expected_md5}" ] || return 1
   fi
 }
   local expected_md5="2952c0eae93f3dadd1aa84c50d3fd6d2"
   if [ "$(vp9_decode_available)" = "yes" ]; then
-    local actual_md5="$(decode_to_md5 "${VP9_IVF_FILE}" vp9)" || return 1
+    decode_to_md5 "${VP9_IVF_FILE}" "vp9" "${expected_md5}"
-    [ "${actual_md5}" = "${expected_md5}" ] || return 1
   fi
 }

test/decode_with_drops.sh+1−1

@@ -36,7 +36,7 @@ decode_with_drops() { · 35 unmodified lines
36		36
37	[ -x "${decoder}" ] \|\| return 1	37	[ -x "${decoder}" ] \|\| return 1
38		38
39	"${decoder}" "${input_file}" "${output_file}" "${drop_mode}" > /dev/null 2>&1	39	eval "${decoder}" "${input_file}" "${output_file}" "${drop_mode}" ${devnull}
40		40
41	[ -e "${output_file}" ] \|\| return 1	41	[ -e "${output_file}" ] \|\| return 1
42	}	42	}

test/simple_decoder.sh+1−1

@@ -34,7 +34,7 @@ simple_decoder() { · 33 unmodified lines
34		34
35	[ -x "${decoder}" ] \|\| return 1	35	[ -x "${decoder}" ] \|\| return 1
36		36
37	"${decoder}" "${input_file}" "${output_file}" > /dev/null 2>&1	37	eval "${decoder}" "${input_file}" "${output_file}" ${devnull}
38		38
39	[ -e "${output_file}" ] \|\| return 1	39	[ -e "${output_file}" ] \|\| return 1
40	}	40	}

test/simple_encoder.sh+3−2

@@ -31,8 +31,9 @@ simple_encoder() { · 30 unmodified lines
31		31
32	[ -x "${encoder}" ] \|\| return 1	32	[ -x "${encoder}" ] \|\| return 1
33		33
34	"${encoder}" "${codec}" "${YUV_RAW_INPUT_WIDTH}" "${YUV_RAW_INPUT_HEIGHT}" \	34	eval "${encoder}" "${codec}" "${YUV_RAW_INPUT_WIDTH}" \
35	"${YUV_RAW_INPUT}" "${output_file}" 9999 > /dev/null 2>&1	35	"${YUV_RAW_INPUT_HEIGHT}" "${YUV_RAW_INPUT}" "${output_file}" 9999 \
		36	${devnull}
36		37
37	[ -e "${output_file}" ] \|\| return 1	38	[ -e "${output_file}" ] \|\| return 1
38	}	39	}

test/tools_common.sh+16−8

 VPX_TEST_TOOLS_COMMON_SH=included
 set -e
+devnull='> /dev/null 2>&1'
 vlog() {
   [ "${VPX_TEST_VERBOSE_OUTPUT}" = "yes" ] && echo "$@"
   local decoder="${LIBVPX_BIN_PATH}/vpxdec${VPX_TEST_EXE_SUFFIX}"
   if [ -z "${pipe_input}" ]; then
-    "${decoder}" "$input" --summary --noblit "$@" > /dev/null 2>&1
+    eval "${decoder}" "$input" --summary --noblit "$@" ${devnull}
   else
-    cat "${input}" | "${decoder}" - --summary --noblit "$@" > /dev/null 2>&1
+    cat "${input}" | eval "${decoder}" - --summary --noblit "$@" ${devnull}
   fi
 }
   fi
   if [ -z "${pipe_input}" ]; then
-    "${encoder}" --codec=${codec} --width=${width} --height=${height} \
+    eval "${encoder}" --codec=${codec} --width=${width} --height=${height} \
         --limit=${frames} ${use_ivf} ${extra_flags} --output="${output}" \
-        "${input}" > /dev/null 2>&1
+        "${input}" \
+        ${devnull}
   else
     cat "${input}" \
-        | "${encoder}" --codec=${codec} --width=${width} --height=${height} \
+        | eval "${encoder}" --codec=${codec} --width=${width} \
-            --limit=${frames} ${use_ivf} ${extra_flags} --output="${output}" - \
+              --height=${height} --limit=${frames} ${use_ivf} ${extra_flags} \
-            > /dev/null 2>&1
+              --output="${output}" - \
+              ${devnull}
   fi
   if [ ! -e "${output}" ]; then
     --run-disabled-tests: Run disabled tests.
     --help: Display this message and exit.
     --test-data-path <path to libvpx test data directory>
+    --show-program-output: Shows output from all programs being tested.
     --verbose: Verbose output.
     When the --bin-path option is not specified the script attempts to use
     --verbose)
       VPX_TEST_VERBOSE_OUTPUT=yes
       ;;
+    --show-program-output)
+      devnull=
+      ;;
     *)
       vpx_test_usage
       exit 1
   VPX_TEST_OUTPUT_DIR=${VPX_TEST_OUTPUT_DIR}
   VPX_TEST_VERBOSE_OUTPUT=${VPX_TEST_VERBOSE_OUTPUT}
   VPX_TEST_FILTER=${VPX_TEST_FILTER}
-  VPX_TEST_RUN_DISABLED_TESTS=${VPX_TEST_RUN_DISABLED_TESTS}"
+  VPX_TEST_RUN_DISABLED_TESTS=${VPX_TEST_RUN_DISABLED_TESTS}
+  VPX_TEST_SHOW_PROGRAM_OUTPUT=${VPX_TEST_SHOW_PROGRAM_OUTPUT}"
 fi  # End $VPX_TEST_TOOLS_COMMON_SH pseudo include guard.

Add --show-program-output option to shell tests.

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code