History

Return status in vp9_extrc_send_firstpass_stats

Bug: webm:1716

Angie Chiang committed 5 years ago

Commit 27f18381 parent f4fc5622 files · +14 −6Browse files

Unified · Split

2 files
  1. vp9/encoder/vp9_ext_ratectrl.c +12 −4
  2. vp9/encoder/vp9_ext_ratectrl.h +2 −2
vp9/encoder/vp9_ext_ratectrl.c+12−4
@@ -94,9 +94,13 @@ static void gen_rc_firstpass_stats(const FIRSTPASS_STATS *stats, · 93 unmodified lines
9494 rc_frame_stats->count = stats->count;
9595 }
9696
97−void vp9_extrc_send_firstpass_stats(EXT_RATECTRL *ext_ratectrl,
98− const FIRST_PASS_INFO *first_pass_info) {
97+vpx_codec_err_t vp9_extrc_send_firstpass_stats(
98+ EXT_RATECTRL *ext_ratectrl, const FIRST_PASS_INFO *first_pass_info) {
99+ if (ext_ratectrl == NULL) {
100+ return VPX_CODEC_ERROR;
101+ }
99102 if (ext_ratectrl->ready) {
103+ vpx_rc_status_t rc_status;
100104 vpx_rc_firstpass_stats_t *rc_firstpass_stats =
101105 &ext_ratectrl->rc_firstpass_stats;
102106 int i;
@@ -105,9 +109,13 @@ void vp9_extrc_send_firstpass_stats(EXT_RATECTRL *ext_ratectrl, · 2 unmodified lines
105109 gen_rc_firstpass_stats(&first_pass_info->stats[i],
106110 &rc_firstpass_stats->frame_stats[i]);
107111 }
108− ext_ratectrl->funcs.send_firstpass_stats(ext_ratectrl->model,
109− rc_firstpass_stats);
112+ rc_status = ext_ratectrl->funcs.send_firstpass_stats(ext_ratectrl->model,
113+ rc_firstpass_stats);
114+ if (rc_status == VPX_RC_ERROR) {
115+ return VPX_CODEC_ERROR;
116+ }
110117 }
118+ return VPX_CODEC_OK;
111119 }
112120
113121 static int extrc_get_frame_type(FRAME_UPDATE_TYPE update_type) {
vp9/encoder/vp9_ext_ratectrl.h+2−2
@@ -30,8 +30,8 @@ vpx_codec_err_t vp9_extrc_create(vpx_rc_funcs_t funcs, · 29 unmodified lines
3030
3131 vpx_codec_err_t vp9_extrc_delete(EXT_RATECTRL *ext_ratectrl);
3232
33−void vp9_extrc_send_firstpass_stats(EXT_RATECTRL *ext_ratectrl,
34− const FIRST_PASS_INFO *first_pass_info);
33+vpx_codec_err_t vp9_extrc_send_firstpass_stats(
34+ EXT_RATECTRL *ext_ratectrl, const FIRST_PASS_INFO *first_pass_info);
3535
3636 void vp9_extrc_get_encodeframe_decision(
3737 EXT_RATECTRL *ext_ratectrl, int show_index, int coding_index, int gop_index,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t