History

googletest: enable failure on uninstantiated tests

Similar to the change in https://aomedia-review.googlesource.com/c/aom/+/115162. This currently is a warning, but the tree should be clean now in the default x86-64 configuration so we can use it to prevent regressions and find any remaining issues in other configurations. BUG=b/159031844

Sarah Parker committed 6 years ago

Commit 478c70f1 parent ea0bc1b2 files · +4 −2Browse files

Unified · Split

2 files
  1. third_party/googletest/README.libvpx +2 −0
  2. third_party/googletest/src/src/gtest.cc +2 −2
third_party/googletest/README.libvpx+2−0
@@ -19,3 +19,5 @@ Local Modifications: · 18 unmodified lines
1919 LICENSE
2020 README.md
2121 src
22+- Enable kErrorOnUninstantiatedParameterizedTest and
23+ kErrorOnUninstantiatedTypeParameterizedTest in gtest.cc
third_party/googletest/src/src/gtest.cc+2−2
@@ -414,8 +414,8 @@ namespace { · 413 unmodified lines
414414 // inserted to report ether an error or a log message.
415415 //
416416 // This configuration bit will likely be removed at some point.
417−constexpr bool kErrorOnUninstantiatedParameterizedTest = false;
418−constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = false;
417+constexpr bool kErrorOnUninstantiatedParameterizedTest = true;
418+constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = true;
419419
420420 // A test that fails at a given file/line location with a given message.
421421 class FailureTest : public Test {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t