History

Add custom secret names for Docker (#5355)

Paul Trunk committed 8 years ago

Commit bd9cdcf1 parent 7c72d145 files · +24 −7Browse files

Unified · Split

5 files
  1. Dockerfile +2 −0
  2. Dockerfile.dev +2 −0
  3. Dockerfile.release +2 −0
  4. dockerscripts/docker-entrypoint.sh +7 −7
  5. docs/docker/README.md +11 −0
Dockerfile+2−0
@@ -6,6 +6,8 @@ ENV GOPATH /go · 5 unmodified lines
66 ENV PATH $PATH:$GOPATH/bin
77 ENV CGO_ENABLED 0
88 ENV MINIO_UPDATE off
9+ENV MINIO_ACCESS_KEY_FILE=access_key \
10+ MINIO_SECRET_KEY_FILE=secret_key
911
1012 WORKDIR /go/src/github.com/minio/
1113
Dockerfile.dev+2−0
@@ -6,6 +6,8 @@ ENV GOPATH /go · 5 unmodified lines
66 ENV PATH $PATH:$GOPATH/bin
77 ENV CGO_ENABLED 0
88 ENV MINIO_UPDATE off
9+ENV MINIO_ACCESS_KEY_FILE=access_key \
10+ MINIO_SECRET_KEY_FILE=secret_key
911
1012 WORKDIR /go/src/github.com/minio/
1113
Dockerfile.release+2−0
@@ -5,6 +5,8 @@ MAINTAINER Minio Inc <dev@minio.io> · 4 unmodified lines
55 COPY dockerscripts/docker-entrypoint.sh dockerscripts/healthcheck.sh /usr/bin/
66
77 ENV MINIO_UPDATE off
8+ENV MINIO_ACCESS_KEY_FILE=access_key \
9+ MINIO_SECRET_KEY_FILE=secret_key
810
911 RUN \
1012 apk add --no-cache ca-certificates && \
dockerscripts/docker-entrypoint.sh+7−7
@@ -24,15 +24,15 @@ fi · 23 unmodified lines
2424
2525 ## Look for docker secrets in default documented location.
2626 docker_secrets_env() {
27− local MINIO_ACCESS_KEY_FILE="/run/secrets/access_key"
28− local MINIO_SECRET_KEY_FILE="/run/secrets/secret_key"
27+ local ACCESS_KEY_FILE="/run/secrets/$MINIO_ACCESS_KEY_FILE"
28+ local SECRET_KEY_FILE="/run/secrets/$MINIO_SECRET_KEY_FILE"
2929
30− if [ -f $MINIO_ACCESS_KEY_FILE -a -f $MINIO_SECRET_KEY_FILE ]; then
31− if [ -f $MINIO_ACCESS_KEY_FILE ]; then
32− export MINIO_ACCESS_KEY="$(cat "$MINIO_ACCESS_KEY_FILE")"
30+ if [ -f $ACCESS_KEY_FILE -a -f $SECRET_KEY_FILE ]; then
31+ if [ -f $ACCESS_KEY_FILE ]; then
32+ export MINIO_ACCESS_KEY="$(cat "$ACCESS_KEY_FILE")"
3333 fi
34− if [ -f $MINIO_SECRET_KEY_FILE ]; then
35− export MINIO_SECRET_KEY="$(cat "$MINIO_SECRET_KEY_FILE")"
34+ if [ -f $SECRET_KEY_FILE ]; then
35+ export MINIO_SECRET_KEY="$(cat "$SECRET_KEY_FILE")"
3636 fi
3737 fi
3838 }
docs/docker/README.md+11−0
@@ -73,6 +73,17 @@ docker service create --name="minio-service" --secret="access_key" --secret="sec · 72 unmodified lines
7373
7474 Read more about `docker service` [here](https://docs.docker.com/engine/swarm/how-swarm-mode-works/services/)
7575
76+#### Minio Custom Access and Secret Key files
77+To use other secret names follow the instuctions above and replace `access_key` and `secret_key` with your custom names (e.g. `my_secret_key`,`my_custom_key`). Run your service with
78+```
79+docker service create --name="minio-service" \
80+ --secret="my_access_key" \
81+ --secret="my_secret_key" \
82+ --env="MINIO_ACCESS_KEY_FILE=my_access_key" \
83+ --env="MINIO_SECRET_KEY_FILE=my_secret_key" \
84+ minio/minio server /data
85+```
86+
7687 ### Retrieving Container ID
7788 To use Docker commands on a specific container, you need to know the `Container ID` for that container. To get the `Container ID`, run
7889

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t