History

use acceptedResponseStatusCode everywhere in HTTP logger (#13755)

Harshavardhana committed 4 years ago

Commit fee3f881 parent 932500e2 files · +6 −3Browse files

Unified · Split

2 files
  1. buildscripts/minio-upgrade.sh +5 −2
  2. internal/logger/target/http/http.go +1 −1
buildscripts/minio-upgrade.sh+5−2
@@ -37,8 +37,11 @@ verify_checksum_mc() { · 36 unmodified lines
3737 }
3838
3939 add_alias() {
40− until (mc alias set minio http://127.0.0.1:9000 minioadmin minioadmin); do
41− echo "...waiting... for 5secs" && sleep 5
40+ for i in $(seq 1 4); do
41+ echo "... attempting to add alias $i"
42+ until (mc alias set minio http://127.0.0.1:9000 minioadmin minioadmin); do
43+ echo "...waiting... for 5secs" && sleep 5
44+ done
4245 done
4346 }
4447
internal/logger/target/http/http.go+1−1
@@ -157,7 +157,7 @@ func (h *Target) startHTTPLogger() { · 156 unmodified lines
157157 // Drain any response.
158158 xhttp.DrainBody(resp.Body)
159159
160− if resp.StatusCode != http.StatusOK {
160+ if !acceptedResponseStatusCode(resp.StatusCode) {
161161 switch resp.StatusCode {
162162 case http.StatusForbidden:
163163 h.config.LogOnce(ctx, fmt.Errorf("%s returned '%s', please check if your auth token is correctly set", h.config.Endpoint, resp.Status), h.config.Endpoint)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t