History

fix gcc warnings

lieff committed 8 years ago

Commit 473c5fd1 parent 9ac33df3 files · +9 −7Browse files

Unified · Split

3 files
  1. minimp3.h +2 −2
  2. minimp3_test.c +6 −4
  3. scripts/build.sh +1 −1
minimp3.h+2−2
@@ -738,7 +738,7 @@ static void L3_huffman(float *dst, bs_t *bs, const L3_gr_info_t *gr_info, const · 737 unmodified lines
738738 #define CHECK_BITS while (bs_sh >= 0) { bs_cache |= (uint32_t)*bs_next_ptr++ << bs_sh; bs_sh -= 8; }
739739 #define BSPOS ((bs_next_ptr - bs->buf)*8 - 24 + bs_sh)
740740
741− float one;
741+ float one = 0.0f;
742742 int ireg = 0, big_val_cnt = gr_info->big_values;
743743 const uint8_t *sfb = gr_info->sfbtab;
744744 const uint8_t *bs_next_ptr = bs->buf + bs->pos/8;
@@ -806,7 +806,7 @@ static void L3_huffman(float *dst, bs_t *bs, const L3_gr_info_t *gr_info, const · 61 unmodified lines
806806 break;
807807 }
808808 #define RELOAD_SCALEFACTOR if (!--np) {np = *sfb++/2; if (!np) break; one = *scf++;}
809−#define DEQ_COUNT1(s) if (leaf & (128 >> s)) {dst[s] = ((int32_t)bs_cache < 0)?-one:one; FLUSH_BITS(1)}
809+#define DEQ_COUNT1(s) if (leaf & (128 >> s)) {dst[s] = ((int32_t)bs_cache < 0) ? -one : one; FLUSH_BITS(1)}
810810 RELOAD_SCALEFACTOR;
811811 DEQ_COUNT1(0);
812812 DEQ_COUNT1(1);
minimp3_test.c+6−4
@@ -3,7 +3,7 @@ · 2 unmodified lines
33 #include <stdio.h>
44 #include <math.h>
55
6−static char *wav_header(int hz, int ch, int bips, int data_bytes)
6+/*static char *wav_header(int hz, int ch, int bips, int data_bytes)
77 {
88 static char hdr[44] = "RIFFsizeWAVEfmt \x10\0\0\0\1\0ch_hz_abpsbabsdatasize";
99 unsigned long nAvgBytesPerSec = bips*ch*hz >> 3;
@@ -18,13 +18,13 @@ static char *wav_header(int hz, int ch, int bips, int data_bytes) · 8 unmodified lines
1818 *(short *)(hdr + 0x22) = bips;
1919 *(int * )(hdr + 0x28) = data_bytes;
2020 return hdr;
21−}
21+}*/
2222
2323 static void decode_file(FILE *file_mp3, FILE *file_ref, FILE *file_out)
2424 {
2525 static mp3dec_t mp3d = { 0, };
2626 mp3dec_frame_info_t info;
27− int i, data_bytes, samples, total_samples = 0, nbuf = 0, maxdiff = 0;
27+ int i, /*data_bytes, */samples, total_samples = 0, nbuf = 0, maxdiff = 0;
2828 double MSE = 0.0, psnr;
2929 unsigned char buf[4096];
3030
@@ -39,7 +39,9 @@ static void decode_file(FILE *file_mp3, FILE *file_ref, FILE *file_out) · 8 unmodified lines
3939 samples = mp3dec_decode_frame(&mp3d, buf, nbuf, pcm, &info);
4040 if (samples)
4141 {
42− fread(pcm2, 1, 2*info.channels*samples, file_ref);
42+ int readed = fread(pcm2, 1, 2*info.channels*samples, file_ref);
43+ if (readed < 0)
44+ exit(1);
4345 total_samples += samples*info.channels;
4446 for (i = 0; i < samples*info.channels; i++)
4547 {
scripts/build.sh+1−1
@@ -11,7 +11,7 @@ if [ ! -d "fate-suite.ffmpeg.org" ]; then · 10 unmodified lines
1111 cp vectors/l3-he_mode16.pcm fate-suite.ffmpeg.org/mp3-conformance/he_mode.pcm
1212 fi
1313
14−gcc -O2 -g -o minimp3 minimp3_test.c -lm
14+gcc -O2 -g -Wall -Wextra -o minimp3 minimp3_test.c -lm
1515
1616 APP=./minimp3
1717

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t