Previously, it just silently didn't do anything which is not very intuitive. Since the lua api returns an error string, check to see if it matches the "property not found" case and print an error message. Additionally, don't add the fake property to the internal cached_properties list or try to observe it. This avoids redundant evaluate calls which will never actually succeed. We do still mark it under watched_properties however. This avoids having to call mp.get_property_native multiple times.
Showing the changes to player/lua/auto_profiles.lua (1 of 1 file). Show all
Unified · Split
| @@ -87,8 +87,13 @@ function get(name, default) · 86 unmodified lines | ||
| 87 | 87 | -- Normally, we use the cached value only |
| 88 | 88 | if not watched_properties[name] then |
| 89 | 89 | watched_properties[name] = true |
| 90 | + local res, err = mp.get_property_native(name) | |
| 91 | + if err == "property not found" then | |
| 92 | + msg.error("Property '" .. name .. "' was not found.") | |
| 93 | + return default | |
| 94 | + end | |
| 95 | + cached_properties[name] = res | |
| 90 | 96 | mp.observe_property(name, "native", on_property_change) |
| 91 | − cached_properties[name] = mp.get_property_native(name) | |
| 92 | 97 | end |
| 93 | 98 | -- The first time the property is read we need add it to the |
| 94 | 99 | -- properties_to_profiles table, which will be used to mark the profile |