vo: change draw_frame API to a boolean

x11 and wayland VOs + backends all have logic that skips drawing frames when the mpv isn't visible for efficiency reasons. This is implemented in each individual VO, but it is useful for the core to be aware of this as well. Currently, the display-sync modes on x11 do not try to be efficient and always render anyways because there is no blocking on the graphics API level if you skip rendering a frame (wayland works here by accident). This means mpv would otherwise blaze through frames which is not what anyone wants. We can instead improve this by implementing the blocking mechanism in the core and using that when appropriate. This commit does not implement that yet, but simply switches the draw_frame to a boolean. Receiving false means that the VO is not drawing frames and it should be treated as if the surface was hidden.

Dudemanguy committed 1 year ago

Commit 91c1b651 parent 753e20621 files · +93 −43Browse files

Unified · Split

21 files

video/out/vo.h +5 −1
video/out/vo_caca.c +5 −2
video/out/vo_direct3d.c +7 −4
video/out/vo_dmabuf_wayland.c +4 −2
video/out/vo_drm.c +5 −2
video/out/vo_gpu.c +5 −3
video/out/vo_gpu_next.c +3 −2
video/out/vo_image.c +5 −2
video/out/vo_kitty.c +5 −2
video/out/vo_lavc.c +6 −3
video/out/vo_libmpv.c +2 −1
video/out/vo_mediacodec_embed.c +2 −1
video/out/vo_null.c +2 −1
video/out/vo_sdl.c +5 −2
video/out/vo_sixel.c +6 −3
video/out/vo_tct.c +5 −2
video/out/vo_vaapi.c +5 −2
video/out/vo_vdpau.c +2 −1
video/out/vo_wlshm.c +6 −3
video/out/vo_x11.c +4 −2
video/out/vo_xv.c +4 −2

video/out/vo.h+5−1

@@ -407,8 +407,12 @@ struct vo_driver { · 406 unmodified lines
407	407	* frame is freed by the caller if the callee did not assume ownership
408	408	* of the frames, but in any case the callee can still modify the
409	409	* contained data and references.
	410	+ *
	411	+ * Return false to signal to the core that rendering is being skipped for
	412	+ * this particular frame. vo.c will sleep for the expected duration of that
	413	+ * frame before advancing forward.
410	414	*/
411		− void (draw_frame)(struct vo vo, struct vo_frame *frame);
	415	+ bool (draw_frame)(struct vo vo, struct vo_frame *frame);
412	416
413	417	/*
414	418	* Blit/Flip buffer to the screen. Must be called after each frame!

video/out/vo_caca.c+5−2

@@ -111,15 +111,18 @@ static int reconfig(struct vo vo, struct mp_image_params params) · 110 unmodified lines
111	111	return resize(vo);
112	112	}
113	113
114		−static void draw_frame(struct vo vo, struct vo_frame frame)
	114	+static bool draw_frame(struct vo vo, struct vo_frame frame)
115	115	{
116	116	struct priv *priv = vo->priv;
117	117	struct mp_image *mpi = frame->current;
118	118	if (!mpi)
119		− return;
	119	+ goto done;
120	120	memcpy_pic(priv->dither_buffer, mpi->planes[0], priv->image_width * depth, priv->image_height,
121	121	priv->image_width * depth, mpi->stride[0]);
122	122	caca_dither_bitmap(priv->canvas, 0, 0, priv->screen_w, priv->screen_h, priv->dither, priv->dither_buffer);
	123	+
	124	+done:
	125	+ return VO_TRUE;
123	126	}
124	127
125	128	static void flip_page(struct vo *vo)

video/out/vo_direct3d.c+7−4

@@ -1003,18 +1003,18 @@ static bool get_video_buffer(d3d_priv priv, struct mp_image out) · 1002 unmodified lines
1003	1003	return true;
1004	1004	}
1005	1005
1006		−static void draw_frame(struct vo vo, struct vo_frame frame)
	1006	+static bool draw_frame(struct vo vo, struct vo_frame frame)
1007	1007	{
1008	1008	d3d_priv *priv = vo->priv;
1009	1009	if (!priv->d3d_device)
1010		− return;
	1010	+ goto done;
1011	1011
1012	1012	struct mp_image buffer;
1013	1013	if (!get_video_buffer(priv, &buffer))
1014		− return;
	1014	+ goto done;
1015	1015
1016	1016	if (!frame->current)
1017		− return;
	1017	+ goto done;
1018	1018
1019	1019	mp_image_copy(&buffer, frame->current);
1020	1020
@@ -1024,6 +1024,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 3 unmodified lines
1024	1024	priv->osd_pts = frame->current->pts;
1025	1025
1026	1026	d3d_draw_frame(priv);
	1027	+
	1028	+done:
	1029	+ return VO_TRUE;
1027	1030	}
1028	1031
1029	1032	static mp_image_t get_window_screenshot(d3d_priv priv)

video/out/vo_dmabuf_wayland.c+4−2

@@ -592,7 +592,7 @@ done: · 591 unmodified lines
592	592	return draw;
593	593	}
594	594
595		−static void draw_frame(struct vo vo, struct vo_frame frame)
	595	+static bool draw_frame(struct vo vo, struct vo_frame frame)
596	596	{
597	597	struct priv *p = vo->priv;
598	598	struct vo_wayland_state *wl = vo->wl;
@@ -603,7 +603,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 4 unmodified lines
603	603	if (!vo_wayland_check_visible(vo)) {
604	604	if (frame->current)
605	605	talloc_free(frame);
606		− return;
	606	+ return VO_FALSE;
607	607	}
608	608
609	609	if (p->destroy_buffers)
@@ -641,6 +641,8 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 31 unmodified lines
641	641	p->osd_surface_is_mapped = false;
642	642	}
643	643	}
	644	+
	645	+ return VO_TRUE;
644	646	}
645	647
646	648	static void flip_page(struct vo *vo)

video/out/vo_drm.c+5−2

@@ -300,13 +300,13 @@ static void swapchain_step(struct vo *vo) · 299 unmodified lines
300	300	}
301	301	}
302	302
303		−static void draw_frame(struct vo vo, struct vo_frame frame)
	303	+static bool draw_frame(struct vo vo, struct vo_frame frame)
304	304	{
305	305	struct vo_drm_state *drm = vo->drm;
306	306	struct priv *p = vo->priv;
307	307
308	308	if (!drm->active)
309		− return;
	309	+ goto done;
310	310
311	311	drm->still = frame->still;
312	312
@@ -319,6 +319,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 6 unmodified lines
319	319	}
320	320
321	321	enqueue_frame(vo, fb);
	322	+
	323	+done:
	324	+ return VO_TRUE;
322	325	}
323	326
324	327	static void queue_flip(struct vo vo, struct drm_frame frame)

video/out/vo_gpu.c+5−3

@@ -70,25 +70,27 @@ static void resize(struct vo *vo) · 69 unmodified lines
70	70	vo->want_redraw = true;
71	71	}
72	72
73		−static void draw_frame(struct vo vo, struct vo_frame frame)
	73	+static bool draw_frame(struct vo vo, struct vo_frame frame)
74	74	{
75	75	struct gpu_priv *p = vo->priv;
76	76	struct ra_swapchain *sw = p->ctx->swapchain;
77	77
78	78	struct ra_fbo fbo;
79	79	if (!sw->fns->start_frame(sw, &fbo))
80		− return;
	80	+ return VO_FALSE;
81	81
82	82	gl_video_render_frame(p->renderer, frame, &fbo, RENDER_FRAME_DEF);
83	83	if (!sw->fns->submit_frame(sw, frame)) {
84	84	MP_ERR(vo, "Failed presenting frame!\n");
85		− return;
	85	+ return VO_FALSE;
86	86	}
87	87
88	88	struct mp_image_params *params = gl_video_get_target_params_ptr(p->renderer);
89	89	mp_mutex_lock(&vo->params_mutex);
90	90	vo->target_params = params;
91	91	mp_mutex_unlock(&vo->params_mutex);
	92	+
	93	+ return VO_TRUE;
92	94	}
93	95
94	96	static void flip_page(struct vo *vo)

video/out/vo_gpu_next.c+3−2

@@ -904,7 +904,7 @@ static void update_tm_viz(struct pl_color_map_params *params, · 903 unmodified lines
904	904	static void update_hook_opts_dynamic(struct priv p, const struct pl_hook hook,
905	905	const struct mp_image *mpi);
906	906
907		−static void draw_frame(struct vo vo, struct vo_frame frame)
	907	+static bool draw_frame(struct vo vo, struct vo_frame frame)
908	908	{
909	909	struct priv *p = vo->priv;
910	910	pl_options pars = p->pars;
@@ -1029,7 +1029,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 118 unmodified lines
1029	1029	#endif
1030	1030	pl_queue_update(p->queue, NULL, &qparams);
1031	1031	}
1032		− return;
	1032	+ return VO_FALSE;
1033	1033	}
1034	1034
1035	1035	bool valid = false;
@@ -1173,6 +1173,7 @@ done: · 137 unmodified lines
1173	1173
1174	1174	pl_gpu_flush(gpu);
1175	1175	p->frame_pending = true;
	1176	+ return VO_TRUE;
1176	1177	}
1177	1178
1178	1179	static void flip_page(struct vo *vo)

video/out/vo_image.c+5−2

@@ -90,16 +90,19 @@ static int reconfig(struct vo vo, struct mp_image_params params) · 89 unmodified lines
90	90	return 0;
91	91	}
92	92
93		−static void draw_frame(struct vo vo, struct vo_frame frame)
	93	+static bool draw_frame(struct vo vo, struct vo_frame frame)
94	94	{
95	95	struct priv *p = vo->priv;
96	96	if (!frame->current)
97		− return;
	97	+ goto done;
98	98
99	99	p->current = frame->current;
100	100
101	101	struct mp_osd_res dim = osd_res_from_image_params(vo->params);
102	102	osd_draw_on_image(vo->osd, dim, frame->current->pts, OSD_DRAW_SUB_ONLY, p->current);
	103	+
	104	+done:
	105	+ return VO_TRUE;
103	106	}
104	107
105	108	static void flip_page(struct vo *vo)

video/out/vo_kitty.c+5−2

@@ -239,7 +239,7 @@ static int create_shm(struct vo *vo) · 238 unmodified lines
239	239	#endif
240	240	}
241	241
242		−static void draw_frame(struct vo vo, struct vo_frame frame)
	242	+static bool draw_frame(struct vo vo, struct vo_frame frame)
243	243	{
244	244	struct priv *p = vo->priv;
245	245	mp_image_t *mpi = NULL;
@@ -273,7 +273,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 27 unmodified lines
273	273
274	274
275	275	if (p->opts.use_shm && !create_shm(vo))
276		− return;
	276	+ goto done;
277	277
278	278	memcpy_pic(p->buffer, p->frame->planes[0], p->width * BYTES_PER_PX,
279	279	p->height, p->width * BYTES_PER_PX, p->frame->stride[0]);
@@ -282,6 +282,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 2 unmodified lines
282	282	av_base64_encode(p->output, p->output_size, p->buffer, p->buffer_size);
283	283
284	284	talloc_free(mpi);
	285	+
	286	+done:
	287	+ return VO_TRUE;
285	288	}
286	289
287	290	static void flip_page(struct vo *vo)

video/out/vo_lavc.c+6−3

@@ -182,7 +182,7 @@ static int query_format(struct vo *vo, int format) · 181 unmodified lines
182	182	return 0;
183	183	}
184	184
185		−static void draw_frame(struct vo vo, struct vo_frame voframe)
	185	+static bool draw_frame(struct vo vo, struct vo_frame voframe)
186	186	{
187	187	struct priv *vc = vo->priv;
188	188	struct encoder_context *enc = vc->enc;
@@ -190,7 +190,7 @@ static void draw_frame(struct vo vo, struct vo_frame voframe) · 1 unmodified line
190	190	AVCodecContext *avc = enc->encoder;
191	191
192	192	if (voframe->redraw \|\| voframe->repeat \|\| voframe->num_frames < 1)
193		− return;
	193	+ goto done;
194	194
195	195	struct mp_image *mpi = voframe->frames[0];
196	196
@@ -198,7 +198,7 @@ static void draw_frame(struct vo vo, struct vo_frame voframe) · 1 unmodified line
198	198	osd_draw_on_image(vo->osd, dim, mpi->pts, OSD_DRAW_SUB_ONLY, mpi);
199	199
200	200	if (vc->shutdown)
201		− return;
	201	+ goto done;
202	202
203	203	// Lock for shared timestamp fields.
204	204	mp_mutex_lock(&ectx->lock);
@@ -241,6 +241,9 @@ static void draw_frame(struct vo vo, struct vo_frame voframe) · 36 unmodified lines
241	241	frame->quality = avc->global_quality;
242	242	encoder_encode(enc, frame);
243	243	av_frame_free(&frame);
	244	+
	245	+done:
	246	+ return VO_TRUE;
244	247	}
245	248
246	249	static void flip_page(struct vo *vo)

video/out/vo_libmpv.c+2−1

@@ -485,7 +485,7 @@ int mpv_render_context_get_info(mpv_render_context *ctx, · 484 unmodified lines
485	485	return res;
486	486	}
487	487
488		−static void draw_frame(struct vo vo, struct vo_frame frame)
	488	+static bool draw_frame(struct vo vo, struct vo_frame frame)
489	489	{
490	490	struct vo_priv *p = vo->priv;
491	491	struct mpv_render_context *ctx = p->ctx;
@@ -498,6 +498,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 6 unmodified lines
498	498	mp_mutex_unlock(&ctx->lock);
499	499
500	500	update(ctx);
	501	+ return VO_TRUE;
501	502	}
502	503
503	504	static void flip_page(struct vo *vo)

video/out/vo_mediacodec_embed.c+2−1

@@ -76,7 +76,7 @@ static void flip_page(struct vo *vo) · 75 unmodified lines
76	76	mp_image_unrefp(&p->next_image);
77	77	}
78	78
79		−static void draw_frame(struct vo vo, struct vo_frame frame)
	79	+static bool draw_frame(struct vo vo, struct vo_frame frame)
80	80	{
81	81	struct priv *p = vo->priv;
82	82
@@ -86,6 +86,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 3 unmodified lines
86	86
87	87	talloc_free(p->next_image);
88	88	p->next_image = mpi;
	89	+ return VO_TRUE;
89	90	}
90	91
91	92	static int query_format(struct vo *vo, int format)

video/out/vo_null.c+2−1

@@ -32,8 +32,9 @@ struct priv { · 31 unmodified lines
32	32	double cfg_fps;
33	33	};
34	34
35		−static void draw_frame(struct vo vo, struct vo_frame frame)
	35	+static bool draw_frame(struct vo vo, struct vo_frame frame)
36	36	{
	37	+ return VO_TRUE;
37	38	}
38	39
39	40	static void flip_page(struct vo *vo)

video/out/vo_sdl.c+5−2

@@ -879,7 +879,7 @@ static int query_format(struct vo *vo, int format) · 878 unmodified lines
879	879	return 0;
880	880	}
881	881
882		−static void draw_frame(struct vo vo, struct vo_frame frame)
	882	+static bool draw_frame(struct vo vo, struct vo_frame frame)
883	883	{
884	884	struct priv *vc = vo->priv;
885	885
@@ -894,7 +894,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 8 unmodified lines
894	894
895	895	mp_image_t texmpi;
896	896	if (!lock_texture(vo, &texmpi))
897		− return;
	897	+ goto done;
898	898
899	899	mp_image_copy(&texmpi, frame->current);
900	900
@@ -914,6 +914,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 13 unmodified lines
914	914	SDL_RenderCopy(vc->renderer, vc->tex, &src, &dst);
915	915
916	916	draw_osd(vo);
	917	+
	918	+done:
	919	+ return VO_TRUE;
917	920	}
918	921
919	922	static struct mp_image get_window_screenshot(struct vo vo)

video/out/vo_sixel.c+6−3

@@ -378,7 +378,7 @@ static int reconfig(struct vo vo, struct mp_image_params params) · 377 unmodified lines
378	378	return ret;
379	379	}
380	380
381		−static void draw_frame(struct vo vo, struct vo_frame frame)
	381	+static bool draw_frame(struct vo vo, struct vo_frame frame)
382	382	{
383	383	struct priv *priv = vo->priv;
384	384	SIXELSTATUS status;
@@ -391,7 +391,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 6 unmodified lines
391	391	bool resized = false;
392	392	update_canvas_dimensions(vo);
393	393	if (!priv->canvas_ok)
394		− return;
	394	+ goto done;
395	395
396	396	if (prev_rows != priv->num_rows \|\| prev_cols != priv->num_cols \|\|
397	397	prev_width != vo->dwidth \|\| prev_height != vo->dheight)
@@ -409,7 +409,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 11 unmodified lines
409	409	if (frame->repeat && !frame->redraw && !resized) {
410	410	// Frame is repeated, and no need to update OSD either
411	411	priv->skip_frame_draw = true;
412		− return;
	412	+ goto done;
413	413	} else {
414	414	// Either frame is new, or OSD has to be redrawn
415	415	priv->skip_frame_draw = false;
@@ -457,6 +457,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 41 unmodified lines
457	457
458	458	if (mpi)
459	459	talloc_free(mpi);
	460	+
	461	+done:
	462	+ return VO_TRUE;
460	463	}
461	464
462	465	static void flip_page(struct vo *vo)

video/out/vo_tct.c+5−2

@@ -253,14 +253,17 @@ static int reconfig(struct vo vo, struct mp_image_params params) · 252 unmodified lines
253	253	return 0;
254	254	}
255	255
256		−static void draw_frame(struct vo vo, struct vo_frame frame)
	256	+static bool draw_frame(struct vo vo, struct vo_frame frame)
257	257	{
258	258	struct priv *p = vo->priv;
259	259	struct mp_image *src = frame->current;
260	260	if (!src)
261		− return;
	261	+ goto done;
262	262	// XXX: pan, crop etc.
263	263	mp_sws_scale(p->sws, p->frame, src);
	264	+
	265	+done:
	266	+ return VO_TRUE;
264	267	}
265	268
266	269	static void flip_page(struct vo *vo)

video/out/vo_vaapi.c+5−2

@@ -555,7 +555,7 @@ static void get_vsync(struct vo vo, struct vo_vsync_info info) · 554 unmodified lines
555	555	present_sync_get_info(x11->present, info);
556	556	}
557	557
558		−static void draw_frame(struct vo vo, struct vo_frame frame)
	558	+static bool draw_frame(struct vo vo, struct vo_frame frame)
559	559	{
560	560	struct priv *p = vo->priv;
561	561	struct mp_image *mpi = frame->current;
@@ -564,7 +564,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 2 unmodified lines
564	564	struct mp_image *dst = p->swdec_surfaces[p->output_surface];
565	565	if (!dst \|\| va_surface_upload(p, dst, mpi) < 0) {
566	566	MP_WARN(vo, "Could not upload surface.\n");
567		− return;
	567	+ goto done;
568	568	}
569	569	mp_image_copy_attributes(dst, mpi);
570	570	mpi = dst;
@@ -573,6 +573,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 2 unmodified lines
573	573	p->output_surfaces[p->output_surface] = mpi;
574	574
575	575	draw_osd(vo);
	576	+
	577	+done:
	578	+ return VO_TRUE;
576	579	}
577	580
578	581	static void free_subpicture(struct priv p, struct vaapi_osd_image img)

video/out/vo_vdpau.c+2−1

@@ -870,7 +870,7 @@ drop: · 869 unmodified lines
870	870	vo_increment_drop_count(vo, 1);
871	871	}
872	872
873		−static void draw_frame(struct vo vo, struct vo_frame frame)
	873	+static bool draw_frame(struct vo vo, struct vo_frame frame)
874	874	{
875	875	struct vdpctx *vc = vo->priv;
876	876
@@ -893,6 +893,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 16 unmodified lines
893	893	video_to_output_surface(vo, vc->current_image);
894	894	draw_osd(vo);
895	895	}
	896	+ return VO_TRUE;
896	897	}
897	898
898	899	// warning: the size and pixel format of surface must match that of the

video/out/vo_wlshm.c+6−3

@@ -239,7 +239,7 @@ static int control(struct vo vo, uint32_t request, void data) · 238 unmodified lines
239	239	return ret;
240	240	}
241	241
242		−static void draw_frame(struct vo vo, struct vo_frame frame)
	242	+static bool draw_frame(struct vo vo, struct vo_frame frame)
243	243	{
244	244	struct priv *p = vo->priv;
245	245	struct vo_wayland_state *wl = vo->wl;
@@ -248,7 +248,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 2 unmodified lines
248	248
249	249	bool render = vo_wayland_check_visible(vo);
250	250	if (!render)
251		− return;
	251	+ return VO_FALSE;
252	252
253	253	buf = p->free_buffers;
254	254	if (buf) {
@@ -257,7 +257,7 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 2 unmodified lines
257	257	buf = buffer_create(vo, vo->dwidth, vo->dheight);
258	258	if (!buf) {
259	259	wl_surface_attach(wl->surface, NULL, 0, 0);
260		− return;
	260	+ goto done;
261	261	}
262	262	}
263	263	if (src) {
@@ -289,6 +289,9 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 25 unmodified lines
289	289	osd_draw_on_image(vo->osd, p->osd, 0, 0, &buf->mpi);
290	290	}
291	291	wl_surface_attach(wl->surface, buf->buffer, 0, 0);
	292	+
	293	+done:
	294	+ return VO_TRUE;
292	295	}
293	296
294	297	static void flip_page(struct vo *vo)

video/out/vo_x11.c+4−2

@@ -327,14 +327,14 @@ static void get_vsync(struct vo vo, struct vo_vsync_info info) · 326 unmodified lines
327	327	present_sync_get_info(x11->present, info);
328	328	}
329	329
330		−static void draw_frame(struct vo vo, struct vo_frame frame)
	330	+static bool draw_frame(struct vo vo, struct vo_frame frame)
331	331	{
332	332	struct priv *p = vo->priv;
333	333
334	334	wait_for_completion(vo, 1);
335	335	bool render = vo_x11_check_visible(vo);
336	336	if (!render)
337		− return;
	337	+ return VO_FALSE;
338	338
339	339	struct mp_image *img = &p->mp_ximages[p->current_buf];
340	340
@@ -359,6 +359,8 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 18 unmodified lines
359	359
360	360	if (frame->current != p->original_image)
361	361	p->original_image = frame->current;
	362	+
	363	+ return VO_TRUE;
362	364	}
363	365
364	366	static int query_format(struct vo *vo, int format)

video/out/vo_xv.c+4−2

@@ -708,14 +708,14 @@ static void get_vsync(struct vo vo, struct vo_vsync_info info) · 707 unmodified lines
708	708	present_sync_get_info(x11->present, info);
709	709	}
710	710
711		−static void draw_frame(struct vo vo, struct vo_frame frame)
	711	+static bool draw_frame(struct vo vo, struct vo_frame frame)
712	712	{
713	713	struct xvctx *ctx = vo->priv;
714	714
715	715	wait_for_completion(vo, ctx->num_buffers - 1);
716	716	bool render = vo_x11_check_visible(vo);
717	717	if (!render)
718		− return;
	718	+ return VO_FALSE;
719	719
720	720	struct mp_image xv_buffer = get_xv_buffer(vo, ctx->current_buf);
721	721	if (frame->current) {
@@ -729,6 +729,8 @@ static void draw_frame(struct vo vo, struct vo_frame frame) · 7 unmodified lines
729	729
730	730	if (frame->current != ctx->original_image)
731	731	ctx->original_image = frame->current;
	732	+
	733	+ return VO_TRUE;
732	734	}
733	735
734	736	static int query_format(struct vo *vo, int format)

vo: change draw_frame API to a boolean

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code