History

mac/view: fix cursor visibility when toggling fullscreen

this broke with the recent refactor of the input handling. one of the edge cases was not considered, where not every mouse down event has a corresponding mouse up event, eg all double clicks or more only have one up event after the first down event. this was handled correctly previously. Fixes #13777

der richter committed 2 years ago

Commit 92cb4731 parent ba45f201 file · +3 −3Browse files

Unified · Split

video/out/mac/view.swift+3−3
@@ -134,7 +134,7 @@ class View: NSView, CALayerDelegate { · 133 unmodified lines
134 }134 }
135 135
136 override func mouseDown(with event: NSEvent) {136 override func mouseDown(with event: NSEvent) {
137 hasMouseDown = true137 hasMouseDown = event.clickCount <= 1
138 input?.processMouse(event: event)138 input?.processMouse(event: event)
139 }139 }
140 140
@@ -145,7 +145,7 @@ class View: NSView, CALayerDelegate { · 4 unmodified lines
145 }145 }
146 146
147 override func rightMouseDown(with event: NSEvent) {147 override func rightMouseDown(with event: NSEvent) {
148 hasMouseDown = true148 hasMouseDown = event.clickCount <= 1
149 input?.processMouse(event: event)149 input?.processMouse(event: event)
150 }150 }
151 151
@@ -155,7 +155,7 @@ class View: NSView, CALayerDelegate { · 3 unmodified lines
155 }155 }
156 156
157 override func otherMouseDown(with event: NSEvent) {157 override func otherMouseDown(with event: NSEvent) {
158 hasMouseDown = true158 hasMouseDown = event.clickCount <= 1
159 input?.processMouse(event: event)159 input?.processMouse(event: event)
160 }160 }
161 161

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t