History

stream_cdda: deprecate undocumented --cdda-span-{a,b} options

You probably wouldn't guess what this does from the name alone, but it actually selects a range of tracks to play. It's slightly different than using --start because it confines the range to just that track and you cannot seek before it. The functionality is useful, but you can accomplish exactly the same thing with --start and --end. Also the implementation of the cdda option is weird because starting from a track after 1 makes it impossible to seek before it. There's no reason to have this when using the core option is simply better and works fine.

Dudemanguy committed 1 year ago

Commit bb3265b1 parent dd6e3a02 files · +3 −2Browse files

Unified · Split

2 files
  1. DOCS/interface-changes/cdda-span.txt +1 −0
  2. stream/stream_cdda.c +2 −2
DOCS/interface-changes/cdda-span.txt+1−0
@@ -0,0 +1 @@
1deprecate `--cdda-span-a` and `--cdda-span-b`
stream/stream_cdda.c+2−2
@@ -76,8 +76,8 @@ const struct m_sub_options stream_cdda_conf = { · 75 unmodified lines
76 {"overlap", OPT_INT(search_overlap), M_RANGE(0, 75)},76 {"overlap", OPT_INT(search_overlap), M_RANGE(0, 75)},
77 {"toc-offset", OPT_INT(toc_offset)},77 {"toc-offset", OPT_INT(toc_offset)},
78 {"skip", OPT_BOOL(skip)},78 {"skip", OPT_BOOL(skip)},
79 {"span-a", OPT_INT(span[0])},79 {"span-a", OPT_INT(span[0]), .deprecation_message = "--start=#N"},
80 {"span-b", OPT_INT(span[1])},80 {"span-b", OPT_INT(span[1]), .deprecation_message = "--end=#N"},
81 {"cdtext", OPT_BOOL(cdtext)},81 {"cdtext", OPT_BOOL(cdtext)},
82 {0}82 {0}
83 },83 },

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t