History

vo_gpu_next: don't render ASS subtitles at HDR colorspace

Upstream ASS specification says that all subtitles should be rendered with color primaries and transfer matching their associated video. But as expected after further discussion the decision has been made to fallback to SDR mode in case of HDR video.

Kacper Michajłow committed 2 years ago

Commit cbe30f61 parent bf1c8ac1 file · +1 −1Browse files

Unified · Split

video/out/vo_gpu_next.c+1−1
@@ -379,7 +379,7 @@ static void update_overlays(struct vo *vo, struct mp_osd_res res, · 378 unmodified lines
379379 }
380380 break;
381381 case SUBBITMAP_LIBASS:
382− if (src && item->video_color_space)
382+ if (src && item->video_color_space && !pl_color_space_is_hdr(&src->params.color))
383383 ol->color = src->params.color;
384384 ol->mode = PL_OVERLAY_MONOCHROME;
385385 ol->repr.alpha = PL_ALPHA_INDEPENDENT;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t