History

win32: set consoleAllocationPolicy to detached in the manifest

This essentially obsoletes the console wrapper (mpv.com), which is no longer needed. The console is attached depending on the context in which mpv.exe is run. Add an option to control which subsystem is targeted. Keep the GUI application as the default to preserve compatibility with Windows versions prior to 24H2. For more information about the new console handling, see: https://github.com/microsoft/terminal/blob/4386bf07fd65f763693132ee5e4c43a2a571dc76/doc/specs/%237335%20-%20Console%20Allocation%20Policy.md

Kacper Michajłow committed 2 years ago

Commit e09278c1 parent 48963ae3 files · +4 −2Browse files

Unified · Split

3 files
  1. meson.build +2 −2
  2. meson_options.txt +1 −0
  3. osdep/mpv.exe.manifest +1 −0
meson.build+2−2
@@ -1797,9 +1797,9 @@ if get_option('cplayer') · 1796 unmodified lines
17971797 install_data('etc/mpv-symbolic.svg', install_dir: join_paths(hicolor_dir, 'symbolic', 'apps'))
17981798
17991799 mpv = executable('mpv', main_fn_source, objects: libmpv.extract_all_objects(recursive: true), dependencies: dependencies,
1800− win_subsystem: 'windows', install: true)
1800+ win_subsystem: get_option('win32-subsystem'), install: true)
18011801
1802− if win32
1802+ if win32 and get_option('win32-subsystem') != 'console'
18031803 wrapper_sources= 'osdep/win32-console-wrapper.c'
18041804 executable('mpv', wrapper_sources, c_args: '-municode', link_args: '-municode',
18051805 name_suffix: 'com', install: true)
meson_options.txt+1−0
@@ -117,6 +117,7 @@ option('swift-flags', type: 'string', description: 'Optional Swift compiler flag · 116 unmodified lines
117117
118118 # Windows features
119119 option('win32-smtc', type: 'feature', value: 'auto', description: 'Enable Media Control support')
120+option('win32-subsystem', type : 'string', value: 'windows', description : 'Windows subsystem to use for mpv.exe')
120121
121122 # manpages
122123 option('html-build', type: 'feature', value: 'disabled', description: 'HTML manual generation')
osdep/mpv.exe.manifest+1−0
@@ -9,6 +9,7 @@ · 8 unmodified lines
99 <description>mpv - The Movie Player</description>
1010 <application xmlns="urn:schemas-microsoft-com:asm.v3">
1111 <windowsSettings>
12+ <consoleAllocationPolicy xmlns="http://schemas.microsoft.com/SMI/2024/WindowsSettings">detached</consoleAllocationPolicy>
1213 <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">True/PM</dpiAware>
1314 <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2,PerMonitor</dpiAwareness>
1415 <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t