History

player: don't decrement --loop-file=N and add remaining-file-loops

This stops decreasing numerical values of --loop-file on each iteration so that loop-file=N loops every playlist entry without having to add --loop-file to --reset-on-next-file. The current behavior confuses users as seen in: https://github.com/mpv-player/mpv/issues/2481 https://github.com/mpv-player/mpv/issues/5943 https://github.com/mpv-player/mpv/issues/11291 https://github.com/mpv-player/mpv/issues/13860 https://www.reddit.com/r/mpv/comments/rcwnrw/looping_each_file_n_times_in_a_playlist/ Also options are supposed to reflect the value configured by the user and not change on their own. A remaining-file-loops property is exposed as a replacement to check how many loops are left.

Guido Cella committed 2 years ago

Commit f411f311 parent 397212a6 files · +30 −5Browse files

Showing the changes to DOCS (2 of 6 files). Show all

Unified · Split

2 files
  1. DOCS/interface-changes/loop.txt +2 −0
  2. DOCS/man/input.rst +6 −0
DOCS/interface-changes/loop.txt+2−0
@@ -0,0 +1,2 @@
1+numerical values of `--loop-file` no longer decrease on each iteration
2+add `remaining-file-loops` property as a replacement to get the remaining loop count
DOCS/man/input.rst+6−0
@@ -2142,6 +2142,12 @@ Property list · 2141 unmodified lines
21422142 ``playback-time/full``
21432143 ``playback-time`` with milliseconds.
21442144
2145+``remaining-file-loops``
2146+ How many more times the current file is going to be looped. This is
2147+ initialized from the value of ``--loop-file``. This counts the number of
2148+ times it causes the player to seek to the beginning of the file, so it is 0
2149+ the last the time is played. -1 corresponds to infinity.
2150+
21452151 ``chapter`` (RW)
21462152 Current chapter number. The number of the first chapter is 0.
21472153

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t