History

ci/mingw: don't run test on 32-bit binary

Ubuntu 24.04 linux-azure kernel, used on GHA, is compiled with CONFIG_COMPAT_32BIT_TIME=n. This prevents running any 32-bit binaries through wine, so disable tests when doing i686 build. 32-bit builds are still tested on Windows.

Kacper Michajłow committed 2 years ago

Commit f47cbcd1 parent dea176a2 files · +17 −4Browse files

Unified · Split

2 files
  1. .github/workflows/build.yml +16 −3
  2. ci/build-mingw64.sh +1 −1
.github/workflows/build.yml+16−3
@@ -32,10 +32,14 @@ jobs: · 31 unmodified lines
3232 CCACHE_BASEDIR: ${{ github.workspace }}
3333 CCACHE_DIR: ${{ github.workspace }}/.ccache
3434 CCACHE_MAXSIZE: 500M
35+ WINE: ${{ matrix.wine }}
3536 strategy:
3637 fail-fast: false
3738 matrix:
38− target: [i686-w64-mingw32, x86_64-w64-mingw32]
39+ include:
40+ - target: i686-w64-mingw32
41+ - target: x86_64-w64-mingw32
42+ wine: wine
3943 steps:
4044 - uses: actions/checkout@v4
4145
@@ -50,11 +54,18 @@ jobs: · 8 unmodified lines
5054 key: ${{ matrix.target }}-${{ steps.get_time.outputs.timestamp }}
5155 restore-keys: ${{ matrix.target }}-
5256
53− - name: Install dependencies
57+ # For LuaJIT build
58+ - name: Enable multilib
59+ if: ${{ matrix.target == 'i686-w64-mingw32' }}
5460 run: |
5561 sudo dpkg --add-architecture i386
5662 sudo apt-get update
57− sudo apt-get install -y ccache g++-mingw-w64 gcc-multilib nasm ninja-build pkg-config python3-pip wine wine32 wine64
63+ sudo apt-get install -y gcc-multilib
64+
65+ - name: Install dependencies
66+ run: |
67+ sudo apt-get update
68+ sudo apt-get install -y ccache g++-mingw-w64 nasm ninja-build pkg-config wine wine64
5869 sudo python3 -m pip install meson
5970
6071 - name: Install Meson Wraps
@@ -81,12 +92,14 @@ jobs: · 20 unmodified lines
8192 cat ./mingw_build/meson-logs/meson-log.txt
8293
8394 - name: Functional test
95+ if: ${{ matrix.wine }}
8496 run: |
8597 cd artifact && wine ./mpv.com -v --no-config
8698 env:
8799 WINEDEBUG: '+loaddll'
88100
89101 - name: Run meson tests
102+ if: ${{ matrix.wine }}
90103 id: tests
91104 run: |
92105 meson test -C mingw_build
ci/build-mingw64.sh+1−1
@@ -46,7 +46,7 @@ pkgconfig = 'pkg-config' · 45 unmodified lines
4646 pkg-config = 'pkg-config'
4747 windres = '${TARGET}-windres'
4848 dlltool = '${TARGET}-dlltool'
49−exe_wrapper = 'wine'
49+exe_wrapper = '${WINE}'
5050 [host_machine]
5151 system = 'windows'
5252 cpu_family = '${fam}'

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t