History

Remove UBSAN warnings about negative left shift

Haibo Zhu committed 11 years ago

Commit 03d16bb1 parent 3067d1212 files · +71 −71Browse files

Showing the changes to codec/common/src/deblocking_common.cpp (1 of 12 files). Show all

Unified · Split

codec/common/src/deblocking_common.cpp+20−20
@@ -21,14 +21,14 @@ void DeblockLumaLt4_c (uint8_t* pPix, int32_t iStrideX, int32_t iStrideY, int32_ · 20 unmodified lines
2121 bool bDetaP2P0 = WELS_ABS (p2 - p0) < iBeta;
2222 bool bDetaQ2Q0 = WELS_ABS (q2 - q0) < iBeta;
2323 if (bDetaP2P0) {
24− pPix[-2 * iStrideX] = p1 + WELS_CLIP3 ((p2 + ((p0 + q0 + 1) >> 1) - (p1 << 1)) >> 1, -iTc0, iTc0);
24+ pPix[-2 * iStrideX] = p1 + WELS_CLIP3 ((p2 + ((p0 + q0 + 1) >> 1) - (p1 * (1 << 1))) >> 1, -iTc0, iTc0);
2525 iTc++;
2626 }
2727 if (bDetaQ2Q0) {
28− pPix[iStrideX] = q1 + WELS_CLIP3 ((q2 + ((p0 + q0 + 1) >> 1) - (q1 << 1)) >> 1, -iTc0, iTc0);
28+ pPix[iStrideX] = q1 + WELS_CLIP3 ((q2 + ((p0 + q0 + 1) >> 1) - (q1 * (1 << 1))) >> 1, -iTc0, iTc0);
2929 iTc++;
3030 }
31− int32_t iDeta = WELS_CLIP3 ((((q0 - p0) << 2) + (p1 - q1) + 4) >> 3, -iTc, iTc);
31+ int32_t iDeta = WELS_CLIP3 ((((q0 - p0) * (1 << 2)) + (p1 - q1) + 4) >> 3, -iTc, iTc);
3232 pPix[-iStrideX] = WelsClip1 (p0 + iDeta); /* p0' */
3333 pPix[0] = WelsClip1 (q0 - iDeta); /* q0' */
3434 }
@@ -56,23 +56,23 @@ void DeblockLumaEq4_c (uint8_t* pPix, int32_t iStrideX, int32_t iStrideY, int32_ · 21 unmodified lines
5656 bool bDetaQ2Q0 = WELS_ABS (q2 - q0) < iBeta;
5757 if (bDetaP2P0) {
5858 const int32_t p3 = pPix[-4 * iStrideX];
59− pPix[-iStrideX] = (p2 + (p1 << 1) + (p0 << 1) + (q0 << 1) + q1 + 4) >> 3; //p0
59+ pPix[-iStrideX] = (p2 + (p1 * (1 << 1)) + (p0 * (1 << 1)) + (q0 * (1 << 1)) + q1 + 4) >> 3; //p0
6060 pPix[-2 * iStrideX] = (p2 + p1 + p0 + q0 + 2) >> 2; //p1
61− pPix[-3 * iStrideX] = ((p3 << 1) + p2 + (p2 << 1) + p1 + p0 + q0 + 4) >> 3; //p2
61+ pPix[-3 * iStrideX] = ((p3 * (1 << 1)) + p2 + (p2 * (1 << 1)) + p1 + p0 + q0 + 4) >> 3; //p2
6262 } else {
63− pPix[-1 * iStrideX] = ((p1 << 1) + p0 + q1 + 2) >> 2; //p0
63+ pPix[-1 * iStrideX] = ((p1 * (1 << 1)) + p0 + q1 + 2) >> 2; //p0
6464 }
6565 if (bDetaQ2Q0) {
6666 const int32_t q3 = pPix[3 * iStrideX];
67− pPix[0] = (p1 + (p0 << 1) + (q0 << 1) + (q1 << 1) + q2 + 4) >> 3; //q0
67+ pPix[0] = (p1 + (p0 * (1 << 1)) + (q0 * (1 << 1)) + (q1 * (1 << 1)) + q2 + 4) >> 3; //q0
6868 pPix[iStrideX] = (p0 + q0 + q1 + q2 + 2) >> 2; //q1
69− pPix[2 * iStrideX] = ((q3 << 1) + q2 + (q2 << 1) + q1 + q0 + p0 + 4) >> 3; //q2
69+ pPix[2 * iStrideX] = ((q3 * (1 << 1)) + q2 + (q2 * (1 << 1)) + q1 + q0 + p0 + 4) >> 3; //q2
7070 } else {
71− pPix[0] = ((q1 << 1) + q0 + p1 + 2) >> 2; //q0
71+ pPix[0] = ((q1 * (1 << 1)) + q0 + p1 + 2) >> 2; //q0
7272 }
7373 } else {
74− pPix[-iStrideX] = ((p1 << 1) + p0 + q1 + 2) >> 2; //p0
75− pPix[ 0] = ((q1 << 1) + q0 + p1 + 2) >> 2; //q0
74+ pPix[-iStrideX] = ((p1 * (1 << 1)) + p0 + q1 + 2) >> 2; //p0
75+ pPix[ 0] = ((q1 * (1 << 1)) + q0 + p1 + 2) >> 2; //q0
7676 }
7777 }
7878 pPix += iStrideY;
@@ -107,7 +107,7 @@ void DeblockChromaLt4_c (uint8_t* pPixCb, uint8_t* pPixCr, int32_t iStrideX, int · 28 unmodified lines
107107 bDetaP1P0 = WELS_ABS (p1 - p0) < iBeta;
108108 bDetaQ1Q0 = WELS_ABS (q1 - q0) < iBeta;
109109 if (bDetaP0Q0 && bDetaP1P0 && bDetaQ1Q0) {
110− iDeta = WELS_CLIP3 ((((q0 - p0) << 2) + (p1 - q1) + 4) >> 3, -iTc0, iTc0);
110+ iDeta = WELS_CLIP3 ((((q0 - p0) * (1 << 2)) + (p1 - q1) + 4) >> 3, -iTc0, iTc0);
111111 pPixCb[-iStrideX] = WelsClip1 (p0 + iDeta); /* p0' */
112112 pPixCb[0] = WelsClip1 (q0 - iDeta); /* q0' */
113113 }
@@ -123,7 +123,7 @@ void DeblockChromaLt4_c (uint8_t* pPixCb, uint8_t* pPixCr, int32_t iStrideX, int · 9 unmodified lines
123123 bDetaQ1Q0 = WELS_ABS (q1 - q0) < iBeta;
124124
125125 if (bDetaP0Q0 && bDetaP1P0 && bDetaQ1Q0) {
126− iDeta = WELS_CLIP3 ((((q0 - p0) << 2) + (p1 - q1) + 4) >> 3, -iTc0, iTc0);
126+ iDeta = WELS_CLIP3 ((((q0 - p0) * (1 << 2)) + (p1 - q1) + 4) >> 3, -iTc0, iTc0);
127127 pPixCr[-iStrideX] = WelsClip1 (p0 + iDeta); /* p0' */
128128 pPixCr[0] = WelsClip1 (q0 - iDeta); /* q0' */
129129 }
@@ -146,8 +146,8 @@ void DeblockChromaEq4_c (uint8_t* pPixCb, uint8_t* pPixCr, int32_t iStrideX, int · 16 unmodified lines
146146 bDetaP1P0 = WELS_ABS (p1 - p0) < iBeta;
147147 bDetaQ1Q0 = WELS_ABS (q1 - q0) < iBeta;
148148 if (bDetaP0Q0 && bDetaP1P0 && bDetaQ1Q0) {
149− pPixCb[-iStrideX] = ((p1 << 1) + p0 + q1 + 2) >> 2; /* p0' */
150− pPixCb[0] = ((q1 << 1) + q0 + p1 + 2) >> 2; /* q0' */
149+ pPixCb[-iStrideX] = ((p1 * (1 << 1)) + p0 + q1 + 2) >> 2; /* p0' */
150+ pPixCb[0] = ((q1 * (1 << 1)) + q0 + p1 + 2) >> 2; /* q0' */
151151 }
152152
153153 //cr
@@ -159,8 +159,8 @@ void DeblockChromaEq4_c (uint8_t* pPixCb, uint8_t* pPixCr, int32_t iStrideX, int · 5 unmodified lines
159159 bDetaP1P0 = WELS_ABS (p1 - p0) < iBeta;
160160 bDetaQ1Q0 = WELS_ABS (q1 - q0) < iBeta;
161161 if (bDetaP0Q0 && bDetaP1P0 && bDetaQ1Q0) {
162− pPixCr[-iStrideX] = ((p1 << 1) + p0 + q1 + 2) >> 2; /* p0' */
163− pPixCr[0] = ((q1 << 1) + q0 + p1 + 2) >> 2; /* q0' */
162+ pPixCr[-iStrideX] = ((p1 * (1 << 1)) + p0 + q1 + 2) >> 2; /* p0' */
163+ pPixCr[0] = ((q1 * (1 << 1)) + q0 + p1 + 2) >> 2; /* q0' */
164164 }
165165 pPixCr += iStrideY;
166166 pPixCb += iStrideY;
@@ -198,7 +198,7 @@ void DeblockChromaLt42_c (uint8_t* pPixCbCr, int32_t iStrideX, int32_t iStrideY, · 31 unmodified lines
198198 bDetaP1P0 = WELS_ABS (p1 - p0) < iBeta;
199199 bDetaQ1Q0 = WELS_ABS (q1 - q0) < iBeta;
200200 if (bDetaP0Q0 && bDetaP1P0 && bDetaQ1Q0) {
201− iDeta = WELS_CLIP3 ((((q0 - p0) << 2) + (p1 - q1) + 4) >> 3, -iTc0, iTc0);
201+ iDeta = WELS_CLIP3 ((((q0 - p0) * (1 << 2)) + (p1 - q1) + 4) >> 3, -iTc0, iTc0);
202202 pPixCbCr[-iStrideX] = WelsClip1 (p0 + iDeta); /* p0' */
203203 pPixCbCr[0] = WelsClip1 (q0 - iDeta); /* q0' */
204204 }
@@ -221,8 +221,8 @@ void DeblockChromaEq42_c (uint8_t* pPixCbCr, int32_t iStrideX, int32_t iStrideY, · 16 unmodified lines
221221 bDetaP1P0 = WELS_ABS (p1 - p0) < iBeta;
222222 bDetaQ1Q0 = WELS_ABS (q1 - q0) < iBeta;
223223 if (bDetaP0Q0 && bDetaP1P0 && bDetaQ1Q0) {
224− pPixCbCr[-iStrideX] = ((p1 << 1) + p0 + q1 + 2) >> 2; /* p0' */
225− pPixCbCr[0] = ((q1 << 1) + q0 + p1 + 2) >> 2; /* q0' */
224+ pPixCbCr[-iStrideX] = ((p1 * (1 << 1)) + p0 + q1 + 2) >> 2; /* p0' */
225+ pPixCbCr[0] = ((q1 * (1 << 1)) + q0 + p1 + 2) >> 2; /* q0' */
226226 }
227227
228228 pPixCbCr += iStrideY;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t