History

Don't needlessly copy the input parameter struct

Martin Storsjö committed 12 years ago

Commit 2438b311 parent bcd57f41 file · +3 −8Browse files

Showing the changes to codec/encoder/plus/src/welsEncoderExt.cpp (1 of 1 file). Show all

Unified · Split

codec/encoder/plus/src/welsEncoderExt.cpp+3−8
@@ -212,11 +212,8 @@ int CWelsH264SVCEncoder::Initialize (SEncParamBase* argv, const INIT_TYPE iInitT · 211 unmodified lines
212212 SWelsSvcCodingParam sConfig (true);
213213 if(iInitType == INIT_TYPE_PARAMETER_BASED)
214214 {
215− SEncParamBase sEncodingParam;
216− memcpy (&sEncodingParam, argv, sizeof (SEncParamBase)); // confirmed_safe_unsafe_usage
217−
218215 // Convert SEncParamBase into WelsSVCParamConfig here..
219− if (sConfig.ParamBaseTranscode (sEncodingParam, true)) {
216+ if (sConfig.ParamBaseTranscode (*argv, true)) {
220217 WelsLog (m_pEncContext, WELS_LOG_ERROR, "CWelsH264SVCEncoder::Initialize(), parameter_translation failed.\n");
221218 Uninitialize();
222219 return cmInitParaError;
@@ -224,10 +221,8 @@ int CWelsH264SVCEncoder::Initialize (SEncParamBase* argv, const INIT_TYPE iInitT · 1 unmodified line
224221 }
225222 else if(iInitType == INIT_TYPE_PARAMETER_EXT)
226223 {
227− SEncParamExt sEncodingParam;
228− memcpy (&sEncodingParam, argv, sizeof (SEncParamExt)); // confirmed_safe_unsafe_usage
229− // Convert SEncParamBase into WelsSVCParamConfig here..
230− if (sConfig.ParamTranscode (sEncodingParam, true)) {
224+ // Convert SEncParamExt into WelsSVCParamConfig here..
225+ if (sConfig.ParamTranscode (*(const SEncParamExt*)argv, true)) {
231226 WelsLog (m_pEncContext, WELS_LOG_ERROR, "CWelsH264SVCEncoder::Initialize(), parameter_translation failed.\n");
232227 Uninitialize();
233228 return cmInitParaError;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t