History

Fix the decoder init failed case in UT

Haibo Zhu committed 10 years ago

Commit 46f42ec1 parent 25f53a25 files · +63 −28Browse files

Showing the changes to test/decoder/DecUT_DecExt.cpp (1 of 5 files). Show all

Unified · Split

test/decoder/DecUT_DecExt.cpp+36−15
@@ -3,6 +3,7 @@ · 2 unmodified lines
33 #include "codec_def.h"
44 #include "codec_app_def.h"
55 #include "codec_api.h"
6+#include "error_code.h"
67 #include "wels_common_basis.h"
78 #include "memory_align.h"
89 #include "ls_defines.h"
@@ -25,9 +26,9 @@ class DecoderInterfaceTest : public ::testing::Test { · 16 unmodified lines
2526 }
2627 }
2728 //Init members
28− void Init();
29+ int32_t Init();
2930 //Init valid members
30− void ValidInit();
31+ int32_t ValidInit();
3132 //Uninit members
3233 void Uninit();
3334 //Mock input data for test
@@ -77,7 +78,7 @@ class DecoderInterfaceTest : public ::testing::Test { · 43 unmodified lines
7778 };
7879
7980 //Init members
80−void DecoderInterfaceTest::Init() {
81+int32_t DecoderInterfaceTest::Init() {
8182 memset (&m_sBufferInfo, 0, sizeof (SBufferInfo));
8283 memset (&m_sParserBsInfo, 0, sizeof (SParserBsInfo));
8384 memset (&m_sDecParam, 0, sizeof (SDecodingParam));
@@ -93,10 +94,11 @@ void DecoderInterfaceTest::Init() { · 9 unmodified lines
9394 m_szBuffer[3] = 1;
9495 m_iBufLength = 4;
9596 CM_RETURN eRet = (CM_RETURN) m_pDec->Initialize (&m_sDecParam);
96− ASSERT_EQ (eRet, cmResultSuccess);
97+ EXPECT_EQ (eRet, cmResultSuccess);
98+ return (int32_t)eRet;
9799 }
98100
99−void DecoderInterfaceTest::ValidInit() {
101+int32_t DecoderInterfaceTest::ValidInit() {
100102 memset (&m_sBufferInfo, 0, sizeof (SBufferInfo));
101103 memset (&m_sDecParam, 0, sizeof (SDecodingParam));
102104 m_sDecParam.pFileNameRestructed = NULL;
@@ -111,7 +113,8 @@ void DecoderInterfaceTest::ValidInit() { · 8 unmodified lines
111113 m_szBuffer[3] = 1;
112114 m_iBufLength = 4;
113115 CM_RETURN eRet = (CM_RETURN) m_pDec->Initialize (&m_sDecParam);
114− ASSERT_EQ (eRet, cmResultSuccess);
116+ EXPECT_EQ (eRet, cmResultSuccess);
117+ return (int32_t)eRet;
115118 }
116119
117120 void DecoderInterfaceTest::Uninit() {
@@ -220,6 +223,7 @@ void DecoderInterfaceTest::MockPacketType (const EWelsNalUnitType eNalUnitType, · 102 unmodified lines
220223 void DecoderInterfaceTest::TestInitUninit() {
221224 int iOutput;
222225 CM_RETURN eRet;
226+ int32_t iRet = ERR_NONE;
223227 //No initialize, no GetOption can be done
224228 m_pDec->Uninitialize();
225229 for (int i = 0; i <= (int) DECODER_OPTION_TRACE_CALLBACK_CONTEXT; ++i) {
@@ -227,9 +231,13 @@ void DecoderInterfaceTest::TestInitUninit() { · 1 unmodified line
227231 EXPECT_EQ (eRet, cmInitExpected);
228232 }
229233 //Initialize first, can get input color format
230− Init();
234+ iRet = Init();
235+ ASSERT_EQ (iRet, ERR_NONE);
236+
231237 m_sDecParam.bParseOnly = false;
232− m_pDec->Initialize (&m_sDecParam);
238+ eRet = (CM_RETURN)m_pDec->Initialize (&m_sDecParam);
239+ ASSERT_EQ (eRet, cmResultSuccess);
240+
233241 eRet = (CM_RETURN) m_pDec->GetOption (DECODER_OPTION_END_OF_STREAM, &iOutput);
234242 EXPECT_EQ (eRet, cmResultSuccess);
235243 EXPECT_EQ (iOutput, 0);
@@ -329,8 +337,10 @@ void DecoderInterfaceTest::TestParseOnlyAPI() { · 93 unmodified lines
329337 void DecoderInterfaceTest::TestEndOfStream() {
330338 int iTmp, iOut;
331339 CM_RETURN eRet;
340+ int32_t iRet = ERR_NONE;
332341
333− ValidInit();
342+ iRet = ValidInit();
343+ ASSERT_EQ (iRet, ERR_NONE);
334344
335345 //invalid input
336346 eRet = (CM_RETURN) m_pDec->SetOption (DECODER_OPTION_END_OF_STREAM, NULL);
@@ -391,8 +401,10 @@ void DecoderInterfaceTest::TestEndOfStream() { · 54 unmodified lines
391401 void DecoderInterfaceTest::TestVclNal() {
392402 int iTmp, iOut;
393403 CM_RETURN eRet;
404+ int32_t iRet = ERR_NONE;
394405
395− ValidInit();
406+ iRet = ValidInit();
407+ ASSERT_EQ (iRet, ERR_NONE);
396408
397409 //Test SetOption
398410 //VclNal never supports SetOption
@@ -453,8 +465,10 @@ void DecoderInterfaceTest::TestLtrMarkedFrameNum() { · 54 unmodified lines
453465 void DecoderInterfaceTest::TestErrorConIdc() {
454466 int iTmp, iOut;
455467 CM_RETURN eRet;
468+ int32_t iRet = ERR_NONE;
456469
457− Init();
470+ iRet = Init();
471+ ASSERT_EQ (iRet, ERR_NONE);
458472
459473 //Test GetOption
460474 //invalid input
@@ -498,10 +512,12 @@ void DecoderInterfaceTest::TestTraceCallbackContext() { · 37 unmodified lines
498512 //DECODER_OPTION_GET_STATISTICS
499513 void DecoderInterfaceTest::TestGetDecStatistics() {
500514 CM_RETURN eRet;
515+ int32_t iRet;
501516 SDecoderStatistics sDecStatic;
502517 int32_t iError = 0;
503518
504− ValidInit();
519+ iRet = ValidInit();
520+ ASSERT_EQ (iRet, ERR_NONE);
505521 //GetOption before decoding
506522 m_pDec->GetOption (DECODER_OPTION_GET_STATISTICS, &sDecStatic);
507523 EXPECT_EQ (0u, sDecStatic.uiDecodedFrameCount);
@@ -528,7 +544,8 @@ void DecoderInterfaceTest::TestGetDecStatistics() { · 20 unmodified lines
528544 Uninit();
529545
530546 //Decoder error bs when the first IDR lost
531− ValidInit();
547+ iRet = ValidInit();
548+ ASSERT_EQ (iRet, ERR_NONE);
532549 iError = 2;
533550 m_pDec->SetOption (DECODER_OPTION_ERROR_CON_IDC, &iError);
534551 DecoderBs ("res/BA_MW_D_IDR_LOST.264");
@@ -546,7 +563,9 @@ void DecoderInterfaceTest::TestGetDecStatistics() { · 11 unmodified lines
546563 Uninit();
547564
548565 //ecoder error bs when the first P lost
549− ValidInit();
566+ iRet = ValidInit();
567+ ASSERT_EQ (iRet, ERR_NONE);
568+
550569 iError = 2;
551570 m_pDec->SetOption (DECODER_OPTION_ERROR_CON_IDC, &iError);
552571
@@ -567,7 +586,9 @@ void DecoderInterfaceTest::TestGetDecStatistics() { · 14 unmodified lines
567586 //EC enable
568587
569588 //EC Off UT just correc bitstream
570− ValidInit();
589+ iRet = ValidInit();
590+ ASSERT_EQ (iRet, ERR_NONE);
591+
571592 iError = 0;
572593 m_pDec->SetOption (DECODER_OPTION_ERROR_CON_IDC, &iError);
573594 DecoderBs ("res/test_vd_1d.264");

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t