This makes sure we don't accidentally return the same sequence of random numbers multiple times within one test (which would be very non-random). Every time srand(time()) is called, the pseudo random number generator is initialized to the same value (as long as time() returned the same value). By initializing the random number generator once and for all before starting to run the unit tests, we are sure we don't need to reinitialize it within all the tests and all the functions that use random numbers. This fixes occasional errors in MotionEstimateTest. MotionEstimateTest was designed to allow the test to occasionally not succeed - if it didn't succeed, it tried again, up to 100 times. However, since the YUVPixelDataGenerator function reset the random seed to time(), every attempt actually ran with the same random data (as long as all 100 attempts ran within 1 second) - thus if one attempt in MotionEstimateTest failed, all 100 of them would fail. If the utility functions don't touch the random seed, this is not an issue.
Showing the changes to test/encoder/EncUT_EncoderMb.cpp (1 of 16 files). Show all
Unified · Split
| @@ -124,8 +124,8 @@ void TestQuant (uint32_t qp, uint8_t* pSrc, uint8_t* pPred, int16_t* pDct, · 123 unmodified lines | ||
| 124 | 124 | const int16_t* pFfI = g_kiQuantInterFF[6 + qp]; |
| 125 | 125 | const int16_t* pFfP = g_kiQuantInterFF[qp]; |
| 126 | 126 | //quant4x4 Intra MB |
| 127 | − RandomPixelDataGenerator (pSrc, iWidth, iHeight, iWidth, 0); | |
| 128 | − RandomPixelDataGenerator (pPred, iWidth, iHeight, iWidth, rand()); | |
| 127 | + RandomPixelDataGenerator (pSrc, iWidth, iHeight, iWidth); | |
| 128 | + RandomPixelDataGenerator (pPred, iWidth, iHeight, iWidth); | |
| 129 | 129 | |
| 130 | 130 | for (int16_t i = 0; i < 16; i++) { |
| 131 | 131 | pDct[i] = pSrc[i] - pPred[i]; |
| @@ -142,8 +142,8 @@ void TestQuant (uint32_t qp, uint8_t* pSrc, uint8_t* pPred, int16_t* pDct, · 10 unmodified lines | ||
| 142 | 142 | } |
| 143 | 143 | |
| 144 | 144 | //quant4x4 DC |
| 145 | − RandomPixelDataGenerator (pSrc, iWidth, iHeight, iWidth, 0); | |
| 146 | − RandomPixelDataGenerator (pPred, iWidth, iHeight, iWidth, rand()); | |
| 145 | + RandomPixelDataGenerator (pSrc, iWidth, iHeight, iWidth); | |
| 146 | + RandomPixelDataGenerator (pPred, iWidth, iHeight, iWidth); | |
| 147 | 147 | |
| 148 | 148 | for (int16_t i = 0; i < 16; i++) { |
| 149 | 149 | pDct[i] = pSrc[i] - pPred[i]; |
| @@ -160,8 +160,8 @@ void TestQuant (uint32_t qp, uint8_t* pSrc, uint8_t* pPred, int16_t* pDct, · 10 unmodified lines | ||
| 160 | 160 | } |
| 161 | 161 | |
| 162 | 162 | //quant4x4 Inter MB |
| 163 | − RandomPixelDataGenerator (pSrc, iWidth, iHeight, iWidth, 0); | |
| 164 | − RandomPixelDataGenerator (pPred, iWidth, iHeight, iWidth, rand()); | |
| 163 | + RandomPixelDataGenerator (pSrc, iWidth, iHeight, iWidth); | |
| 164 | + RandomPixelDataGenerator (pPred, iWidth, iHeight, iWidth); | |
| 165 | 165 | |
| 166 | 166 | for (int16_t i = 0; i < 64; i++) { |
| 167 | 167 | pDct[i] = pSrc[i] - pPred[i]; |