History

fix random failure of UT under randon seed 1421732719

Sijia Chen committed 11 years ago

Commit 5b10c1f1 parent 8bef6bc3 files · +13 −4Browse files

Showing the changes to codec/encoder/core/src/encoder_ext.cpp (1 of 3 files). Show all

Unified · Split

codec/encoder/core/src/encoder_ext.cpp+7−3
@@ -478,7 +478,7 @@ int32_t ParamValidationExt (SLogContext* pLogCtx, SWelsSvcCodingParam* pCodingPa · 477 unmodified lines
478478 iMbHeight = (kiPicHeight + 15) >> 4;
479479 iMaxSliceNum = MAX_SLICES_NUM;
480480 if (iMbHeight > iMaxSliceNum) {
481− WelsLog (pLogCtx, WELS_LOG_ERROR, "ParamValidationExt(), invalid uiSliceNum (%d) settings more than MAX!", iMbHeight);
481+ WelsLog (pLogCtx, WELS_LOG_ERROR, "ParamValidationExt(), invalid uiSliceNum (%d) settings more than MAX(%d)!", iMbHeight, MAX_SLICES_NUM);
482482 return ENC_RETURN_UNSUPPORTED_PARA;
483483 }
484484 pSpatialLayer->sSliceCfg.sSliceArgument.uiSliceNum = iMbHeight;
@@ -514,7 +514,7 @@ int32_t ParamValidationExt (SLogContext* pLogCtx, SWelsSvcCodingParam* pCodingPa · 29 unmodified lines
514514 if (pSpatialLayer->sSliceCfg.sSliceArgument.uiSliceSizeConstraint > (pCodingParam->uiMaxNalSize -
515515 NAL_HEADER_ADD_0X30BYTES)) {
516516 WelsLog (pLogCtx, WELS_LOG_WARNING,
517− "ParamValidationExt(), slice mode = SM_DYN_SLICE, uiSliceSizeConstraint = %d ,uiMaxNalsize = %d!",
517+ "ParamValidationExt(), slice mode = SM_DYN_SLICE, uiSliceSizeConstraint = %d ,uiMaxNalsize = %d, will take uiMaxNalsize!",
518518 pSpatialLayer->sSliceCfg.sSliceArgument.uiSliceSizeConstraint, pCodingParam->uiMaxNalSize);
519519 pSpatialLayer->sSliceCfg.sSliceArgument.uiSliceSizeConstraint = pCodingParam->uiMaxNalSize - NAL_HEADER_ADD_0X30BYTES;
520520 }
@@ -4108,9 +4108,13 @@ int32_t WelsEncoderParamAdjust (sWelsEncCtx** ppCtx, SWelsSvcCodingParam* pNewPa · 3587 unmodified lines
41084108 return iReturn;
41094109 }
41104110
4111−
41124111 pOldParam = (*ppCtx)->pSvcParam;
41134112
4113+ if (pOldParam->iUsageType != pNewParam->iUsageType) {
4114+ WelsLog (& (*ppCtx)->sLogCtx, WELS_LOG_ERROR, "WelsEncoderParamAdjust(), does not expect in-middle change of iUsgaeType from %d to %d", pOldParam->iUsageType, pNewParam->iUsageType);
4115+ return ENC_RETURN_UNSUPPORTED_PARA;
4116+ }
4117+
41144118 /* Decide whether need reset for IDR frame based on adjusting prarameters changed */
41154119 /* Temporal levels, spatial settings and/ or quality settings changed need update parameter sets related. */
41164120 bNeedReset = (pOldParam == NULL) ||

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t