History

add warning trace

ruil2 committed 12 years ago

Commit 77040011 parent 81f7b0c1 file · +9 −5Browse files

Showing the changes to codec/encoder/core/src/encoder_ext.cpp (1 of 1 file). Show all

Unified · Split

codec/encoder/core/src/encoder_ext.cpp+9−5
@@ -175,7 +175,11 @@ int32_t ParamValidation (SLogContext* pLogCtx, SWelsSvcCodingParam* pCfg) { · 174 unmodified lines
175175 iTotalBitrate, pCfg->iTargetBitrate);
176176 return ENC_RETURN_INVALIDINPUT;
177177 }
178−
178+ if ((pCfg->iRCMode == RC_QUALITY_MODE) || (pCfg->iRCMode == RC_BITRATE_MODE))
179+ if (!pCfg->bEnableFrameSkip)
180+ WelsLog (pLogCtx, WELS_LOG_WARNING,
181+ "bEnableFrameSkip = %d,bitrate can't be controlled for RC_QUALITY_MODE and RC_BITRATE_MODE without enabling skip frame.",
182+ pCfg->bEnableFrameSkip);
179183 }
180184 return WelsCheckRefFrameLimitation (pLogCtx, pCfg);
181185 }
@@ -1510,8 +1514,8 @@ int32_t RequestMemorySvc (sWelsEncCtx** ppCtx) { · 1328 unmodified lines
15101514 (*ppCtx)->iMvdCostTableSize = kuiMvdInterTableSize;
15111515 (*ppCtx)->iMvdCostTableStride = kuiMvdInterTableStride;
15121516 (*ppCtx)->pMvdCostTable = (uint16_t*)pMa->WelsMallocz (52 * kuiMvdCacheAlignedSize, "pMvdCostTable");
1513− WELS_VERIFY_RETURN_PROC_IF (1, (NULL == (*ppCtx)->pMvdCostTable), FreeMemorySvc (ppCtx))
1514− MvdCostInit ((*ppCtx)->pMvdCostTable, kuiMvdInterTableStride); //should put to a better place?
1517+ WELS_VERIFY_RETURN_PROC_IF (1, (NULL == (*ppCtx)->pMvdCostTable), FreeMemorySvc (ppCtx))
1518+ MvdCostInit ((*ppCtx)->pMvdCostTable, kuiMvdInterTableStride); //should put to a better place?
15151519
15161520 if ((*ppCtx)->ppRefPicListExt[0] != NULL && (*ppCtx)->ppRefPicListExt[0]->pRef[0] != NULL)
15171521 (*ppCtx)->pDecPic = (*ppCtx)->ppRefPicListExt[0]->pRef[0];
@@ -3695,8 +3699,8 @@ int32_t WelsEncoderParamAdjust (sWelsEncCtx** ppCtx, SWelsSvcCodingParam* pNewPa · 2177 unmodified lines
36953699 SParaSetOffsetVariable sTmpPsoVariable[PARA_SET_TYPE];
36963700 uint16_t uiTmpIdrPicId;//this is for LTR!
36973701 SLogContext sLogCtx = (*ppCtx)->sLogCtx;
3698− for (int32_t k=0;k<PARA_SET_TYPE;k++)
3699− memset(((*ppCtx)->sPSOVector.sParaSetOffsetVariable[k].bUsedParaSetIdInBs), 0, MAX_PPS_COUNT*sizeof(bool));
3702+ for (int32_t k = 0; k < PARA_SET_TYPE; k++)
3703+ memset (((*ppCtx)->sPSOVector.sParaSetOffsetVariable[k].bUsedParaSetIdInBs), 0, MAX_PPS_COUNT * sizeof (bool));
37003704 memcpy (sTmpPsoVariable, (*ppCtx)->sPSOVector.sParaSetOffsetVariable,
37013705 (PARA_SET_TYPE)*sizeof (SParaSetOffsetVariable)); // confirmed_safe_unsafe_usage
37023706 uiTmpIdrPicId = (*ppCtx)->sPSOVector.uiIdrPicId;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t