History

add verification on return value

ruil2 committed 12 years ago

Commit 823b3b61 parent 3d47b781 file · +22 −4Browse files

Showing the changes to codec/encoder/plus/src/welsEncoderExt.cpp (1 of 1 file). Show all

Unified · Split

codec/encoder/plus/src/welsEncoderExt.cpp+22−4
@@ -406,8 +406,14 @@ int CWelsH264SVCEncoder::Initialize2 (SWelsSvcCodingParam* pCfg) { · 405 unmodified lines
406406 m_iSrcListSize = 0;
407407 return cmMallocMemeError;
408408 }
409− InitPic (m_pSrcPicList[i], iColorspace, m_iMaxPicWidth, m_iMaxPicHeight);
410− }
409+ if(InitPic (m_pSrcPicList[i], iColorspace, m_iMaxPicWidth, m_iMaxPicHeight))
410+ {
411+ WelsLog (m_pEncContext, WELS_LOG_ERROR,
412+ "CWelsH264SVCEncoder::Initialize(), InitPic Failed iColorspace= 0x%x\n", iColorspace);
413+ Uninitialize();
414+ return cmInitParaError;
415+ }
416+ }
411417
412418 if (WelsInitEncoderExt (&m_pEncContext, pCfg)) {
413419 WelsLog (m_pEncContext, WELS_LOG_ERROR, "CWelsH264SVCEncoder::Initialize(), WelsInitEncoderExt failed.\n");
@@ -711,7 +717,13 @@ int CWelsH264SVCEncoder::SetOption (ENCODER_OPTION eOptionId, void* pOption) { · 297 unmodified lines
711717 continue;
712718 }
713719
714− InitPic (m_pSrcPicList[iPicIdx], iColorspace, m_iMaxPicWidth, m_iMaxPicHeight);
720+ if(InitPic (m_pSrcPicList[iPicIdx], iColorspace, m_iMaxPicWidth, m_iMaxPicHeight))
721+ {
722+ WelsLog (m_pEncContext, WELS_LOG_INFO,
723+ "CWelsH264SVCEncoder::SetOption():ENCODER_OPTION_DATAFORMAT, iColorspace= 0x%x\n",
724+ iColorspace);
725+ return cmInitParaError;
726+ }
715727 }
716728 m_iCspInternal = iColorspace;
717729 #ifdef REC_FRAME_COUNT
@@ -810,7 +822,13 @@ int CWelsH264SVCEncoder::SetOption (ENCODER_OPTION eOptionId, void* pOption) { · 92 unmodified lines
810822 }
811823 if (m_iCspInternal != iInputColorspace || m_iMaxPicWidth != iTargetWidth
812824 || m_iMaxPicHeight != iTargetHeight) { // for color space due to changed
813− InitPic (m_pSrcPicList[0], iInputColorspace, iTargetWidth, iTargetHeight);
825+ if(InitPic (m_pSrcPicList[0], iInputColorspace, iTargetWidth, iTargetHeight))
826+ {
827+ WelsLog (m_pEncContext, WELS_LOG_INFO,
828+ "CWelsH264SVCEncoder::SetOption():ENCODER_OPTION_SVC_ENCODE_PARAM_EXT, iInputColorspace= 0x%x\n",
829+ iInputColorspace);
830+ return cmInitParaError;
831+ }
814832 m_iMaxPicWidth = iTargetWidth;
815833 m_iMaxPicHeight = iTargetHeight;
816834 m_iCspInternal = iInputColorspace;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t