History

Consistently compare integers with integers and bools with bools

MSVC warns when comparing integers with booleans in with the gtest assertion macros.

Martin Storsjö committed 11 years ago

Commit 99925981 parent cd552013 files · +14 −14Browse files

Showing the changes to test/api/encode_decode_api_test.cpp (1 of 3 files). Show all

Unified · Split

test/api/encode_decode_api_test.cpp+7−7
@@ -1594,7 +1594,7 @@ TEST_F (EncodeDecodeTestAPI, SetOptionECIDC_SpecificFrameChange) { · 1593 unmodified lines
15941594 EXPECT_EQ (dstBufInfo_.iBufferStatus, 0); //no output
15951595 rv = decoder_->DecodeFrame2 (NULL, 0, pData, &dstBufInfo_); //reconstruction
15961596 //Ref picture is ECed, so current status is ECed, when EC disable, NO output
1597− EXPECT_TRUE (rv & 32);
1597+ EXPECT_TRUE ((rv & 32) != 0);
15981598 EXPECT_EQ (dstBufInfo_.iBufferStatus, 0);
15991599 iIdx++;
16001600
@@ -1689,10 +1689,10 @@ TEST_F (EncodeDecodeTestAPI, SetOptionECIDC_SpecificSliceChange_IDRLoss) { · 88 unmodified lines
16891689 decoder_->GetOption (DECODER_OPTION_ERROR_CON_IDC, &uiGet);
16901690 EXPECT_EQ (uiGet, (uint32_t) ERROR_CON_SLICE_COPY);
16911691 rv = decoder_->DecodeFrame2 (info.sLayerInfo[0].pBsBuf, len, pData, &dstBufInfo_);
1692− EXPECT_TRUE (rv & 32); //parse correct, but reconstruct ECed
1692+ EXPECT_TRUE ((rv & 32) != 0); //parse correct, but reconstruct ECed
16931693 EXPECT_EQ (dstBufInfo_.iBufferStatus, 1); //ECed output for frame 0
16941694 rv = decoder_->DecodeFrame2 (NULL, 0, pData, &dstBufInfo_); //ECed status, reconstruction current frame 1
1695− EXPECT_TRUE (rv & 32); //decoder ECed status
1695+ EXPECT_TRUE ((rv & 32) != 0); //decoder ECed status
16961696 EXPECT_EQ (dstBufInfo_.iBufferStatus, 1); //ECed output for frame 1
16971697 iIdx++;
16981698
@@ -1713,7 +1713,7 @@ TEST_F (EncodeDecodeTestAPI, SetOptionECIDC_SpecificSliceChange_IDRLoss) { · 14 unmodified lines
17131713 EXPECT_EQ (rv, 0); //parse correct
17141714 rv = decoder_->DecodeFrame2 (NULL, 0, pData, &dstBufInfo_); //reconstruction
17151715 // Ref picture is ECed, so reconstructed picture is ECed
1716− EXPECT_TRUE (rv & 32);
1716+ EXPECT_TRUE ((rv & 32) != 0);
17171717 EXPECT_EQ (dstBufInfo_.iBufferStatus, 0);
17181718 iIdx++;
17191719
@@ -1734,7 +1734,7 @@ TEST_F (EncodeDecodeTestAPI, SetOptionECIDC_SpecificSliceChange_IDRLoss) { · 14 unmodified lines
17341734 EXPECT_EQ (rv, 0); //parse correct
17351735 EXPECT_EQ (dstBufInfo_.iBufferStatus, 0);
17361736 rv = decoder_->DecodeFrame2 (NULL, 0, pData, &dstBufInfo_); //reconstruction
1737− EXPECT_TRUE (rv & 32);
1737+ EXPECT_TRUE ((rv & 32) != 0);
17381738 EXPECT_EQ (dstBufInfo_.iBufferStatus, 0); //slice loss
17391739 iIdx++;
17401740
@@ -1858,10 +1858,10 @@ TEST_F (EncodeDecodeTestAPI, SetOptionECIDC_SpecificSliceChange_IDRNoLoss) { · 117 unmodified lines
18581858 decoder_->GetOption (DECODER_OPTION_ERROR_CON_IDC, &uiGet);
18591859 EXPECT_EQ (uiGet, (uint32_t) ERROR_CON_SLICE_COPY);
18601860 rv = decoder_->DecodeFrame2 (info.sLayerInfo[0].pBsBuf, len, pData, &dstBufInfo_);
1861− EXPECT_TRUE (rv & 32); //parse OK but frame 2 ECed
1861+ EXPECT_TRUE ((rv & 32) != 0); //parse OK but frame 2 ECed
18621862 EXPECT_EQ (dstBufInfo_.iBufferStatus, 1); //slice loss but ECed output Frame 2
18631863 rv = decoder_->DecodeFrame2 (NULL, 0, pData, &dstBufInfo_); //reconstruction
1864− EXPECT_TRUE (rv & 32);
1864+ EXPECT_TRUE ((rv & 32) != 0);
18651865 EXPECT_EQ (dstBufInfo_.iBufferStatus, 0); //slice loss
18661866 iIdx++;
18671867

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t