History

modify return value check inside decoder

unknown committed 10 years ago

Commit 9cb4f4e1 parent 13586a311 files · +216 −197Browse files

Showing the changes to codec/decoder/core/src/fmo.cpp (1 of 11 files). Show all

Unified · Split

codec/decoder/core/src/fmo.cpp+14−12
@@ -40,6 +40,7 @@ · 39 unmodified lines
4040
4141 #include "fmo.h"
4242 #include "memory_align.h"
43+#include "error_code.h"
4344
4445 namespace WelsDec {
4546
@@ -56,10 +57,11 @@ static inline int32_t FmoGenerateMbAllocMapType0 (PFmo pFmo, PPps pPps) { · 10 unmodified lines
5657 int32_t iMbNum = 0;
5758 int32_t i = 0;
5859
59− WELS_VERIFY_RETURN_IF (1, (NULL == pFmo || NULL == pPps))
60+ WELS_VERIFY_RETURN_IF (ERR_INFO_INVALID_PARAM, (NULL == pFmo || NULL == pPps))
6061 uiNumSliceGroups = pPps->uiNumSliceGroups;
6162 iMbNum = pFmo->iCountMbNum;
62− WELS_VERIFY_RETURN_IF (1, (NULL == pFmo->pMbAllocMap || iMbNum <= 0 || uiNumSliceGroups > MAX_SLICEGROUP_IDS))
63+ WELS_VERIFY_RETURN_IF (ERR_INFO_INVALID_PARAM, (NULL == pFmo->pMbAllocMap || iMbNum <= 0
64+ || uiNumSliceGroups > MAX_SLICEGROUP_IDS))
6365
6466 do {
6567 uint8_t uiGroup = 0;
@@ -75,7 +77,7 @@ static inline int32_t FmoGenerateMbAllocMapType0 (PFmo pFmo, PPps pPps) { · 9 unmodified lines
7577 } while (uiGroup < uiNumSliceGroups && i < iMbNum);
7678 } while (i < iMbNum);
7779
78− return 0; // well here
80+ return ERR_NONE; // well here
7981 }
8082
8183 /*!
@@ -91,18 +93,18 @@ static inline int32_t FmoGenerateMbAllocMapType1 (PFmo pFmo, PPps pPps, const in · 9 unmodified lines
9193 uint32_t uiNumSliceGroups = 0;
9294 int32_t iMbNum = 0;
9395 int32_t i = 0;
94− WELS_VERIFY_RETURN_IF (1, (NULL == pFmo || NULL == pPps))
96+ WELS_VERIFY_RETURN_IF (ERR_INFO_INVALID_PARAM, (NULL == pFmo || NULL == pPps))
9597 uiNumSliceGroups = pPps->uiNumSliceGroups;
9698 iMbNum = pFmo->iCountMbNum;
97− WELS_VERIFY_RETURN_IF (1, (NULL == pFmo->pMbAllocMap || iMbNum <= 0 || kiMbWidth == 0
98− || uiNumSliceGroups > MAX_SLICEGROUP_IDS))
99+ WELS_VERIFY_RETURN_IF (ERR_INFO_INVALID_PARAM, (NULL == pFmo->pMbAllocMap || iMbNum <= 0 || kiMbWidth == 0
100+ || uiNumSliceGroups > MAX_SLICEGROUP_IDS))
99101
100102 do {
101103 pFmo->pMbAllocMap[i] = (uint8_t) (((i % kiMbWidth) + (((i / kiMbWidth) * uiNumSliceGroups) >> 1)) % uiNumSliceGroups);
102104 ++ i;
103105 } while (i < iMbNum);
104106
105− return 0; // well here
107+ return ERR_NONE; // well here
106108 }
107109
108110 /*!
@@ -122,18 +124,18 @@ static inline int32_t FmoGenerateSliceGroup (PFmo pFmo, const PPps kpPps, const · 13 unmodified lines
122124 bool bResolutionChanged = false;
123125
124126 // the cases we would not like
125− WELS_VERIFY_RETURN_IF (1, (NULL == pFmo || NULL == kpPps))
127+ WELS_VERIFY_RETURN_IF (ERR_INFO_INVALID_PARAM, (NULL == pFmo || NULL == kpPps))
126128
127129 iNumMb = pFmo->iCountMbNum;
128130
129131 iNumMb = kiMbWidth * kiMbHeight;
130132
131133 if (0 == iNumMb)
132− return 1;
134+ return ERR_INFO_INVALID_PARAM;
133135
134136 pMa->WelsFree (pFmo->pMbAllocMap, "_fmo->pMbAllocMap");
135137 pFmo->pMbAllocMap = (uint8_t*)pMa->WelsMallocz (iNumMb * sizeof (uint8_t), "_fmo->pMbAllocMap");
136− WELS_VERIFY_RETURN_IF (1, (NULL == pFmo->pMbAllocMap)) // out of memory
138+ WELS_VERIFY_RETURN_IF (ERR_INFO_OUT_OF_MEMORY, (NULL == pFmo->pMbAllocMap)) // out of memory
137139
138140 pFmo->iCountMbNum = iNumMb;
139141
@@ -142,7 +144,7 @@ static inline int32_t FmoGenerateSliceGroup (PFmo pFmo, const PPps kpPps, const · 2 unmodified lines
142144
143145 pFmo->iSliceGroupCount = 1;
144146
145− return 0;
147+ return ERR_NONE;
146148 }
147149
148150 if (bResolutionChanged || ((int32_t)kpPps->uiSliceGroupMapType != pFmo->iSliceGroupType)
@@ -163,7 +165,7 @@ static inline int32_t FmoGenerateSliceGroup (PFmo pFmo, const PPps kpPps, const · 14 unmodified lines
163165 iErr = 1;
164166 break;
165167 default:
166− return 1;
168+ return ERR_INFO_UNSUPPORTED_FMOTYPE;
167169 }
168170 }
169171

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t