History

Fully initialize m_sDecParam in TestInitUninit

Before dc2cbe4, the DecoderConfigParam function returned early since DecoderSetCsp signaled a failure, which is why the uninitialized parameters weren't read before. This fixes valgrind warnings about conditional jumps depending on uninitialized values.

Martin Storsjö committed 10 years ago

Commit b3b083c1 parent 222c84c1 file · +1 −0Browse files

Showing the changes to test/decoder/DecUT_DecExt.cpp (1 of 1 file). Show all

Unified · Split

test/decoder/DecUT_DecExt.cpp+1−0
@@ -203,6 +203,7 @@ void DecoderInterfaceTest::TestInitUninit() { · 202 unmodified lines
203203 EXPECT_EQ (eRet, cmInitExpected);
204204 }
205205 //Initialize first, can get input color format
206+ Init();
206207 m_sDecParam.bParseOnly = false;
207208 m_pDec->Initialize (&m_sDecParam);
208209

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t