History

Remove the FOPEN macro, use WelsFopen instead

This avoids ifdefs at each place the macro is used.

Martin Storsjö committed 12 years ago

Commit c174dcd1 parent 33fe2b55 files · +22 −118Browse files

Showing the changes to codec/encoder/core/src/encoder.cpp (1 of 5 files). Show all

Unified · Split

codec/encoder/core/src/encoder.cpp+8−34
@@ -324,39 +324,29 @@ extern "C" void DumpDependencyRec (SPicture* pCurPicture, const str_t* kpFileNam · 323 unmodified lines
324324
325325 if (bDependencyRecFlag[kiDid]) {
326326 if (STRNLEN (kpFileName, MAX_FNAME_LEN) > 0) // confirmed_safe_unsafe_usage
327−#if defined(__GNUC__) || (defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER<1500))
328− pDumpRecFile = FOPEN (kpFileName, "ab");
329−#elif defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
330− FOPEN (&pDumpRecFile, kpFileName, "ab");
331−#endif//__GNUC__..
327+ pDumpRecFile = WelsFopen (kpFileName, "ab");
332328 else {
333329 str_t sDependencyRecFileName[16] = {0};
334330 #if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
335331 SNPRINTF (sDependencyRecFileName, 16, 16, "rec%d.yuv", kiDid); // confirmed_safe_unsafe_usage
336− FOPEN (&pDumpRecFile, sDependencyRecFileName, "ab");
337332 #else
338333 SNPRINTF (sDependencyRecFileName, 16, "rec%d.yuv", kiDid); // confirmed_safe_unsafe_usage
339− pDumpRecFile = FOPEN (sDependencyRecFileName, "ab");
340334 #endif//WIN32..
335+ pDumpRecFile = WelsFopen (sDependencyRecFileName, "ab");
341336 }
342337 if (NULL != pDumpRecFile)
343338 fseek (pDumpRecFile, 0, SEEK_END);
344339 } else {
345340 if (STRNLEN (kpFileName, MAX_FNAME_LEN) > 0) { // confirmed_safe_unsafe_usage
346−#if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
347− FOPEN (&pDumpRecFile, kpFileName, "wb");
348−#else
349− pDumpRecFile = FOPEN (kpFileName, "wb");
350−#endif//WIN32..
341+ pDumpRecFile = WelsFopen (kpFileName, "wb");
351342 } else {
352343 str_t sDependencyRecFileName[16] = {0};
353344 #if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
354345 SNPRINTF (sDependencyRecFileName, 16, 16, "rec%d.yuv", kiDid); // confirmed_safe_unsafe_usage
355− FOPEN (&pDumpRecFile, sDependencyRecFileName, "wb");
356346 #else
357347 SNPRINTF (sDependencyRecFileName, 16, "rec%d.yuv", kiDid); // confirmed_safe_unsafe_usage
358− pDumpRecFile = FOPEN (sDependencyRecFileName, "wb");
359348 #endif//WIN32..
349+ pDumpRecFile = WelsFopen (sDependencyRecFileName, "wb");
360350 }
361351 bDependencyRecFlag[kiDid] = true;
362352 }
@@ -410,33 +400,17 @@ void DumpRecFrame (SPicture* pCurPicture, const str_t* kpFileName) { · 47 unmodified lines
410400
411401 if (bRecFlag) {
412402 if (STRNLEN (kpFileName, MAX_FNAME_LEN) > 0) { // confirmed_safe_unsafe_usage
413−#if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
414− FOPEN (&pDumpRecFile, kpFileName, "ab");
415−#else
416− pDumpRecFile = FOPEN (kpFileName, "ab");
417−#endif//WIN32
403+ pDumpRecFile = WelsFopen (kpFileName, "ab");
418404 } else {
419−#if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
420− FOPEN (&pDumpRecFile, "rec.yuv", "ab");
421−#else
422− pDumpRecFile = FOPEN ("rec.yuv", "ab");
423−#endif//WIN32
405+ pDumpRecFile = WelsFopen ("rec.yuv", "ab");
424406 }
425407 if (NULL != pDumpRecFile)
426408 fseek (pDumpRecFile, 0, SEEK_END);
427409 } else {
428410 if (STRNLEN (kpFileName, MAX_FNAME_LEN) > 0) { // confirmed_safe_unsafe_usage
429−#if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
430− FOPEN (&pDumpRecFile, kpFileName, "wb");
431−#else
432− pDumpRecFile = FOPEN (kpFileName, "wb");
433−#endif//WIN32
411+ pDumpRecFile = WelsFopen (kpFileName, "wb");
434412 } else {
435−#if defined(_WIN32) && defined(_MSC_VER) && (_MSC_VER>=1500) // vs2008
436− FOPEN (&pDumpRecFile, "rec.yuv", "wb");
437−#else
438− pDumpRecFile = FOPEN ("rec.yuv", "wb");
439−#endif//WIN32..
413+ pDumpRecFile = WelsFopen ("rec.yuv", "wb");
440414 }
441415 bRecFlag = true;
442416 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t