mark apple targets with a boolean

It is more natural to branch on a flag than have different function pointers for high-level passes.

Quentin Carbonneaux committed 4 years ago

Commit b03a8971 parent a7e16028 files · +41 −86Browse files

Unified · Split

8 files

all.h +1 −0
amd64/all.h +1 −2
amd64/emit.c +4 −15
amd64/targ.c +2 −2
arm64/abi.c +19 −39
arm64/all.h +0 −2
arm64/emit.c +11 −22
arm64/targ.c +3 −4

@@ -41,6 +41,7 @@ enum { · 40 unmodified lines
41		41
42	struct Target {	42	struct Target {
43	char name[16];	43	char name[16];
		44	char apple;
44	int gpr0; /* first general purpose reg */	45	int gpr0; /* first general purpose reg */
45	int ngpr;	46	int ngpr;
46	int fpr0; /* first floating point reg */	47	int fpr0; /* first floating point reg */

amd64/all.h+1−2

@@ -67,5 +67,4 @@ void amd64_sysv_abi(Fn *); · 66 unmodified lines
67	void amd64_isel(Fn *);	67	void amd64_isel(Fn *);
68		68
69	/* emit.c */	69	/* emit.c */
70	void amd64_sysv_emitfn(Fn , FILE );	70	void amd64_emitfn(Fn , FILE );
71	void amd64_apple_emitfn(Fn , FILE );

amd64/emit.c+4−15

@@ -538,8 +538,8 @@ framesz(Fn *fn) · 537 unmodified lines
538	return 4f + 8o + 176*fn->vararg;	538	return 4f + 8o + 176*fn->vararg;
539	}	539	}
540		540
541	static void	541	void
542	emitfn(Fn fn, FILE f)	542	amd64_emitfn(Fn fn, FILE f)
543	{	543	{
544	static char *ctoa[] = {	544	static char *ctoa[] = {
545	#define X(c, s) [c] = s,	545	#define X(c, s) [c] = s,
@@ -620,17 +620,6 @@ emitfn(Fn fn, FILE f) · 74 unmodified lines
620	}	620	}
621	}	621	}
622	id0 += fn->nblk;	622	id0 += fn->nblk;
623	}	623	if (!T.apple)
624		624	elf_emitfnfin(fn->name, f);
625	void
626	amd64_sysv_emitfn(Fn fn, FILE f)
627	{
628	emitfn(fn, f);
629	elf_emitfnfin(fn->name, f);
630	}
631
632	void
633	amd64_apple_emitfn(Fn fn, FILE f)
634	{
635	emitfn(fn, f);
636	}	625	}

amd64/targ.c+2−2

 	.abi0 = elimsb, \
 	.abi1 = amd64_sysv_abi, \
 	.isel = amd64_isel, \
+	.emitfn = amd64_emitfn, \
 Target T_amd64_sysv = {
 	.name = "amd64_sysv",
-	.emitfn = amd64_sysv_emitfn,
 	.emitfin = elf_emitfin,
 	.asloc = ".L",
 	AMD64_COMMON
 Target T_amd64_apple = {
 	.name = "amd64_apple",
-	.emitfn = amd64_apple_emitfn,
+	.apple = 1,
 	.emitfin = macho_emitfin,
 	.asloc = "L",
 	.assym = "_",

arm64/abi.c+19−39

 	Cptr = 2, /* replaced by a pointer */
 };
-struct Abi {
-	void (*vastart)(Fn *, Params, Ref);
-	void (*vaarg)(Fn *, Blk *, Ins *);
-	int apple;
-};
 struct Class {
 	char class;
 	char ishfa;
 }
 static int
-argsclass(Ins *i0, Ins *i1, Class *carg, int apple)
+argsclass(Ins *i0, Ins *i1, Class *carg)
 {
 	int va, envc, ngp, nfp, *gp, *fp;
 	Class *c;
 		case Opar:
 		case Oarg:
 			c->size = 8;
-			if (apple && !KWIDE(i->cls))
+			if (T.apple && !KWIDE(i->cls))
 				c->size = 4;
 		Scalar:
 			c->align = c->size;
 			envc = 1;
 			break;
 		case Oargv:
-			va = apple != 0;
+			va = T.apple != 0;
 			break;
 		default:
 			die("unreachable");
 }
 static void
-selcall(Fn *fn, Ins *i0, Ins *i1, Insl **ilp, int apple)
+selcall(Fn *fn, Ins *i0, Ins *i1, Insl **ilp)
 {
 	Ins *i;
 	Class *ca, *c, cr;
 	Ref r, rstk, tmp[4];
 	ca = alloc((i1-i0) * sizeof ca[0]);
-	cty = argsclass(i0, i1, ca, apple);
+	cty = argsclass(i0, i1, ca);
 	stk = 0;
 	for (i=i0, c=ca; i<i1; i++, c++) {
 }
 static Params
-selpar(Fn *fn, Ins *i0, Ins *i1, int apple)
+selpar(Fn *fn, Ins *i0, Ins *i1)
 {
 	Class *ca, *c, cr;
 	Insl *il;
 	ca = alloc((i1-i0) * sizeof ca[0]);
 	curi = &insb[NIns];
-	cty = argsclass(i0, i1, ca, apple);
+	cty = argsclass(i0, i1, ca);
 	fn->reg = arm64_argregs(CALL(cty), 0);
 	il = 0;
 	emit(Oadd, Kl, r0, ap, getcon(28, fn));
 }
-static void
+void
-abi(Fn *fn, Abi abi)
+arm64_abi(Fn *fn)
 {
 	Blk *b;
 	Ins *i, *i0, *ip;
 	for (b=fn->start, i=b->ins; i<&b->ins[b->nins]; i++)
 		if (!ispar(i->op))
 			break;
-	p = selpar(fn, b->ins, i, abi.apple);
+	p = selpar(fn, b->ins, i);
 	n = b->nins - (i - b->ins) + (&insb[NIns] - curi);
 	i0 = alloc(n * sizeof(Ins));
 	ip = icpy(ip = i0, curi, &insb[NIns] - curi);
 				for (i0=i; i0>b->ins; i0--)
 					if (!isarg((i0-1)->op))
 						break;
-				selcall(fn, i0, i, &il, abi.apple);
+				selcall(fn, i0, i, &il);
 				i = i0;
 				break;
 			case Ovastart:
-				abi.vastart(fn, p, i->arg[0]);
+				if (T.apple)
+					apple_selvastart(fn, p, i->arg[0]);
+				else
+					arm64_selvastart(fn, p, i->arg[0]);
 				break;
 			case Ovaarg:
-				abi.vaarg(fn, b, i);
+				if (T.apple)
+					apple_selvaarg(fn, b, i);
+				else
+					arm64_selvaarg(fn, b, i);
 				break;
 			case Oarg:
 			case Oargc:
 	}
 }
-void
-arm64_abi(Fn *fn)
-{
-	abi(fn, (Abi){
-		arm64_selvastart,
-		arm64_selvaarg,
-		0
-	});
-}
-void
-apple_abi(Fn *fn)
-{
-	abi(fn, (Abi){
-		apple_selvastart,
-		apple_selvaarg,
-		1
-	});
-}
 /* abi0 for apple target; introduces
  * necessery sign extension for arg
  * passing & returns

arm64/all.h+0−2

 bits arm64_argregs(Ref, int[2]);
 void arm64_abi(Fn *);
 void apple_extsb(Fn *);
-void apple_abi(Fn *);
 /* isel.c */
 int arm64_logimm(uint64_t, int);
 /* emit.c */
 void arm64_emitfn(Fn *, FILE *);
-void apple_emitfn(Fn *, FILE *);

arm64/emit.c+11−22

 	Fn *fn;
 	uint64_t frame;
 	uint padding;
-	int apple;
 };
 #define CMP(X) \
 	if (s == -1)
 		return 16 + e->frame;
 	if (s < 0) {
-		if (e->fn->vararg && !e->apple)
+		if (e->fn->vararg && !T.apple)
 			return 16 + e->frame + 192 - (s+2);
 		else
 			return 16 + e->frame - (s+2);
 		fprintf(e->f, "\tadd\t%s, %s, #:tprel_lo12_nc:%s%s%s\n",
 			rn, rn, p, l, off);
 	} else {
-		fprintf(e->f, ldsym[e->apple][0], rn, p, l, off);
+		fprintf(e->f, ldsym[T.apple != 0][0], rn, p, l, off);
-		fprintf(e->f, ldsym[e->apple][1], rn, rn, p, l, off);
+		fprintf(e->f, ldsym[T.apple != 0][1], rn, rn, p, l, off);
 	}
 }
 */
-static void
+void
-emitfn(E *e)
+arm64_emitfn(Fn *fn, FILE *out)
 {
 	static char *ctoa[] = {
 	#define X(c, s) [c] = s,
 	uint64_t o;
 	Blk *b, *t;
 	Ins *i;
+	E *e;
+	e = &(E){.f = out, .fn = fn};
+	if (T.apple)
+		e->fn->lnk.align = 4;
 	emitfnlnk(e->fn->name, &e->fn->lnk, e->f);
 	framelayout(e);
-	if (e->fn->vararg && !e->apple) {
+	if (e->fn->vararg && !T.apple) {
 		for (n=7; n>=0; n--)
 			fprintf(e->f, "\tstr\tq%d, [sp, -16]!\n", n);
 		for (n=7; n>=0; n-=2)
 			if (e->fn->dynalloc)
 				fputs("\tmov sp, x29\n", e->f);
 			o = e->frame + 16;
-			if (e->fn->vararg && !e->apple)
+			if (e->fn->vararg && !T.apple)
 				o += 192;
 			if (o <= 504)
 				fprintf(e->f,
 	}
 	id0 += e->fn->nblk;
 }
-void
-arm64_emitfn(Fn *fn, FILE *out)
-{
-	emitfn(&(E){.f = out, .fn = fn, .apple = 0});
-	elf_emitfnfin(fn->name, out);
-}
-void
-apple_emitfn(Fn *fn, FILE *out)
-{
-	fn->lnk.align = 4;
-	emitfn(&(E){.f = out, .fn = fn, .apple = 1});
-}

arm64/targ.c+3−4

 	.argregs = arm64_argregs, \
 	.memargs = arm64_memargs, \
 	.isel = arm64_isel, \
+	.abi1 = arm64_abi, \
+	.emitfn = arm64_emitfn, \
 Target T_arm64 = {
 	.name = "arm64",
 	.abi0 = elimsb,
-	.abi1 = arm64_abi,
-	.emitfn = arm64_emitfn,
 	.emitfin = elf_emitfin,
 	.asloc = ".L",
 	ARM64_COMMON
 Target T_arm64_apple = {
 	.name = "arm64_apple",
+	.apple = 1,
 	.abi0 = apple_extsb,
-	.abi1 = apple_abi,
-	.emitfn = apple_emitfn,
 	.emitfin = macho_emitfin,
 	.asloc = "L",
 	.assym = "_",

mark apple targets with a boolean

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code