To support this change, turn on lots more compiler warnings, and fix all the warnings generated.
Showing the changes to src/reverb.c (1 of 93 files). Show all
Unified · Split
| @@ -104,18 +104,18 @@ static st_effect_t st_reverb_effect; · 103 unmodified lines | |||
| 104 | /* Private data for SKEL file */ | 104 | /* Private data for SKEL file */ |
| 105 | typedef struct reverbstuff { | 105 | typedef struct reverbstuff { |
| 106 | int counter; | 106 | int counter; |
| 107 | int numdelays; | 107 | size_t numdelays; |
| 108 | float *reverbbuf; | 108 | float *reverbbuf; |
| 109 | float in_gain, out_gain, time; | 109 | float in_gain, out_gain, time; |
| 110 | float delay[MAXREVERBS], decay[MAXREVERBS]; | 110 | float delay[MAXREVERBS], decay[MAXREVERBS]; |
| 111 | long samples[MAXREVERBS], maxsamples; | 111 | size_t samples[MAXREVERBS], maxsamples; |
| 112 | st_sample_t pl, ppl, pppl; | 112 | st_sample_t pl, ppl, pppl; |
| 113 | } *reverb_t; | 113 | } *reverb_t; |
| 114 | 114 | ||
| 115 | /* | 115 | /* |
| 116 | * Process options | 116 | * Process options |
| 117 | */ | 117 | */ |
| 118 | int st_reverb_getopts(eff_t effp, int n, char **argv) | 118 | static int st_reverb_getopts(eff_t effp, int n, char **argv) |
| 119 | { | 119 | { |
| 120 | reverb_t reverb = (reverb_t) effp->priv; | 120 | reverb_t reverb = (reverb_t) effp->priv; |
| 121 | int i; | 121 | int i; |
| @@ -150,10 +150,10 @@ int st_reverb_getopts(eff_t effp, int n, char **argv) · 28 unmodified lines | |||
| 150 | /* | 150 | /* |
| 151 | * Prepare for processing. | 151 | * Prepare for processing. |
| 152 | */ | 152 | */ |
| 153 | int st_reverb_start(eff_t effp) | 153 | static int st_reverb_start(eff_t effp) |
| 154 | { | 154 | { |
| 155 | reverb_t reverb = (reverb_t) effp->priv; | 155 | reverb_t reverb = (reverb_t) effp->priv; |
| 156 | int i; | 156 | size_t i; |
| 157 | 157 | ||
| 158 | reverb->in_gain = 1.0; | 158 | reverb->in_gain = 1.0; |
| 159 | 159 | ||
| @@ -208,12 +208,12 @@ int st_reverb_start(eff_t effp) · 48 unmodified lines | |||
| 208 | * Processed signed long samples from ibuf to obuf. | 208 | * Processed signed long samples from ibuf to obuf. |
| 209 | * Return number of samples processed. | 209 | * Return number of samples processed. |
| 210 | */ | 210 | */ |
| 211 | int st_reverb_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, | 211 | static int st_reverb_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, |
| 212 | st_size_t *isamp, st_size_t *osamp) | 212 | st_size_t *isamp, st_size_t *osamp) |
| 213 | { | 213 | { |
| 214 | reverb_t reverb = (reverb_t) effp->priv; | 214 | reverb_t reverb = (reverb_t) effp->priv; |
| 215 | int len, done; | 215 | size_t len, done; |
| 216 | int i, j; | 216 | size_t i, j; |
| 217 | 217 | ||
| 218 | float d_in, d_out; | 218 | float d_in, d_out; |
| 219 | st_sample_t out; | 219 | st_sample_t out; |
| @@ -243,12 +243,12 @@ reverb->reverbbuf[(i + reverb->maxsamples - reverb->samples[j]) % reverb->maxsam · 23 unmodified lines | |||
| 243 | /* | 243 | /* |
| 244 | * Drain out reverb lines. | 244 | * Drain out reverb lines. |
| 245 | */ | 245 | */ |
| 246 | int st_reverb_drain(eff_t effp, st_sample_t *obuf, st_size_t *osamp) | 246 | static int st_reverb_drain(eff_t effp, st_sample_t *obuf, st_size_t *osamp) |
| 247 | { | 247 | { |
| 248 | reverb_t reverb = (reverb_t) effp->priv; | 248 | reverb_t reverb = (reverb_t) effp->priv; |
| 249 | float d_in, d_out; | 249 | float d_in, d_out; |
| 250 | st_sample_t out, l; | 250 | st_sample_t out, l; |
| 251 | int i, j; | 251 | size_t i, j; |
| 252 | st_size_t done; | 252 | st_size_t done; |
| 253 | 253 | ||
| 254 | i = reverb->counter; | 254 | i = reverb->counter; |
| @@ -280,7 +280,7 @@ reverb->reverbbuf[(i + reverb->maxsamples - reverb->samples[j]) % reverb->maxsam · 25 unmodified lines | |||
| 280 | /* | 280 | /* |
| 281 | * Clean up reverb effect. | 281 | * Clean up reverb effect. |
| 282 | */ | 282 | */ |
| 283 | int st_reverb_stop(eff_t effp) | 283 | static int st_reverb_stop(eff_t effp) |
| 284 | { | 284 | { |
| 285 | reverb_t reverb = (reverb_t) effp->priv; | 285 | reverb_t reverb = (reverb_t) effp->priv; |
| 286 | 286 | ||