To support this change, turn on lots more compiler warnings, and fix all the warnings generated.
Showing the changes to src/reverse.c (1 of 93 files). Show all
Unified · Split
| @@ -32,25 +32,11 @@ typedef struct reversestuff { · 31 unmodified lines | |||
| 32 | #define WRITING 0 | 32 | #define WRITING 0 |
| 33 | #define READING 1 | 33 | #define READING 1 |
| 34 | 34 | ||
| 35 | /* | ||
| 36 | * Process options: none in our case. | ||
| 37 | */ | ||
| 38 | |||
| 39 | int st_reverse_getopts(eff_t effp, int n, char **argv) | ||
| 40 | { | ||
| 41 | if (n) | ||
| 42 | { | ||
| 43 | st_fail(st_reverse_effect.usage); | ||
| 44 | return (ST_EOF); | ||
| 45 | } | ||
| 46 | return(ST_SUCCESS); | ||
| 47 | } | ||
| 48 | |||
| 49 | /* | 35 | /* |
| 50 | * Prepare processing: open temporary file. | 36 | * Prepare processing: open temporary file. |
| 51 | */ | 37 | */ |
| 52 | 38 | ||
| 53 | int st_reverse_start(eff_t effp) | 39 | static int st_reverse_start(eff_t effp) |
| 54 | { | 40 | { |
| 55 | reverse_t reverse = (reverse_t) effp->priv; | 41 | reverse_t reverse = (reverse_t) effp->priv; |
| 56 | reverse->fp = tmpfile(); | 42 | reverse->fp = tmpfile(); |
| @@ -67,7 +53,7 @@ int st_reverse_start(eff_t effp) · 10 unmodified lines | |||
| 67 | * Effect flow: a degenerate case: write input samples on temporary file, | 53 | * Effect flow: a degenerate case: write input samples on temporary file, |
| 68 | * don't generate any output samples. | 54 | * don't generate any output samples. |
| 69 | */ | 55 | */ |
| 70 | int st_reverse_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, | 56 | static int st_reverse_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf UNUSED, |
| 71 | st_size_t *isamp, st_size_t *osamp) | 57 | st_size_t *isamp, st_size_t *osamp) |
| 72 | { | 58 | { |
| 73 | reverse_t reverse = (reverse_t) effp->priv; | 59 | reverse_t reverse = (reverse_t) effp->priv; |
| @@ -91,7 +77,7 @@ int st_reverse_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, · 17 unmodified lines | |||
| 91 | * Effect drain: generate the actual samples in reverse order. | 77 | * Effect drain: generate the actual samples in reverse order. |
| 92 | */ | 78 | */ |
| 93 | 79 | ||
| 94 | int st_reverse_drain(eff_t effp, st_sample_t *obuf, st_size_t *osamp) | 80 | static int st_reverse_drain(eff_t effp, st_sample_t *obuf, st_size_t *osamp) |
| 95 | { | 81 | { |
| 96 | reverse_t reverse = (reverse_t) effp->priv; | 82 | reverse_t reverse = (reverse_t) effp->priv; |
| 97 | st_size_t len, nbytes; | 83 | st_size_t len, nbytes; |
| @@ -137,7 +123,7 @@ int st_reverse_drain(eff_t effp, st_sample_t *obuf, st_size_t *osamp) · 39 unmodified lines | |||
| 137 | /* | 123 | /* |
| 138 | * Close and unlink the temporary file. | 124 | * Close and unlink the temporary file. |
| 139 | */ | 125 | */ |
| 140 | int st_reverse_stop(eff_t effp) | 126 | static int st_reverse_stop(eff_t effp) |
| 141 | { | 127 | { |
| 142 | reverse_t reverse = (reverse_t) effp->priv; | 128 | reverse_t reverse = (reverse_t) effp->priv; |
| 143 | 129 | ||
| @@ -149,7 +135,7 @@ static st_effect_t st_reverse_effect = { · 5 unmodified lines | |||
| 149 | "reverse", | 135 | "reverse", |
| 150 | "Usage: Reverse effect takes no options", | 136 | "Usage: Reverse effect takes no options", |
| 151 | 0, | 137 | 0, |
| 152 | st_reverse_getopts, | 138 | st_effect_nothing_getopts, |
| 153 | st_reverse_start, | 139 | st_reverse_start, |
| 154 | st_reverse_flow, | 140 | st_reverse_flow, |
| 155 | st_reverse_drain, | 141 | st_reverse_drain, |