To support this change, turn on lots more compiler warnings, and fix all the warnings generated.
Showing the changes to src/pan.c (1 of 93 files). Show all
Unified · Split
| @@ -30,7 +30,7 @@ typedef struct { · 29 unmodified lines | ||
| 30 | 30 | /* |
| 31 | 31 | * Process options |
| 32 | 32 | */ |
| 33 | −int st_pan_getopts(eff_t effp, int n, char **argv) | |
| 33 | +static int st_pan_getopts(eff_t effp, int n, char **argv) | |
| 34 | 34 | { |
| 35 | 35 | pan_t pan = (pan_t) effp->priv; |
| 36 | 36 | |
| @@ -49,7 +49,7 @@ int st_pan_getopts(eff_t effp, int n, char **argv) · 12 unmodified lines | ||
| 49 | 49 | /* |
| 50 | 50 | * Start processing |
| 51 | 51 | */ |
| 52 | −int st_pan_start(eff_t effp) | |
| 52 | +static int st_pan_start(eff_t effp) | |
| 53 | 53 | { |
| 54 | 54 | if (effp->outinfo.channels==1) |
| 55 | 55 | st_warn("PAN onto a mono channel..."); |
| @@ -73,7 +73,7 @@ int st_pan_start(eff_t effp) · 17 unmodified lines | ||
| 73 | 73 | /* |
| 74 | 74 | * Process either isamp or osamp samples, whichever is smaller. |
| 75 | 75 | */ |
| 76 | −int st_pan_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, | |
| 76 | +static int st_pan_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, | |
| 77 | 77 | st_size_t *isamp, st_size_t *osamp) |
| 78 | 78 | { |
| 79 | 79 | pan_t pan = (pan_t) effp->priv; |
| @@ -408,15 +408,8 @@ int st_pan_flow(eff_t effp, const st_sample_t *ibuf, st_sample_t *obuf, · 328 unmodified lines | ||
| 408 | 408 | } |
| 409 | 409 | |
| 410 | 410 | /* |
| 411 | − * Do anything required when you stop reading samples. | |
| 412 | − * Don't close input file! | |
| 413 | − * | |
| 414 | − * Should have statistics on right, left, and output amplitudes. | |
| 411 | + * FIXME: Add a stop function with statistics on right, left, and output amplitudes. | |
| 415 | 412 | */ |
| 416 | −int st_pan_stop(eff_t effp) | |
| 417 | −{ | |
| 418 | − return ST_SUCCESS; | |
| 419 | −} | |
| 420 | 413 | |
| 421 | 414 | static st_effect_t st_pan_effect = { |
| 422 | 415 | "pan", |
| @@ -426,7 +419,7 @@ static st_effect_t st_pan_effect = { · 3 unmodified lines | ||
| 426 | 419 | st_pan_start, |
| 427 | 420 | st_pan_flow, |
| 428 | 421 | st_effect_nothing_drain, |
| 429 | − st_pan_stop | |
| 422 | + st_effect_nothing | |
| 430 | 423 | }; |
| 431 | 424 | |
| 432 | 425 | const st_effect_t *st_pan_effect_fn(void) |