GCC (correctly) warns about misleading indentation. Since the if clause ends with a return, the else clause and anything following it are either both executed or not at all. The code is thus correct, if confusing. Improve matters by removing the unnecessary else and fixing the indentation.
Unified · Split
| @@ -160,8 +160,8 @@ static int sox_ladspa_getopts(sox_effect_t *effp, int argc, char **argv) · 159 unmodified lines | ||
| 160 | 160 | if (l_st->desc == NULL) { |
| 161 | 161 | lsx_fail("no plugin called `%s' found", argv[0]); |
| 162 | 162 | return SOX_EOF; |
| 163 | − } else | |
| 164 | − argc--; argv++; | |
| 163 | + } | |
| 164 | + argc--; argv++; | |
| 165 | 165 | } |
| 166 | 166 | |
| 167 | 167 | /* Scan the ports for inputs and outputs */ |