tccpp.c: In TOK_GET, add comment warning about illegal cast.

Also, in tok_str_add2, use memcpy instead of the illegal cast. Unfortunately, I can't see an easy way of fixing the bug.

Edmund Grimley Evans committed 11 years ago

Commit 24308fd1 parent 20f0c171 file · +11 −8Browse files

Unified · Split

     case TOK_LSTR:
         {
             int nb_words;
-            CString *cstr;
+            CString cstr;
             nb_words = (sizeof(CString) + cv->cstr->size + 3) >> 2;
             while ((len + nb_words) > s->allocated_len)
                 str = tok_str_realloc(s);
-            cstr = (CString *)(str + len);
+            /* XXX: Insert the CString into the int array.
-            cstr->data = NULL;
+               It may end up incorrectly aligned. */
-            cstr->size = cv->cstr->size;
+            cstr.data = 0;
-            cstr->data_allocated = NULL;
+            cstr.size = cv->cstr->size;
-            cstr->size_allocated = cstr->size;
+            cstr.data_allocated = 0;
-            memcpy((char *)cstr + sizeof(CString),
+            cstr.size_allocated = cstr.size;
-                   cv->cstr->data, cstr->size);
+            memcpy(str + len, &cstr, sizeof(CString));
+            memcpy((char *)(str + len) + sizeof(CString),
+                   cv->cstr->data, cstr.size);
             len += nb_words;
         }
         break;
     case TOK_LSTR:
     case TOK_PPNUM:
     case TOK_PPSTR:
+        /* XXX: Illegal cast: the pointer p may not be correctly aligned! */
         cv->cstr = (CString *)p;
         cv->cstr->data = (char *)p + sizeof(CString);
         p += (sizeof(CString) + cv->cstr->size + 3) >> 2;

Keyboard shortcuts