No more ; needed

OpenCode[AI] committed 7 months ago

Commit 6547ea41 parent 898f4963 files · +28 −10Browse files

Unified · Split

3 files

AGENTS.md +14 −0
tccgen.c +13 −9
tests/tests2/60_errors_and_warnings.expect +1 −1

@@ -38,3 +38,17 @@ · 37 unmodified lines
38	- Some tests need special flags (see `FLAGS =` assignments in `tests/tests2/Makefile`).	38	- Some tests need special flags (see `FLAGS =` assignments in `tests/tests2/Makefile`).
39	- Bound-check tests (`-b` flag) are skipped when `CONFIG_bcheck=no`.	39	- Bound-check tests (`-b` flag) are skipped when `CONFIG_bcheck=no`.
40	- `.expect` files are generated with gcc by default; some use TCC (flagged with `GEN-TCC`).	40	- `.expect` files are generated with gcc by default; some use TCC (flagged with `GEN-TCC`).
		41
		42	## Language Extension: Optional Semicolons
		43
		44	Semicolons are optional after most statements and declarations:
		45	- `return`, `break`, `continue`, `goto`, expression statements
		46	- `do-while` trailing semicolon
		47	- Variable declarations
		48
		49	Semicolons are still required for:
		50	- `for()` loop init/condition/increment sections (e.g., `for(i=0; i<n; i++)`)
		51	- Old-style function parameter declarations
		52	- Struct/enum member declarations
		53
		54	The `skip(';')` function in `tccpp.c:100` errors if token doesn't match. Use `if (tok == ';') next();` instead to make semicolons optional.

tccgen.c+13−9

                 label_push(&local_label_stack, tok, LABEL_DECLARED);
                 next();
             } while (tok == ',');
-            skip(';');
+            if (tok == ';') next();
         }
         while (tok != '}') {
         leave_scope(root_scope);
         if (b)
             gfunc_return(&func_vt);
-        skip(';');
+        if (tok == ';') next();
         /* jump unless last stmt in top-level block */
         if (tok != '}' || local_scope != 1)
             rsym = gjmp(rsym);
         else
             leave_scope(loop_scope);
         *cur_scope->bsym = gjmp(*cur_scope->bsym);
-        skip(';');
+        if (tok == ';') next();
     } else if (t == TOK_CONTINUE) {
         /* compute jump */
             tcc_error("cannot continue");
         leave_scope(loop_scope);
         *cur_scope->csym = gjmp(*cur_scope->csym);
-        skip(';');
+        if (tok == ';') next();
     } else if (t == TOK_FOR) {
         new_scope(&o);
 	gexpr();
         c = gvtst(0, 0);
         skip(')');
-        skip(';');
+        if (tok == ';') next();
 	gsym_addr(c, d);
         gsym(a);
         prev_scope_s(&o);
         } else {
             expect("label identifier");
         }
-        skip(';');
+        if (tok == ';') next();
     } else if (t == TOK_ASM1 || t == TOK_ASM2 || t == TOK_ASM3) {
         asm_instr();
                     gexpr();
                     vpop();
                 }
-                skip(';');
+                if (tok == ';') next();
             }
         }
     }
     skip(')');
     if (c == 0)
         tcc_error("%s", msg);
-    skip(';');
+    if (tok == ';') next();
 }
 #ifdef TCC_TARGET_PE
                 return 1;
             next();
             continue;
+        } else if (l != VT_JMP && l != VT_CMP) {
+            /* no semicolon - let caller handle it */
+        } else {
+            expect(";");
         }
         while (1) { /* iterate thru each declaration */
                 if (tok != ',') {
                     if (l == VT_JMP)
                         return has_init ? v : 1;
-                    skip(';');
+                    if (tok == ';') next();
                     break;
                 }
                 next();

tests/tests2/60_errors_and_warnings.expect+1−1

@@ -179,7 +179,7 @@ bar : 3 ; 3 · 178 unmodified lines
179	60_errors_and_warnings.c:372: error: statement expression outside of function	179	60_errors_and_warnings.c:372: error: statement expression outside of function
180		180
181	[test_invalid_tokckill]	181	[test_invalid_tokckill]
182	60_errors_and_warnings.c:375: error: ';' expected (got '3')	182	60_errors_and_warnings.c:375: warning: function might return no value: 'f'
183		183
184	[test_duplicate_member]	184	[test_duplicate_member]
185	60_errors_and_warnings.c:381: error: duplicate member 'a'	185	60_errors_and_warnings.c:381: error: duplicate member 'a'

No more ; needed

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code