tests: add memory leak test

Also ... tcctest.c: - exclude stuff that gcc doesn't compile on windows. libtcc.c/tccpp.c: - use unsigned for memory sizes to avoid printf format warnings - use "file:line: message" to make IDE error parsers happy. tccgen.c: fix typo

grischka committed 9 years ago

Commit a1c12b91 parent f7fc4f07 files · +54 −37Browse files

Unified · Split

7 files

libtcc.c +13 −10
tcc.h +1 −0
tccgen.c +5 −8
tccpp.c +19 −16
tests/Makefile +8 −1
tests/tcctest.c +7 −1
tests/tests2/Makefile +1 −1

libtcc.c+13−10

 #define MEM_DEBUG_FILE_LEN 15
 struct mem_debug_header {
-    size_t      magic1;
+    unsigned magic1;
-    size_t      size;
+    unsigned size;
     struct mem_debug_header *prev;
     struct mem_debug_header *next;
-    size_t      line_num;
+    int line_num;
-    char        file_name[MEM_DEBUG_FILE_LEN + 1];
+    char file_name[MEM_DEBUG_FILE_LEN + 1];
-    size_t      magic2;
+    unsigned magic2;
 };
 typedef struct mem_debug_header mem_debug_header_t;
 static mem_debug_header_t *mem_debug_chain;
-static size_t mem_cur_size;
+static unsigned mem_cur_size;
-static size_t mem_max_size;
+static unsigned mem_max_size;
 PUB_FUNC void *tcc_malloc_debug(unsigned long size, const char *file, int line)
 {
     header = (mem_debug_header_t *)ptr;
     if (header->magic1 != MEM_DEBUG_MAGIC1 ||
         header->magic2 != MEM_DEBUG_MAGIC2 ||
-        header->size == (size_t)-1 )
+        header->size == (unsigned)-1 )
     {
         tcc_error("tcc_free check failed");
     }
     mem_cur_size -= header->size;
-    header->size = (size_t)-1;
+    header->size = (unsigned)-1;
     if (header->next)
         header->next->prev = header->prev;
     header = (mem_debug_header_t *)ptr;
     if (header->magic1 != MEM_DEBUG_MAGIC1 ||
         header->magic2 != MEM_DEBUG_MAGIC2 ||
-        header->size == (size_t)-1 )
+        header->size == (unsigned)-1 )
     {
         check_error:
             tcc_error("tcc_realloc check failed");
                 header->file_name, header->line_num, header->size);
             header = header->next;
         }
+#if MEM_DEBUG-0 == 2
+        exit(2);
+#endif
     }
     else if (bench)
         fprintf(stderr, "mem_max_size= %d bytes\n", mem_max_size);

tcc.h+1−0

@@ -71,6 +71,7 @@ · 70 unmodified lines
71	# pragma warning (disable : 4996) // The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name	71	# pragma warning (disable : 4996) // The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name
72	# pragma warning (disable : 4018) // signed/unsigned mismatch	72	# pragma warning (disable : 4018) // signed/unsigned mismatch
73	# pragma warning (disable : 4146) // unary minus operator applied to unsigned type, result still unsigned	73	# pragma warning (disable : 4146) // unary minus operator applied to unsigned type, result still unsigned
		74	# define ssize_t intptr_t
74	# endif	75	# endif
75	# undef CONFIG_TCC_STATIC	76	# undef CONFIG_TCC_STATIC
76	#endif	77	#endif

tccgen.c+5−8

             /* this is horrible, but we must also convert first
                operand */
-            vpushv(&sv);
+            if (c != 0) {
-            if (c != 2) {
+                *vtop = sv;
                 gen_cast(&type);
                 if (islv) {
                     mk_pointer(&vtop->type);
                     gaddrof();
             }
-            if (c != 0)
-                vswap();
-            vtop--;
             if (c < 0) {
                 r1 = gv(rc);
                 move_reg(r2, r1, type.t);
                 vtop->r = r2;
+                gsym(tt);
+                if (islv)
+                    indir();
             }
-            gsym(tt);
-            if (islv)
-                indir();
         }
     }
 }

tccpp.c+19−16

 #define CSTR_TAL_LIMIT      1024
 typedef struct TinyAlloc {
-    size_t  limit;
+    unsigned  limit;
-    size_t  size;
+    unsigned  size;
     uint8_t *buffer;
     uint8_t *p;
-    size_t  nb_allocs;
+    unsigned  nb_allocs;
     struct TinyAlloc *next, *top;
 #ifdef TAL_INFO
-    size_t  nb_peak;
+    unsigned  nb_peak;
-    size_t  nb_total;
+    unsigned  nb_total;
-    size_t  nb_missed;
+    unsigned  nb_missed;
     uint8_t *peak_p;
 #endif
 } TinyAlloc;
 typedef struct tal_header_t {
-    size_t  size;
+    unsigned  size;
 #ifdef TAL_DEBUG
     int     line_num; /* negative line_num used for double free check */
     char    file_name[TAL_DEBUG_FILE_LEN + 1];
 /* ------------------------------------------------------------------------- */
-ST_FUNC TinyAlloc *tal_new(TinyAlloc **pal, size_t limit, size_t size)
+static TinyAlloc *tal_new(TinyAlloc **pal, unsigned limit, unsigned size)
 {
     TinyAlloc *al = tcc_mallocz(sizeof(TinyAlloc));
     al->p = al->buffer = tcc_malloc(size);
     return al;
 }
-ST_FUNC void tal_delete(TinyAlloc *al)
+static void tal_delete(TinyAlloc *al)
 {
     TinyAlloc *next;
         while (p < al->p) {
             tal_header_t *header = (tal_header_t *)p;
             if (header->line_num > 0) {
-                fprintf(stderr, "  file %s, line %u: %u bytes\n",
+                fprintf(stderr, "%s:%d: chunk of %d bytes\n",
                         header->file_name, header->line_num, header->size);
             }
             p += header->size + sizeof(tal_header_t);
         }
+#if MEM_DEBUG-0 == 2
+        exit(2);
+#endif
     }
 #endif
     next = al->next;
     goto tail_call;
 }
-ST_FUNC void tal_free_impl(TinyAlloc *al, void *p TAL_DEBUG_PARAMS)
+static void tal_free_impl(TinyAlloc *al, void *p TAL_DEBUG_PARAMS)
 {
     if (!p)
         return;
 #ifdef TAL_DEBUG
         tal_header_t *header = (((tal_header_t *)p) - 1);
         if (header->line_num < 0) {
-            fprintf(stderr, "TAL_DEBUG: file %s, line %u double frees chunk from\n",
+            fprintf(stderr, "%s:%d: TAL_DEBUG: double frees chunk from\n",
                     file, line);
-            fprintf(stderr, "  file %s, line %u: %u bytes\n",
+            fprintf(stderr, "%s:%d: %d bytes\n",
-                    header->file_name, -header->line_num, header->size);
+                    header->file_name, (int)-header->line_num, (int)header->size);
         } else
             header->line_num = -header->line_num;
 #endif
         tcc_free(p);
 }
-ST_FUNC void *tal_realloc_impl(TinyAlloc **pal, void *p, size_t size TAL_DEBUG_PARAMS)
+static void *tal_realloc_impl(TinyAlloc **pal, void *p, unsigned size TAL_DEBUG_PARAMS)
 {
     tal_header_t *header;
     void *ret;
     int is_own;
-    size_t adj_size = (size + 3) & -4;
+    unsigned adj_size = (size + 3) & -4;
     TinyAlloc *al = *pal;
 tail_call:

tests/Makefile+8−1

 TOP = ..
 include $(TOP)/Makefile
 VPATH = $(TOPSRC)/tests $(TOPSRC) $(TOP)
-CFLAGS = -I$(TOPSRC) -I$(TOP)
+CFLAGS := $(filter-out -W% -g% -O%,$(CFLAGS)) -I$(TOPSRC)
 # what tests to run
 TESTS = \
  hello-run \
  libtest \
  test3 \
+ memtest \
  dlltest \
  abitest \
  vla_test-run \
 endif
 	@rm tcc2$(EXESUF) libtcc2$(DLLSUF)
+memtest:
+	@echo ------------ $@ ------------
+	$(CC) $(CFLAGS) $(NATIVE_DEFINES) -DONE_SOURCE -DMEM_DEBUG=2 ../tcc.c $(LIBS) -o memtest-tcc$(EXESUF)
+	./memtest-tcc$(EXESUF) $(TCCFLAGS) $(NATIVE_DEFINES) -DONE_SOURCE ../tcc.c $(LIBS)
+	./memtest-tcc$(EXESUF) $(TCCFLAGS) $(NATIVE_DEFINES) -DONE_SOURCE -run ../tcc.c $(TCCFLAGS) tcctest.c
 # memory and bound check auto test
 BOUNDS_OK  = 1 4 8 10 14

tests/tcctest.c+7−1

     printf ("oc1: %d\n", ret == (unsigned long)&var);
 }
+#ifndef _WIN32
 /* Test global asm blocks playing with aliases.  */
 void base_func(void)
 {
   char * str = ((char*)bug_table) + bug_table[1];
   return str;
 }
+#endif
 unsigned int set;
     printf("set=0x%x\n", set);
     val = 0x01020304;
     printf("swab32(0x%08x) = 0x%0x\n", val, swab32(val));
+#ifndef _WIN32
     override_func1();
     override_func2();
     /* The base_func ref from the following inline asm should find
        the global one, not the local decl from this function.  */
     asm volatile(".weak override_func3\n.set override_func3, base_func");
     override_func3();
+    printf("asmstr: %s\n", get_asm_string());
+#endif
     /* Check that we can also load structs of appropriate layout
        into registers.  */
     asm volatile("" : "=r" (asmret) : "0"(s2));
     if (!somebool)
       printf("asmbool: failed\n");
 #endif
-    printf("asmstr: %s\n", get_asm_string());
     val = 43;
     fancy_copy (&val, &val2);
     printf ("fancycpy(%d)=%d\n", val, val2);
 gate_desc a_gate_desc;
 void attrib_test(void)
 {
+#ifndef _WIN32
   printf("attr: %d %d %d %d\n", sizeof(struct Spacked),
 	 sizeof(spacked), sizeof(Spacked2), sizeof(spacked2));
   printf("attr: %d %d\n", sizeof(Spacked3), sizeof(spacked3));
   printf("attr: %d %d\n", sizeof(gate_desc), sizeof(a_gate_desc));
+#endif
 }
 extern __attribute__((__unused__)) char * __attribute__((__unused__)) *
 strange_attrib_placement (void);

tests/tests2/Makefile+1−1

@@ -63,7 +63,7 @@ all test: $(filter-out $(SKIP),$(TESTS)) · 62 unmodified lines
63		63
64	# automatically generate .expect files with gcc:	64	# automatically generate .expect files with gcc:
65	%.expect : %.c	65	%.expect : %.c
66	(gcc -w $.c -o a.exe && ./a.exe $(ARGS)) >$.expect 2>&1; rm -f a.exe	66	(gcc -w $.c -o a.exe && ./a.exe $(ARGS)) $(FILTER) >$.expect 2>&1; rm -f a.exe
67		67
68	# tell make not to delete	68	# tell make not to delete
69	.PRECIOUS: %.expect	69	.PRECIOUS: %.expect

tests: add memory leak test

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code