arm-asm: Add cdp2

Also allow instructions without condition code in the first place

Danny Milosavljevic committed 5 years ago

Commit a1dad7a1 parent 036a7fe3 files · +21 −6Browse files

Unified · Split

3 files

 static uint32_t condition_code_of_token(int token) {
     if (token < TOK_ASM_nopeq) {
-        expect("instruction");
+        expect("condition-enabled instruction");
         return 0;
     } else
         return (token - TOK_ASM_nopeq) & 15;
     Operand opcode2;
     uint8_t registers[3];
     unsigned int i;
+    uint8_t high_nibble;
     if (tok >= TOK_ASM_p0 && tok <= TOK_ASM_p15) {
         coprocessor = tok - TOK_ASM_p0;
         return;
     }
-    asm_emit_coprocessor_opcode(condition_code_of_token(token), coprocessor, opcode1.e.v, registers[0], registers[1], registers[2], opcode2.e.v, 0);
+    if (token == TOK_ASM_cdp2)
+        high_nibble = 0xF;
+    else
+        high_nibble = condition_code_of_token(token);
+    asm_emit_coprocessor_opcode(high_nibble, coprocessor, opcode1.e.v, registers[0], registers[1], registers[2], opcode2.e.v, 0);
 }
 /* data processing and single data transfer instructions only */
     }
     if (token == TOK_EOF)
         return;
-    if (token < TOK_ASM_nopeq) {
+    if (token < TOK_ASM_nopeq) { // no condition code
-        expect("instruction");
+        switch (token) {
-        return;
+        case TOK_ASM_cdp2:
+            return asm_coprocessor_opcode(s1, token);
+        default:
+            expect("instruction");
+            return;
+        }
     }
     switch (ARM_INSTRUCTION_GROUP(token)) {

@@ -70,6 +70,10 @@ · 69 unmodified lines
70		70
71	DEF_ASM(asl)	71	DEF_ASM(asl)
72		72
		73	/* instructions that have no condition code */
		74
		75	DEF_ASM(cdp2)
		76
73	#define ARM_INSTRUCTION_GROUP(tok) ((((tok) - TOK_ASM_nopeq) & 0xFFFFFFF0) + TOK_ASM_nopeq)	77	#define ARM_INSTRUCTION_GROUP(tok) ((((tok) - TOK_ASM_nopeq) & 0xFFFFFFF0) + TOK_ASM_nopeq)
74		78
75	/* Note: condition code is 4 bits */	79	/* Note: condition code is 4 bits */

 # Note: "{r3}" is definitely different--but would complicate the assembler.
 state="`mktemp -d`"
-cat ../arm-tok.h |grep DEF_ASM_CONDED |grep -v '#define' |grep -v '/[*]' |sed -e 's;DEF_ASM_CONDED.\(.*\).$;\1;'| grep -v 'not useful' | while read s
+cat ../arm-tok.h |grep DEF_ASM |grep -v 'not useful' |grep -v '#define' |grep -v '/[*]' |sed -e 's;^[ ]*DEF_ASM[^(]*(\(.*\)).*$;\1;' | egrep -v '^((r|c|p)[0-9]+|fp|ip|sp|lr|pc|asl)$' | while read s
 do
 	ok=0
 	for args in "r3, r4, r5, r6" \
 	            "r4, #0xFFFFFF00" \
 	            "r2, #-4" \
 	            "p10, #7, c2, c0, c1, #4" \
+	            "p10, #7, r2, c0, c1, #4" \
 	            "#4" \
 	            "#-4" \
 	            ""

Keyboard shortcuts