The "open a whisky and cut your finger open" patch

Make integer constant parsing C99 compliant

Thomas Preud'homme committed 11 years ago

Commit a6c3ce61 parent ff783b93 files · +62 −37Browse files

Unified · Split

3 files

tccpp.c +41 −34
tests/tests2/72_long_long_constant.c +17 −0
tests/tests2/Makefile +4 −3

         }
     } else {
         unsigned long long n, n1;
-        int lcount, ucount;
+        int lcount, ucount, must_64bit;
+        const char *p1;
         /* integer number */
         *q = '\0';
         while(1) {
             t = *q++;
             /* no need for checks except for base 10 / 8 errors */
-            if (t == '\0') {
+            if (t == '\0')
                 break;
-            } else if (t >= 'a') {
+            else if (t >= 'a')
                 t = t - 'a' + 10;
-            } else if (t >= 'A') {
+            else if (t >= 'A')
                 t = t - 'A' + 10;
-            } else {
+            else
                 t = t - '0';
-                if (t >= b)
+            if (t >= b)
-                    tcc_error("invalid digit");
+                tcc_error("invalid digit");
-            }
             n1 = n;
             n = n * b + t;
             /* detect overflow */
             if (n < n1)
                 tcc_error("integer constant overflow");
         }
-        /* XXX: not exactly ANSI compliant */
+        /* Determine the characteristics (unsigned and/or 64bit) the type of
-        if ((n & 0xffffffff00000000LL) != 0) {
+           the constant must have according to the constant suffix(es) */
-            if ((n >> 63) != 0)
+        lcount = ucount = must_64bit = 0;
-                tok = TOK_CULLONG;
+        p1 = p;
-            else
-                tok = TOK_CLLONG;
-        } else if (n > 0x7fffffff) {
-            tok = TOK_CUINT;
-        } else {
-            tok = TOK_CINT;
-        }
-        lcount = 0;
-        ucount = 0;
         for(;;) {
             t = toup(ch);
             if (t == 'L') {
                 if (lcount >= 2)
                     tcc_error("three 'l's in integer constant");
+                if (lcount && *(p - 1) != ch)
+                    tcc_error("incorrect integer suffix: %s", p1);
                 lcount++;
 #if !defined TCC_TARGET_X86_64 || defined TCC_TARGET_PE
-                if (lcount == 2) {
+                if (lcount == 2)
-#endif
-                    if (tok == TOK_CINT)
-                        tok = TOK_CLLONG;
-                    else if (tok == TOK_CUINT)
-                        tok = TOK_CULLONG;
-#if !defined TCC_TARGET_X86_64 || defined TCC_TARGET_PE
-                }
 #endif
+                    must_64bit = 1;
                 ch = *p++;
             } else if (t == 'U') {
                 if (ucount >= 1)
                     tcc_error("two 'u's in integer constant");
                 ucount++;
-                if (tok == TOK_CINT)
-                    tok = TOK_CUINT;
-                else if (tok == TOK_CLLONG)
-                    tok = TOK_CULLONG;
                 ch = *p++;
             } else {
                 break;
             }
         }
+        /* Whether 64 bits are needed to hold the constant's value */
+        if (n & 0xffffffff00000000LL || must_64bit) {
+            tok = TOK_CLLONG;
+            n1 = n >> 32;
+	} else {
+            tok = TOK_CINT;
+            n1 = n;
+        }
+        /* Whether type must be unsigned to hold the constant's value */
+        if (ucount || ((n1 >> 31) && (b != 10))) {
+            if (tok == TOK_CLLONG)
+                tok = TOK_CULLONG;
+            else
+                tok = TOK_CUINT;
+        /* If decimal and no unsigned suffix, bump to 64 bits or throw error */
+        } else if (n1 >> 31) {
+            if (tok == TOK_CINT)
+                tok = TOK_CLLONG;
+            else
+                tcc_error("integer constant overflow");
+        }
         if (tok == TOK_CINT || tok == TOK_CUINT)
             tokc.ui = n;
         else

tests/tests2/72_long_long_constant.c+17−0

@@ -0,0 +1,17 @@
	1	#include <stdio.h>
	2
	3	int main()
	4	{
	5	long long int res = 0;
	6
	7	if (res < -2147483648LL) {
	8	printf("Error: 0 < -2147483648\n");
	9	return 1;
	10	}
	11	else
	12	if (2147483647LL < res) {
	13	printf("Error: 2147483647 < 0\n");
	14	return 2;
	15	}
	16	return 0;
	17	}

tests/tests2/Makefile+4−3

  69_macro_param_list_err_2.test \
  70_floating_point_literals.test \
  71_macro_empty_arg.test \
+ 72_long_long_constant.test \
 # 34_array_assignment.test -- array assignment is not in C standard
 all test: $(filter-out $(SKIP),$(TESTS))
-%.test: %.c %.expect
+%.test: %.c
 	@echo Test: $*...
 	@$(TCC) -run $< $(ARGS) 2>&1 | grep -v 'warning: soft float ABI currently not supported: default to softfp' >$*.output || true
-	@diff -bu $*.expect $*.output && rm -f $*.output
+	@diff -Nbu $*.expect $*.output && rm -f $*.output
 	@($(TCC) $< -o $*.exe && ./$*.exe $(ARGS)) 2>&1 | grep -v 'warning: soft float ABI currently not supported: default to softfp' >$*.output2 || true
-	@diff -bu $*.expect $*.output2 && rm -f $*.output2 $*.exe
+	@diff -Nbu $*.expect $*.output2 && rm -f $*.output2 $*.exe
 clean:
 	rm -vf fred.txt *.output* *.exe

The "open a whisky and cut your finger open" patch

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code