fix another static struct init issue (arrays with unknown size at end)

Jaroslav Kysela committed 15 years ago

Commit ab73c9b1 parent dbefae53 files · +64 −31Browse files

Unified · Split

3 files

tcc.h +3 −1
tccgen.c +18 −4
tests/tcctest.c +43 −26

       func_args     : 5,
       mode          : 4,
       weak          : 1,
-      fill          : 11;
+      resize	    : 1,
+      fill          : 10;
     struct Section *section;
 } AttributeDef;
 #define FUNC_ARGS(r) (((AttributeDef*)&(r))->func_args)
 #define FUNC_ALIGN(r) (((AttributeDef*)&(r))->aligned)
 #define FUNC_PACKED(r) (((AttributeDef*)&(r))->packed)
+#define ARRAY_RESIZE(r) (((AttributeDef*)&(r))->resize)
 #define ATTR_MODE(r)  (((AttributeDef*)&(r))->mode)
 #define INT_ATTR(ad) (*(int*)(ad))

tccgen.c+18−4

     if (bt == VT_STRUCT) {
         /* struct/union */
         s = type->ref;
-        *a = s->r;
+        *a = s->r & 0xffffff;
         return s->c;
     } else if (bt == VT_PTR) {
         if (type->t & VT_ARRAY) {
 static void struct_decl(CType *type, int u)
 {
     int a, v, size, align, maxalign, c, offset;
-    int bit_size, bit_pos, bsize, bt, lbit_pos, prevbt;
+    int bit_size, bit_pos, bsize, bt, lbit_pos, prevbt, resize;
     Sym *s, *ss, *ass, **ps;
     AttributeDef ad;
     CType type1, btype;
             }
             skip('}');
         } else {
+	    resize = 0;
             maxalign = 1;
             ps = &s->next;
             prevbt = VT_INT;
                                 offset = c;
                                 if (size > 0)
                                     c += size;
+				if (size < 0)
+				    resize = 1;
                             } else {
                                 offset = 0;
                                 if (size > c)
             skip('}');
             /* store size and alignment */
             s->c = (c + maxalign - 1) & -maxalign;
-            s->r = maxalign;
+            s->r = maxalign | (resize ? (1 << 31) : 0);
         }
     }
 }
         /* we push a anonymous symbol which will contain the array
            element type */
         s = sym_push(SYM_FIELD, type, 0, n);
+	if (n < 0)
+		ARRAY_RESIZE(s->r) = 1;
         type->t = t1 | VT_ARRAY | VT_PTR;
         type->ref = s;
     }
             }
         } else {
             index = 0;
+	    if (ARRAY_RESIZE(s->r))
+		n = -1;
             while (tok != '}') {
                 decl_designator(type, sec, c, &index, NULL, size_only);
                 if (n >= 0 && index >= n)
         array_length = 0;
         index = 0;
         n = s->c;
+	if (s->r & (1<<31))
+	    n = -1;
         while (tok != '}') {
             decl_designator(type, sec, c, NULL, &f, size_only);
             index = f->c;
             skip(',');
         }
         /* put zeros at the end */
-        if (!size_only && array_length < n) {
+        if (!size_only && n >= 0 && array_length < n) {
             init_putz(type, sec, c + array_length,
                       n - array_length);
         }
             skip(')');
             par_count--;
         }
+	if (n < 0)
+	    s->c = array_length;
     } else if (tok == '{') {
         next();
         decl_initializer(type, sec, c, first, size_only);
     TokenString init_str;
     Section *sec;
+    /* resize the struct */
+    if ((type->t & VT_BTYPE) == VT_STRUCT && (type->ref->r & (1<<31)) != 0)
+	type->ref->c = -1;
     size = type_size(type, &align);
     /* If unknown size, we must evaluate it before
        evaluating initializers because

tests/tcctest.c+43−26

     double a[0];
 };
-struct complexinit0 {
-    int a;
-    int b;
-};
-struct complexinit {
-    int a;
-    struct complexinit0 *b;
-};
-const static struct complexinit cix[] = {
-    [0] = {
-	.a = 0xfefa,
-	.b = (const struct complexinit0[]) {
-		{ 0x80, 0x81 },
-		{ 0x82, 0x83 },
-		{}
-	}
-    }
-};
 void struct_test()
 {
     struct1 *s;
     printf("st2: %d %d %d\n",
            s->f1, s->f2, s->f3);
     printf("str_addr=%x\n", (int)st1.str - (int)&st1.f1);
-    printf("cix: %d %d %d %d %d %d %d\n",
-	cix[0].a,
-	cix[0].b[0].a, cix[0].b[0].b,
-	cix[0].b[1].a, cix[0].b[1].b,
-	cix[0].b[2].a, cix[0].b[2].b);
     /* align / size tests */
     printf("aligntest1 sizeof=%d alignof=%d\n",
     [8] = 10,
 };
+struct complexinit0 {
+    int a;
+    int b;
+};
+struct complexinit {
+    int a;
+    struct complexinit0 *b;
+};
+const static struct complexinit cix[] = {
+    [0] = {
+	.a = 2000,
+	.b = (const struct complexinit0[]) {
+		{ 2001, 2002 },
+		{ 2003, 2003 },
+		{}
+	}
+    }
+};
+struct complexinit2 {
+	int a;
+	int b[];
+};
+struct complexinit2 cix21 = {
+	.a = 3000,
+	.b = { 3001, 3002, 3003 }
+};
+struct complexinit2 cix22 = {
+	.a = 4000,
+	.b = { 4001, 4002, 4003, 4004, 4005, 4006 }
+};
 void init_test(void)
 {
     int linit1 = 2;
     for(i=0;i<10;i++)
         printf("%x ", sinit18[i]);
     printf("\n");
+    /* complex init check */
+    printf("cix: %d %d %d %d %d %d %d\n",
+	cix[0].a,
+	cix[0].b[0].a, cix[0].b[0].b,
+	cix[0].b[1].a, cix[0].b[1].b,
+	cix[0].b[2].a, cix[0].b[2].b);
+    printf("cix2: %d %d\n", cix21.b[2], cix22.b[5]);
 }

fix another static struct init issue (arrays with unknown size at end)

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code