i386: Fix various testsuite issues

on 32bit long long support was sometimes broken. This fixes code-gen for long long values in switches, disables a x86-64 specific testcase and avoid an undefined shift amount. It comments out a bitfield test involving long long bitfields > 32 bit; with GCC layout they can straddle multiple words and code generation isn't prepared for this.

Michael Matz committed 9 years ago

Commit cd9514a1 parent 3980e073 files · +64 −18Browse files

Unified · Split

3 files

i386-gen.c +21 −8
tests/tcctest.c +22 −2
x86_64-gen.c +21 −8

i386-gen.c+21−8

 ST_FUNC void gtst_addr(int inv, int a)
 {
-    inv ^= (vtop--)->c.i;
+    int v = vtop->r & VT_VALMASK;
-    a -= ind + 2;
+    if (v == VT_CMP) {
-    if (a == (char)a) {
+	inv ^= (vtop--)->c.i;
-        g(inv - 32);
+	a -= ind + 2;
-        g(a);
+	if (a == (char)a) {
-    } else {
+	    g(inv - 32);
-        g(0x0f);
+	    g(a);
-        oad(inv - 16, a - 4);
+	} else {
+	    g(0x0f);
+	    oad(inv - 16, a - 4);
+	}
+    } else if ((v & ~1) == VT_JMP) {
+	if ((v & 1) != inv) {
+	    gjmp_addr(a);
+	    gsym(vtop->c.i);
+	} else {
+	    gsym(vtop->c.i);
+	    o(0x05eb);
+	    gjmp_addr(a);
+	}
+	vtop--;
     }
 }

tests/tcctest.c+22−2

 enum ELong {
     /* This is either 0 on L32 machines, or a large number
        on L64 machines.  We should be able to store this.  */
-    EL_large = (unsigned long)0xf000 << 32,
+    EL_large = ((unsigned long)0xf000 << 31) << 1,
 };
 enum { BIASU = -1U<<31 };
     else
         printf("st1.f2 != -1\n");
+#ifndef __i386__
+    /* on i386 we don't correctly support long long bit-fields.
+       The bitfields can straddle long long boundaries (at least with
+       GCC bitfield layout) and code generation isn't prepared for this
+       (would have to work with two words in that case).  */
     /* bit sizes below must be bigger than 32 since GCC doesn't allow
        long-long bitfields whose size is not bigger than int */
     struct sbf2 {
     st2.f3 = a;
     st2.f2++;
     printf("%lld %lld %lld\n", st2.f1, st2.f2, st2.f3);
+#endif
+#if 0
+    Disabled for now until further clarification re GCC compatibility
+    struct sbf3 {
+        int f1 : 7;
+        int f2 : 1;
+        char f3;
+        int f4 : 8;
+        int f5 : 1;
+        int f6 : 16;
+    } st3;
+    printf("sizeof(st3) = %d\n", sizeof(st3));
+#endif
 }
 #ifdef __x86_64__
 {
     unsigned long ret;
     int var;
-    __asm__ volatile ("movq %P1,%0" : "=r" (ret) : "p" (&var));
+    __asm__ volatile ("mov %P1,%0" : "=r" (ret) : "p" (&var));
     printf ("oc1: %d\n", ret == (unsigned long)&var);
 }
 static long cpu_number;
 void trace_console(long len, long len2)
 {
+#ifdef __x86_64__
     /* This generated invalid code when the emission of the switch
        table isn't disabled.  The asms are necessary to show the bug,
        normal statements don't work (they need to generate some code
       {
         printf("huh?\n");
       }
+#endif
 }
 void asm_test(void)
 {

x86_64-gen.c+21−8

 ST_FUNC void gtst_addr(int inv, int a)
 {
-    inv ^= (vtop--)->c.i;
+    int v = vtop->r & VT_VALMASK;
-    a -= ind + 2;
+    if (v == VT_CMP) {
-    if (a == (char)a) {
+	inv ^= (vtop--)->c.i;
-        g(inv - 32);
+	a -= ind + 2;
-        g(a);
+	if (a == (char)a) {
-    } else {
+	    g(inv - 32);
-        g(0x0f);
+	    g(a);
-        oad(inv - 16, a - 4);
+	} else {
+	    g(0x0f);
+	    oad(inv - 16, a - 4);
+	}
+    } else if ((v & ~1) == VT_JMP) {
+	if ((v & 1) != inv) {
+	    gjmp_addr(a);
+	    gsym(vtop->c.i);
+	} else {
+	    gsym(vtop->c.i);
+	    o(0x05eb);
+	    gjmp_addr(a);
+	}
+	vtop--;
     }
 }

i386: Fix various testsuite issues

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code