History

Revert "Add support for thread-local storage variables"

TLS support in tinyCC is absolutely not ready: - segment register not select in load and store - no relocation added for computing offset of per-thread symbol - no support for TLS-specific relocations - no program header added as per Drepper document about TLS This reverts commit 1c4afd13501f07a673aed5f130166f2ee0f30927.

Thomas Preud'homme committed 13 years ago

Commit cf02f921 parent 1c4afd15 files · +14 −54Browse files

Unified · Split

5 files
  1. elf.h +1 −3
  2. libtcc.c +1 −4
  3. tccelf.c +8 −21
  4. tccgen.c +4 −25
  5. tcctok.h +0 −1
elf.h+1−3
@@ -447,7 +447,6 @@ typedef struct · 446 unmodified lines
447447 #define STT_SECTION 3 /* Symbol associated with a section */
448448 #define STT_FILE 4 /* Symbol's name is file name */
449449 #define STT_NUM 5 /* Number of defined types. */
450−#define STT_TLS 6 /* Symbol is a thread-local data object */
451450 #define STT_GNU_IFUNC 10 /* Symbol is a indirect code object */
452451 #define STT_LOOS 11 /* Start of OS-specific */
453452 #define STT_HIOS 12 /* End of OS-specific */
@@ -556,8 +555,7 @@ typedef struct · 102 unmodified lines
556555 #define PT_NOTE 4 /* Auxiliary information */
557556 #define PT_SHLIB 5 /* Reserved */
558557 #define PT_PHDR 6 /* Entry for header table itself */
559−#define PT_TLS 7 /* Thread-local program segment */
560−#define PT_NUM 8 /* Number of defined types. */
558+#define PT_NUM 7 /* Number of defined types. */
561559 #define PT_LOOS 0x60000000 /* Start of OS-specific */
562560 #define PT_HIOS 0x6fffffff /* End of OS-specific */
563561 #define PT_LOPROC 0x70000000 /* Start of processor-specific */
libtcc.c+1−4
@@ -444,10 +444,7 @@ ST_FUNC void put_extern_sym2(Sym *sym, Section *section, · 443 unmodified lines
444444 } else if ((sym->type.t & VT_BTYPE) == VT_VOID) {
445445 sym_type = STT_NOTYPE;
446446 } else {
447− if (section && section->sh_flags & SHF_TLS)
448− sym_type = STT_TLS;
449− else
450− sym_type = STT_OBJECT;
447+ sym_type = STT_OBJECT;
451448 }
452449
453450 if (sym->type.t & VT_STATIC)
tccelf.c+8−21
@@ -1543,7 +1543,6 @@ static int elf_output_file(TCCState *s1, const char *filename) · 1542 unmodified lines
15431543 int fd, mode, ret;
15441544 int *section_order;
15451545 int shnum, i, phnum, file_offset, offset, size, j, sh_order_index, k;
1546− int have_tls_section = 0;
15471546 long long tmp;
15481547 addr_t addr;
15491548 Section *strsec, *s;
@@ -1862,11 +1861,6 @@ static int elf_output_file(TCCState *s1, const char *filename) · 312 unmodified lines
18621861 /* we output all sections if debug or object file */
18631862 s->sh_size = s->data_offset;
18641863 }
1865− /* if tls section we'll need to add one segment */
1866− if (s->sh_flags & SHF_TLS) {
1867− have_tls_section = 1;
1868− phnum++;
1869− }
18701864 }
18711865
18721866 /* allocate program segment headers */
@@ -1910,16 +1904,12 @@ static int elf_output_file(TCCState *s1, const char *filename) · 37 unmodified lines
19101904 if (interp)
19111905 ph += 1 + HAVE_PHDR;
19121906
1913− for(j = 0; j < 2 + have_tls_section; j++) {
1914− if (j != 2)
1915− ph->p_type = PT_LOAD;
1916− else
1917− ph->p_type = PT_TLS;
1918− ph->p_flags = PF_R;
1907+ for(j = 0; j < 2; j++) {
1908+ ph->p_type = PT_LOAD;
19191909 if (j == 0)
1920− ph->p_flags |= PF_X;
1921− else if (j == 1)
1922− ph->p_flags |= PF_W;
1910+ ph->p_flags = PF_R | PF_X;
1911+ else
1912+ ph->p_flags = PF_R | PF_W;
19231913 ph->p_align = s1->section_align;
19241914
19251915 /* we do the following ordering: interp, symbol tables,
@@ -1930,15 +1920,12 @@ static int elf_output_file(TCCState *s1, const char *filename) · 4 unmodified lines
19301920 s = s1->sections[i];
19311921 /* compute if section should be included */
19321922 if (j == 0) {
1933− if ((s->sh_flags & (SHF_ALLOC | SHF_WRITE | SHF_TLS)) !=
1923+ if ((s->sh_flags & (SHF_ALLOC | SHF_WRITE)) !=
19341924 SHF_ALLOC)
19351925 continue;
1936− } else if (j == 1) {
1937− if ((s->sh_flags & (SHF_ALLOC | SHF_WRITE | SHF_TLS)) !=
1938− (SHF_ALLOC | SHF_WRITE))
1939− continue;
19401926 } else {
1941− if ((s->sh_flags & SHF_TLS) != SHF_TLS)
1927+ if ((s->sh_flags & (SHF_ALLOC | SHF_WRITE)) !=
1928+ (SHF_ALLOC | SHF_WRITE))
19421929 continue;
19431930 }
19441931 if (s == interp) {
tccgen.c+4−25
@@ -31,7 +31,6 @@ · 30 unmodified lines
3131 ST_DATA int rsym, anon_sym, ind, loc;
3232
3333 ST_DATA Section *text_section, *data_section, *bss_section; /* predefined sections */
34−ST_DATA Section *tdata_section, *tbss_section; /* thread-local storage sections */
3534 ST_DATA Section *cur_text_section; /* current section where function code is generated */
3635 #ifdef CONFIG_TCC_ASM
3736 ST_DATA Section *last_text_section; /* to handle .previous asm directive */
@@ -3093,10 +3092,6 @@ static int parse_btype(CType *type, AttributeDef *ad) · 3055 unmodified lines
30933092 t |= VT_INLINE;
30943093 next();
30953094 break;
3096− case TOK_THREAD:
3097− t |= VT_TLS;
3098− next();
3099− break;
31003095
31013096 /* GNUC attribute */
31023097 case TOK_ATTRIBUTE1:
@@ -5500,26 +5495,10 @@ static void decl_initializer_alloc(CType *type, AttributeDef *ad, int r, · 2397 unmodified lines
55005495 /* allocate symbol in corresponding section */
55015496 sec = ad->section;
55025497 if (!sec) {
5503− if (has_init) {
5504− if (type->t & VT_TLS) {
5505− if (!tdata_section)
5506− tdata_section = new_section(tcc_state, ".tdata",
5507− SHT_PROGBITS,
5508− SHF_ALLOC | SHF_WRITE | SHF_TLS);
5509− sec = tdata_section;
5510− } else
5511− sec = data_section;
5512− }
5513− else if (tcc_state->nocommon) {
5514− if (type->t & VT_TLS) {
5515− if (!tbss_section)
5516− tbss_section = new_section(tcc_state, ".tbss",
5517− SHT_NOBITS,
5518− SHF_ALLOC | SHF_WRITE | SHF_TLS);
5519− sec = tbss_section;
5520− } else
5521− sec = bss_section;
5522− }
5498+ if (has_init)
5499+ sec = data_section;
5500+ else if (tcc_state->nocommon)
5501+ sec = bss_section;
55235502 }
55245503 if (sec) {
55255504 data_offset = sec->data_offset;
tcctok.h+0−1
@@ -10,7 +10,6 @@ · 9 unmodified lines
1010 DEF(TOK_FOR, "for")
1111 DEF(TOK_EXTERN, "extern")
1212 DEF(TOK_STATIC, "static")
13− DEF(TOK_THREAD, "__thread")
1413 DEF(TOK_UNSIGNED, "unsigned")
1514 DEF(TOK_GOTO, "goto")
1615 DEF(TOK_DO, "do")

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t