as reported in http://lists.nongnu.org/archive/html/tinycc-devel/2015-04/msg00131.html. Note that this is one of two separate VLA bugs: A. labels aren't reached by program execution, so the stack pointer is never saved B. continue doesn't restore the stack pointer as goto does This fixes only B. I'm not sure whether the same issue applies to break as well as continue. Add a test case, but disable tests #78 and #79 for now as they're not fully fixed until the issue described in http://lists.nongnu.org/archive/html/tinycc-devel/2015-04/msg00110.html is resolved.
Showing the changes to tests (3 of 4 files). Show all
Unified · Split
| @@ -0,0 +1,92 @@ | ||
| 1 | +#include <stdio.h> | |
| 2 | + | |
| 3 | +int f(void) | |
| 4 | +{ | |
| 5 | + return 5; | |
| 6 | +} | |
| 7 | + | |
| 8 | +void test1() | |
| 9 | +{ | |
| 10 | + int count = 10; | |
| 11 | + void *addr[10]; | |
| 12 | + for(;count--;) { | |
| 13 | + int a[f()]; | |
| 14 | + | |
| 15 | + addr[count] = a; | |
| 16 | + | |
| 17 | + continue; | |
| 18 | + } | |
| 19 | + | |
| 20 | + if(addr[9] == addr[0]) { | |
| 21 | + printf("OK\n"); | |
| 22 | + } else { | |
| 23 | + printf("NOT OK\n"); | |
| 24 | + } | |
| 25 | +} | |
| 26 | + | |
| 27 | +void test2() | |
| 28 | +{ | |
| 29 | + int count = 10; | |
| 30 | + void *addr[count]; | |
| 31 | + for(;count--;) { | |
| 32 | + int a[f()]; | |
| 33 | + | |
| 34 | + addr[count] = a; | |
| 35 | + | |
| 36 | + continue; | |
| 37 | + } | |
| 38 | + | |
| 39 | + if(addr[9] == addr[0]) { | |
| 40 | + printf("OK\n"); | |
| 41 | + } else { | |
| 42 | + printf("NOT OK\n"); | |
| 43 | + } | |
| 44 | +} | |
| 45 | + | |
| 46 | +void test3() | |
| 47 | +{ | |
| 48 | + int count = 10; | |
| 49 | + void *addr[count]; | |
| 50 | + while(count--) { | |
| 51 | + int a[f()]; | |
| 52 | + | |
| 53 | + addr[count] = a; | |
| 54 | + | |
| 55 | + continue; | |
| 56 | + } | |
| 57 | + | |
| 58 | + if(addr[9] == addr[0]) { | |
| 59 | + printf("OK\n"); | |
| 60 | + } else { | |
| 61 | + printf("NOT OK\n"); | |
| 62 | + } | |
| 63 | +} | |
| 64 | + | |
| 65 | +void test4() | |
| 66 | +{ | |
| 67 | + int count = 10; | |
| 68 | + void *addr[count]; | |
| 69 | + do { | |
| 70 | + int a[f()]; | |
| 71 | + | |
| 72 | + addr[count] = a; | |
| 73 | + | |
| 74 | + continue; | |
| 75 | + } while(count--); | |
| 76 | + | |
| 77 | + if(addr[9] == addr[0]) { | |
| 78 | + printf("OK\n"); | |
| 79 | + } else { | |
| 80 | + printf("NOT OK\n"); | |
| 81 | + } | |
| 82 | +} | |
| 83 | + | |
| 84 | +int main(void) | |
| 85 | +{ | |
| 86 | + test1(); | |
| 87 | + test2(); | |
| 88 | + test3(); | |
| 89 | + test4(); | |
| 90 | + | |
| 91 | + return 0; | |
| 92 | +} | |
| @@ -0,0 +1,4 @@ | ||
| 1 | +OK | |
| 2 | +OK | |
| 3 | +OK | |
| 4 | +OK | |
| @@ -96,8 +96,9 @@ TESTS = \ · 95 unmodified lines | ||
| 96 | 96 | 74_nocode_wanted.test \ |
| 97 | 97 | 75_array_in_struct_init.test \ |
| 98 | 98 | 76_dollars_in_identifiers.test \ |
| 99 | − 77_push_pop_macro.test \ | |
| 100 | − 78_vla_label.test | |
| 99 | + 77_push_pop_macro.test | |
| 100 | +# 78_vla_label.test -- currently broken | |
| 101 | +# 79_vla_continue.test -- currently broken | |
| 101 | 102 | |
| 102 | 103 | # 34_array_assignment.test -- array assignment is not in C standard |
| 103 | 104 | |