revert commit b8b6a5fd7b4e8cab8e5a5d01064cf5bf2b5eed95

As it will cause printf("%llu\n", (unsigned long long)1e19); output 9223372036854775808 instead of 10000000000000000000

kbkpbot committed 1 year ago

Commit eef2db71 parent c6afdff3 files · +4 −4Browse files

Unified · Split

3 files

                 vtop->c.i = (vtop->c.ld != 0);
             } else {
                 if(sf)
-                    /* the range of [int64_t] is enough to hold the integer part of any float value.
+                    vtop->c.i = vtop->c.ld;
-                       Meanwhile, converting negative double to unsigned integer is UB.
-                       So first convert to [int64_t] here. */
-                    vtop->c.i = (int64_t)vtop->c.ld;
                 else if (sbt_bt == VT_LLONG || (PTR_SIZE == 8 && sbt == VT_PTR))
                     ;
                 else if (sbt & VT_UNSIGNED)

@@ -7,4 +7,6 @@ int main() { · 6 unmodified lines
7	printf("%d\n", (int)-2147483648.0);	7	printf("%d\n", (int)-2147483648.0);
8	d = -2147483648.0;	8	d = -2147483648.0;
9	printf("%d\n", (int)d);	9	printf("%d\n", (int)d);
		10
		11	printf("%llu\n", (unsigned long long)1e19);
10	}	12	}

Keyboard shortcuts