Turns out that you could always cancel a completion, even if it was already done and completed, because it was never cleaned up. Release Notes: - N/A
Unified · Split
| @@ -1713,6 +1713,8 @@ impl Context { · 1712 unmodified lines | ||
| 1713 | 1713 | .insert_message_after(assistant_message.id, Role::User, MessageStatus::Done, cx) |
| 1714 | 1714 | .unwrap(); |
| 1715 | 1715 | |
| 1716 | + let pending_completion_id = post_inc(&mut self.completion_count); | |
| 1717 | + | |
| 1716 | 1718 | let task = cx.spawn({ |
| 1717 | 1719 | |this, mut cx| async move { |
| 1718 | 1720 | let stream = model.stream_completion(request, &cx); |
| @@ -1761,10 +1763,9 @@ impl Context { · 42 unmodified lines | ||
| 1761 | 1763 | })?; |
| 1762 | 1764 | smol::future::yield_now().await; |
| 1763 | 1765 | } |
| 1764 | − | |
| 1765 | 1766 | this.update(&mut cx, |this, cx| { |
| 1766 | 1767 | this.pending_completions |
| 1767 | − .retain(|completion| completion.id != this.completion_count); | |
| 1768 | + .retain(|completion| completion.id != pending_completion_id); | |
| 1768 | 1769 | this.summarize(false, cx); |
| 1769 | 1770 | })?; |
| 1770 | 1771 | |
| @@ -1806,7 +1807,7 @@ impl Context { · 35 unmodified lines | ||
| 1806 | 1807 | }); |
| 1807 | 1808 | |
| 1808 | 1809 | self.pending_completions.push(PendingCompletion { |
| 1809 | − id: post_inc(&mut self.completion_count), | |
| 1810 | + id: pending_completion_id, | |
| 1810 | 1811 | assistant_message_id: assistant_message.id, |
| 1811 | 1812 | _task: task, |
| 1812 | 1813 | }); |